[GH-ISSUE #2372 ] [FR] Markdown divider implement ___ #1006

Author

Owner

@AmanNegi commented on GitHub (Apr 30, 2023):

I would like to but I didn't get what you exactly meant by implementing a markdown syntax. If something similar is already implemented could you please redirect me?

@AmanNegi commented on GitHub (Apr 30, 2023): I would like to but I didn't get what you exactly meant by implementing a markdown syntax. If something similar is already implemented could you please redirect me?

mirror commented

Author

Owner

@annieappflowy commented on GitHub (Apr 30, 2023):

The Markdown guidebook: https://appflowy.gitbook.io/docs/essential-documentation/markdown
An example illustrating how to implement: https://github.com/AppFlowy-IO/AppFlowy/discussions/1100

@annieappflowy commented on GitHub (Apr 30, 2023): The Markdown guidebook: https://appflowy.gitbook.io/docs/essential-documentation/markdown An example illustrating how to implement: https://github.com/AppFlowy-IO/AppFlowy/discussions/1100

mirror commented

Author

Owner

@AmanNegi commented on GitHub (Apr 30, 2023):

Yeah this is similar to the Octernship task... I can surely work on this

@AmanNegi commented on GitHub (Apr 30, 2023): Yeah this is similar to the Octernship task... I can surely work on this

mirror commented

Author

Owner

@annieappflowy commented on GitHub (Apr 30, 2023):

Sounds good! Thank you 🙏

@annieappflowy commented on GitHub (Apr 30, 2023): Sounds good! Thank you 🙏

mirror commented

Author

Owner

@AmanNegi commented on GitHub (May 12, 2023):

Hey there, sorry I was busy so this issue went inactive. I just now started looking at this issue, however I just noticed that --- has been previously implemented to add divider but it doesn't work currently. Also, I wanted to ask that the appflowy_editor was previously released separately, so is this issue still relevant here?

@AmanNegi commented on GitHub (May 12, 2023): Hey there, sorry I was busy so this issue went inactive. I just now started looking at this issue, however I just noticed that `---` has been previously implemented to add divider but it doesn't work currently. Also, I wanted to ask that the `appflowy_editor` was previously released separately, so is this issue still relevant here?

mirror commented

Author

Owner

@Xazin commented on GitHub (May 12, 2023):

Hey there, sorry I was busy so this issue went inactive. I just now started looking at this issue, however I just noticed that --- has been previously implemented to add divider but it doesn't work currently. Also, I wanted to ask that the appflowy_editor was previously released separately, so is this issue still relevant here?

It should be implemented in the appflowy_editor repository.

Most, if not all, issues that have the tag Editor are related to the appflowy_editor project, and thus have to be implemented there.

All that has happened, is that the editor itself was decoupled from AppFlowy project, allowing others to easily adopt the Editor to build their own applications.

@Xazin commented on GitHub (May 12, 2023): > Hey there, sorry I was busy so this issue went inactive. I just now started looking at this issue, however I just noticed that `---` has been previously implemented to add divider but it doesn't work currently. Also, I wanted to ask that the `appflowy_editor` was previously released separately, so is this issue still relevant here? It should be implemented in the appflowy_editor repository. Most, if not all, issues that have the tag `Editor` are related to the appflowy_editor project, and thus have to be implemented there. All that has happened, is that the editor itself was decoupled from AppFlowy project, allowing others to easily adopt the Editor to build their own applications.

mirror commented

Author

Owner

@AmanNegi commented on GitHub (May 12, 2023):

Okay great thanks a lot for the clarification @Xazin. However, I believe that we are supposed to create the shortcuts, builders and menu item within the main project itself, as we already have a few under plugins\document\presentation\plugins. Correct me if I am wrong here.

Can you please clarify on this @LucasXu0.

@AmanNegi commented on GitHub (May 12, 2023): Okay great thanks a lot for the clarification @Xazin. However, I believe that we are supposed to create the shortcuts, builders and menu item within the main project itself, as we already have a few under `plugins\document\presentation\plugins`. Correct me if I am wrong here. Can you please clarify on this @LucasXu0.

mirror commented

Author

Owner

@Xazin commented on GitHub (May 12, 2023):

Okay great thanks a lot for the clarification @Xazin. However, I believe that we are supposed to create the shortcuts, builders and menu item within the main project itself, as we already have a few under plugins\document\presentation\plugins. Correct me if I am wrong here.

Can you please clarify on this @LucasXu0.

I don't think so, divider is a common markdown syntax, I'm not sure why it was implemented in the main project, it's most likely a remnant. This https://github.com/AppFlowy-IO/AppFlowy/tree/main/frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/divider should be moved to the editor at this location https://github.com/AppFlowy-IO/appflowy-editor/tree/main/lib/src/render

Along with what it touches. (And support for ___ should be added)

Similary the markdown encoder/decoder should be updated to include the divider notation support. See https://github.com/AppFlowy-IO/appflowy-editor/tree/main/lib/src/plugins/markdown

@Xazin commented on GitHub (May 12, 2023): > Okay great thanks a lot for the clarification @Xazin. However, I believe that we are supposed to create the shortcuts, builders and menu item within the main project itself, as we already have a few under `plugins\document\presentation\plugins`. Correct me if I am wrong here. > > Can you please clarify on this @LucasXu0. I don't think so, divider is a common markdown syntax, I'm not sure why it was implemented in the main project, it's most likely a remnant. This https://github.com/AppFlowy-IO/AppFlowy/tree/main/frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/divider should be moved to the editor at this location https://github.com/AppFlowy-IO/appflowy-editor/tree/main/lib/src/render Along with what it touches. (And support for `___` should be added) Similary the markdown encoder/decoder should be updated to include the divider notation support. See https://github.com/AppFlowy-IO/appflowy-editor/tree/main/lib/src/plugins/markdown

mirror commented

Author

Owner

@AmanNegi commented on GitHub (May 17, 2023):

Okay, so we are supposed to make the changes in the editor repo. Sorry for the delay, now that it's clear I will work on this immediately. ✨

@AmanNegi commented on GitHub (May 17, 2023): Okay, so we are supposed to make the changes in the editor repo. Sorry for the delay, now that it's clear I will work on this immediately. ✨

mirror commented

Author

Owner

@annieappflowy commented on GitHub (May 17, 2023):

Not related to the thread...
@AmanNegi , what's your Discord handle? Please DM me on Discord.

@annieappflowy commented on GitHub (May 17, 2023): Not related to the thread... @AmanNegi , what's your Discord handle? Please DM me on Discord.

mirror commented

Author

Owner

@annieappflowy commented on GitHub (Jun 12, 2023):

@AmanNegi , are you still working on this?

@annieappflowy commented on GitHub (Jun 12, 2023): @AmanNegi , are you still working on this?

mirror commented

Author

Owner

@AmanNegi commented on GitHub (Jun 12, 2023):

Yep now I am working on this, was waiting for the merging of develop and main branch.

@AmanNegi commented on GitHub (Jun 12, 2023): Yep now I am working on this, was waiting for the merging of `develop` and `main` branch.

mirror commented

Author

Owner

@Xazin commented on GitHub (Jun 13, 2023):

Yep now I am working on this, was waiting for the merging of develop and main branch.

See for reference https://github.com/AppFlowy-IO/appflowy-editor/pull/118
All you need to do is add a Shortcut for _ that triggers the insertDividerHandler.

On editor repo.

@Xazin commented on GitHub (Jun 13, 2023): > Yep now I am working on this, was waiting for the merging of `develop` and `main` branch. See for reference https://github.com/AppFlowy-IO/appflowy-editor/pull/118 All you need to do is add a Shortcut for `_` that triggers the insertDividerHandler. On editor repo.

mirror commented

Author

Owner

@AmanNegi commented on GitHub (Jun 13, 2023):

Thanks for the reference @Xazin. Perhaps should I move this issue in the editor_repo?

@AmanNegi commented on GitHub (Jun 13, 2023): Thanks for the reference @Xazin. Perhaps should I move this issue in the `editor_repo`?

mirror commented

Author

Owner

@Xazin commented on GitHub (Jun 13, 2023):

Thanks for the reference @Xazin. Perhaps should I move this issue in the editor_repo?

No need, it's fine, we can still link to this issue from the PR.

@Xazin commented on GitHub (Jun 13, 2023): > Thanks for the reference @Xazin. Perhaps should I move this issue in the `editor_repo`? No need, it's fine, we can still link to this issue from the PR.

mirror commented