mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 04:46:56 +00:00
[GH-ISSUE #2371] [FR] Markdown divider implement *** #1008
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#1008
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @annieappflowy on GitHub (Apr 28, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2371
Description
You can use *** on its own line to add a horizontal bar.
Impact
Markdown users
Additional Context
No response
@gunjan-l commented on GitHub (May 1, 2023):
Hey @annieappflowy , I would like to work on the task. I have one doubt regarding the issue what type of line is expected ?
Something similar to
******or-------line?@annieappflowy commented on GitHub (May 2, 2023):
This feature is implemented. It can only be triggered by
---thoughThe task is to support "***" to trigger the horizontal divider.
@gunjan-l commented on GitHub (May 13, 2023):
Hey sorry, I was busy so the issue went inactive. I just started working on the issue but I am bit confuse about where to make changes in appflowy_editor or AppFlowy project?
@Xazin commented on GitHub (May 13, 2023):
This is related to #2372
The divider is currently implemented in AppFlowy, but should be implemented in AppFlowy-Editor.
Either this issue or #2372 should migrate it to the editor, and then add their support for
***or___.In my opinion it should be one person resolving both the issues, because the logical handler of divider insertion already exists.
What this means, is that the existing solution should just be refactored to take a dynamic character, and then 3 shortcut events should use 3 handlers.
---,___,***.See for reference on how to achieve it: https://github.com/AppFlowy-IO/appflowy-editor/pull/92/files for reference.
@gunjan-l commented on GitHub (May 14, 2023):
Thanks @Xazin , correct me if I'm wrong so the changes are to be made in AppFlowy-Editor project.