[GH-ISSUE #2371] [FR] Markdown divider implement *** #1008

Closed
opened 2026-03-23 20:44:18 +00:00 by mirror · 5 comments
Owner

Originally created by @annieappflowy on GitHub (Apr 28, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2371

Description

You can use *** on its own line to add a horizontal bar.

Impact

Markdown users

Additional Context

No response

Originally created by @annieappflowy on GitHub (Apr 28, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2371 ### Description You can use *** on its own line to add a horizontal bar. ### Impact Markdown users ### Additional Context _No response_
mirror 2026-03-23 20:44:18 +00:00
Author
Owner

@gunjan-l commented on GitHub (May 1, 2023):

Hey @annieappflowy , I would like to work on the task. I have one doubt regarding the issue what type of line is expected ?
Something similar to ****** or ------- line?

<!-- gh-comment-id:1529445067 --> @gunjan-l commented on GitHub (May 1, 2023): Hey @annieappflowy , I would like to work on the task. I have one doubt regarding the issue what type of line is expected ? Something similar to ```******``` or ```-------``` line?
Author
Owner

@annieappflowy commented on GitHub (May 2, 2023):

image

This feature is implemented. It can only be triggered by --- though
The task is to support "***" to trigger the horizontal divider.

<!-- gh-comment-id:1530811813 --> @annieappflowy commented on GitHub (May 2, 2023): <img width="905" alt="image" src="https://user-images.githubusercontent.com/12026239/235572017-dac74b53-b4fe-4d6f-998d-f18ed926aafd.png"> This feature is implemented. It can only be triggered by `---` though The task is to support "***" to trigger the horizontal divider.
Author
Owner

@gunjan-l commented on GitHub (May 13, 2023):

Hey sorry, I was busy so the issue went inactive. I just started working on the issue but I am bit confuse about where to make changes in appflowy_editor or AppFlowy project?

<!-- gh-comment-id:1546617815 --> @gunjan-l commented on GitHub (May 13, 2023): Hey sorry, I was busy so the issue went inactive. I just started working on the issue but I am bit confuse about where to make changes in appflowy_editor or AppFlowy project?
Author
Owner

@Xazin commented on GitHub (May 13, 2023):

This is related to #2372

The divider is currently implemented in AppFlowy, but should be implemented in AppFlowy-Editor.

Either this issue or #2372 should migrate it to the editor, and then add their support for *** or ___.

In my opinion it should be one person resolving both the issues, because the logical handler of divider insertion already exists.

What this means, is that the existing solution should just be refactored to take a dynamic character, and then 3 shortcut events should use 3 handlers. ---, ___, ***.

See for reference on how to achieve it: https://github.com/AppFlowy-IO/appflowy-editor/pull/92/files for reference.

<!-- gh-comment-id:1546632407 --> @Xazin commented on GitHub (May 13, 2023): This is related to #2372 The divider is currently implemented in AppFlowy, but should be implemented in AppFlowy-Editor. Either this issue or #2372 should migrate it to the editor, and then add their support for `***` or `___`. In my opinion it should be one person resolving both the issues, because the logical handler of divider insertion already exists. What this means, is that the existing solution should just be refactored to take a dynamic character, and then 3 shortcut events should use 3 handlers. `---`, `___`, `***`. See for reference on how to achieve it: https://github.com/AppFlowy-IO/appflowy-editor/pull/92/files for reference.
Author
Owner

@gunjan-l commented on GitHub (May 14, 2023):

Thanks @Xazin , correct me if I'm wrong so the changes are to be made in AppFlowy-Editor project.

<!-- gh-comment-id:1546795540 --> @gunjan-l commented on GitHub (May 14, 2023): Thanks @Xazin , correct me if I'm wrong so the changes are to be made in AppFlowy-Editor project.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1008
No description provided.