[GH-ISSUE #2451 ] [Bug] Highlight default background #1053

Author

Owner

@vuzzer commented on GitHub (May 4, 2023):

Hey @annieappflowy, could you assign it to me.

@vuzzer commented on GitHub (May 4, 2023): Hey @annieappflowy, could you assign it to me.

mirror commented

Author

Owner

@annieappflowy commented on GitHub (May 5, 2023):

Assigned! Thank you

@annieappflowy commented on GitHub (May 5, 2023): Assigned! Thank you

mirror commented

Author

Owner

@vuzzer commented on GitHub (May 6, 2023):

Hey @annieappflowy, if default background option is to remove the background color, it would be better to rename this option to remove background. What do you think about it ?

@vuzzer commented on GitHub (May 6, 2023): Hey @annieappflowy, if `default background` option is to remove the background color, it would be better to rename this option to `remove background`. What do you think about it ?

mirror commented

Author

Owner

@annieappflowy commented on GitHub (May 7, 2023):

@vuzzer , "clear background" or "none"?

@annieappflowy commented on GitHub (May 7, 2023): @vuzzer , "clear background" or "none"?

mirror commented

Author

Owner

@annieappflowy commented on GitHub (May 8, 2023):

Hi @vuzzer , can this be done by Friday? Hope this bug can be fixed by Friday in the upcoming release (v0.1.5)

@annieappflowy commented on GitHub (May 8, 2023): Hi @vuzzer , can this be done by Friday? Hope this bug can be fixed by Friday in the upcoming release (v0.1.5)

mirror commented

Author

Owner

@vuzzer commented on GitHub (May 8, 2023):

Hey @annieappflowy, of course, it will be done before Friday.

@vuzzer commented on GitHub (May 8, 2023): Hey @annieappflowy, of course, it will be done before Friday.

mirror commented

Author

Owner

@richardshiue commented on GitHub (May 10, 2023):

My two cents:

I thought that the default background color depends on the theme, in this case it's blue.
The current way to de-highlight (if that's a word) text is to click on the button again. However, there is a bug where if a color other than the default were selected, it would first clear the custom color (and use the default), and then a subsequent selection and click will de-highlight the default highlight color.
It definitely would be better if I can also deselect color by clicking on it (e.g. if it's highlighted purple, I can click on purple and it will be de-highlighted).

@richardshiue commented on GitHub (May 10, 2023): My two cents: - I thought that the default background color depends on the theme, in this case it's blue. - The current way to de-highlight (if that's a word) text is to click on the button again. However, there is a bug where if a color other than the default were selected, it would first clear the custom color (and use the default), and then a subsequent selection and click will de-highlight the default highlight color. ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/a9969b60-5c33-446a-ae12-bf409638d52e) - It definitely would be better if I can also deselect color by clicking on it (e.g. if it's highlighted purple, I can click on purple and it will be de-highlighted).

mirror commented

Author

Owner

@vuzzer commented on GitHub (May 10, 2023):

Hey @annieappflowy, of course, it will be done before Friday.

I have difficulties to detect in the code base the part dedicated to the menu that appears when you select a text. I don't think I can solve this Friday.However, I am actively working on this problem. Any help is welcome. @annieappflowy @richardshiue

@vuzzer commented on GitHub (May 10, 2023): > Hey @annieappflowy, of course, it will be done before Friday. I have difficulties to detect in the code base the part dedicated to the menu that appears when you select a text. I don't think I can solve this Friday.However, I am actively working on this problem. Any help is welcome. @annieappflowy @richardshiue

mirror commented

Author

Owner

@vuzzer commented on GitHub (May 10, 2023):

My two cents:

I thought that the default background color depends on the theme, in this case it's blue.

The current way to de-highlight (if that's a word) text is to click on the button again. However, there is a bug where if a color other than the default were selected, it would first clear the custom color (and use the default), and then a subsequent selection and click will de-highlight the default highlight color.

It definitely would be better if I can also deselect color by clicking on it (e.g. if it's highlighted purple, I can click on purple and it will be de-highlighted).

I have found this problem as well @richardshiue. I have difficulties to detect in the code base the part dedicated to the menu that appears when you select a text.

@vuzzer commented on GitHub (May 10, 2023): > My two cents: > > * I thought that the default background color depends on the theme, in this case it's blue. > * The current way to de-highlight (if that's a word) text is to click on the button again. However, there is a bug where if a color other than the default were selected, it would first clear the custom color (and use the default), and then a subsequent selection and click will de-highlight the default highlight color. > ![image](https://user-images.githubusercontent.com/71320345/237297785-a9969b60-5c33-446a-ae12-bf409638d52e.png) > * It definitely would be better if I can also deselect color by clicking on it (e.g. if it's highlighted purple, I can click on purple and it will be de-highlighted). I have found this problem as well @richardshiue. I have difficulties to detect in the code base the part dedicated to the menu that appears when you select a text.

mirror commented

Author

Owner

@Xazin commented on GitHub (May 10, 2023):

This is an issue with the software design. Text background and highlight are two separate things, thus causing this weird behavior, whilst they should either be the same feature, or there should be noticeably different behavior.

@Xazin commented on GitHub (May 10, 2023): This is an issue with the software design. Text background and highlight are two separate things, thus causing this weird behavior, whilst they should either be the same feature, or there should be noticeably different behavior.

mirror commented

Author

Owner

@vuzzer commented on GitHub (May 10, 2023):

of course, although I have activated Select widget mode, to determine the toolbar that appears when you underline the text, it detects every time this widget AppFlowyEditor.

@vuzzer commented on GitHub (May 10, 2023): of course, although I have activated **Select widget mode**, to determine the toolbar that appears when you underline the text, it detects every time this widget `AppFlowyEditor`.

mirror commented