mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-28 18:06:06 +00:00
[GH-ISSUE #5493] [FR] More colours or colour picker for select #10855
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#10855
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @OctoShotG on GitHub (Jun 8, 2024).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/5493
Description
More colour options or a colour picker, such as brown, white, black, red, etc
Impact
Easier to make statuses more distinct through colours visible in grid view
Additional Context
No response
@MayurSMahajan commented on GitHub (Jun 17, 2024):
Should more colours be added here, or a way to add a custom colour should be added ?
@OctoShotG commented on GitHub (Jun 17, 2024):
Being able to pick any custom colour with something such as a RGB value would be be great for customising- most of the colours now feel quite dark and don't fit the best with some themes.
@nebiyuelias1 commented on GitHub (Jun 21, 2024):
So is the custom color input the way to go? I will be happy to work on this issue @apomalyn.
@MayurSMahajan commented on GitHub (Jun 26, 2024):
Hey @nebiyuelias1, assigning this to you. Just make sure that the custom colour input is consistent with custom colour inputs we have used in other places within appflowy. Have fun contributing!
@nebiyuelias1 commented on GitHub (Jun 26, 2024):
Oh exciting! So I saw some color picker with a dialog in the settings page. Do you think I should use that one?
@MayurSMahajan commented on GitHub (Jun 28, 2024):
Something more like this. This appears when you try changing highlight or text colour
@nebiyuelias1 commented on GitHub (Jul 4, 2024):
@MayurSMahajan I was able to add the custom color picker to the UI, but I was wondering how I could modify the protocol buffer to allow custom input. Right now it seems it's set to use integer values with an enum. Do you have any suggestions?
@MayurSMahajan commented on GitHub (Jul 5, 2024):
@nebiyuelias1 Actually I am not the best person for this question, I haven't really worked on the colour pickers. I would advice you look up the existing implementation in here:
https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/toolbar/desktop/items/color/color_picker.dart
See if that helps, otherwise we'll ask someone who knows this for help.
@nebiyuelias1 commented on GitHub (Jul 5, 2024):
@MayurSMahajan Thanks for the reply. I did check that widget but it looks like the way it works is different. Because for the value I'm trying to implement it's using a proto buff with a set of options. What I'm struggling with is how to map a custom hex value with a string to a way that is going to be used by the proto buff. A nudge in the right direction would be helpful.
@MayurSMahajan commented on GitHub (Jul 9, 2024):
Again I am not really familiar with this part of codebase, nor with protobuffs. Sorry about that!
@nebiyuelias1 commented on GitHub (Jul 9, 2024):
Ok who should I ask?
@MayurSMahajan commented on GitHub (Jul 9, 2024):
Discord would be the right place to start, also your problem seems to be more related to Protobuffs, why do you want to implement it with Protobuffs, what advantage does it have over just reusing the existing solution? Just curious.
@nebiyuelias1 commented on GitHub (Jul 9, 2024):
Honestly it's the way things work at the moment and implementing the feature request requires the modification I described.
@gustamor commented on GitHub (Aug 3, 2024):
@nebiyuelias1 How's it going?
The custom color feature for the cursor and selection in the workspace settings adds an icon to the color text box. Clicking this icon opens the color picker, which returns the corresponding color code and places it in the text box. This action does not alter any other elements; it simply updates the text box value with the selected color code and submits it in the same way as if the user had manually entered the code. I think this might work the same way.
@nebiyuelias1 commented on GitHub (Aug 3, 2024):
Hi the situation is different in this context. More info about the problem could be found here on discord: https://discord.com/channels/903549834160635914/905299371485188137/1260206983122915388.
I didn't understand how the proto buff modifications should work so I haven't made much progress on this one. Would love to get some help!
@annieappflowy commented on GitHub (Jan 3, 2025):
duplicate #5570