[GH-ISSUE #2633] [Bug] New grid row button is out of place #1134

Closed
opened 2026-03-23 20:45:47 +00:00 by mirror · 2 comments
Owner

Originally created by @richardshiue on GitHub (May 26, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2633

Originally assigned to: @LucasXu0 on GitHub.

Bug Description

The new row button looks out of place. There is a weird amount of blank space between the last row of the grid and the new row button.

How to Reproduce

Open up a grid and scroll

Expected Behavior

It should either be attached to the bottom of the row list, or just above the "Count" bar.

Operating System

Fedora 38

AppFlowy Version(s)

latest develop

Screenshots

https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/5dbbc749-d8ed-4c94-8316-0785a0909ad2

Additional Context

No response

Originally created by @richardshiue on GitHub (May 26, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2633 Originally assigned to: @LucasXu0 on GitHub. ### Bug Description The new row button looks out of place. There is a weird amount of blank space between the last row of the grid and the new row button. ### How to Reproduce Open up a grid and scroll ### Expected Behavior It should either be attached to the bottom of the row list, or just above the "Count" bar. ### Operating System Fedora 38 ### AppFlowy Version(s) latest develop ### Screenshots https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/5dbbc749-d8ed-4c94-8316-0785a0909ad2 ### Additional Context _No response_
mirror 2026-03-23 20:45:47 +00:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@appflowy commented on GitHub (May 30, 2023):

This is caused by using the SliverFillRemaining.

SliverFillRemaining: It sizes its child to fill the remaining space in the viewport. Typically, this is used for a flexible space where you don't have a specific size in mind. It can be quite useful for content that should take up the remaining available space on the screen.

It works fine if we use the SliverAnimatedList. But it does not support moving the row.

<!-- gh-comment-id:1567637126 --> @appflowy commented on GitHub (May 30, 2023): This is caused by using the SliverFillRemaining. > SliverFillRemaining: It sizes its child to fill the remaining space in the viewport. Typically, this is used for a flexible space where you don't have a specific size in mind. It can be quite useful for content that should take up the remaining available space on the screen. It works fine if we use the SliverAnimatedList. But it does not support moving the row.
Author
Owner

@Xazin commented on GitHub (May 30, 2023):

I'll take a look at this, we don't need to use SliverFillRemaining, so if that's the primary issue we can refactor that part.

<!-- gh-comment-id:1567924907 --> @Xazin commented on GitHub (May 30, 2023): I'll take a look at this, we don't need to use SliverFillRemaining, so if that's the primary issue we can refactor that part.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1134
No description provided.