mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 12:56:59 +00:00
[GH-ISSUE #2836] [FR] Persian Language #1233
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#1233
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheBinaryParadox on GitHub (Jun 18, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2836
Originally assigned to: @TheBinaryParadox on GitHub.
Description
Hi,
I want to contribute to this project by translating and add Persian language to it, can I do that? and would you like to add this language to the project?
Impact
Persian people who don't know English can use the app
Additional Context
No response
@MayurSMahajan commented on GitHub (Jun 18, 2023):
Hey @TheBinaryParadox ! It is great that you want to contribute. Please checkout this page: Translate AppFlowy. Also take a look at the contributor's guidelines.
@AmirLavasani commented on GitHub (Aug 14, 2023):
Is this issue still ongoing? I'd like to help with this issue.
@MayurSMahajan commented on GitHub (Aug 14, 2023):
Hey @TheBinaryParadox, are you still working on this?
@MayurSMahajan commented on GitHub (Aug 15, 2023):
@AmirLavasani you can start working and submit a Pull Request
@AmirLavasani commented on GitHub (Aug 15, 2023):
Alright, I will start to work on this.
@AmirLavasani commented on GitHub (Aug 19, 2023):
I hope you are doing well, I have made the translation JSON file for the Persian language. You can check the files in my fork here: https://github.com/AmirLavasani/AppFlowy/tree/feat/persian_lang_2836.
However, I cannot build the project to test the translations. Here is the log for the error. @MayurSMahajan can you check this out?
Here is the command I used:
cargo make --profile production-linux-x86_64 appflowyThe main error line is this:
[ +1 ms] [+11018 ms] packages/flowy_infra_ui/lib/widget/dialog/styled_dialogs.dart:74:27: Error: The argument type 'BorderRadius?' can't be assigned to the parameter type 'BorderRadiusGeometry' because 'BorderRadius?' is nullable and 'BorderRadiusGeometry' isn't.More of the log:
@MayurSMahajan commented on GitHub (Aug 19, 2023):
hey @AmirLavasani, can you try Running the application without building (using VS Code)
cc: @richardshiue, @rileyhawk1417
shouldn't developers run
cargo make --profile development-linux-x86_64 appflowy-devinstead of
cargo make --profile production-linux-x86_64 appflowyon our docs, we are showing building release binary first and debug binary is hidden.
@richardshiue commented on GitHub (Aug 19, 2023):
Hi @AmirLavasani, the PR looks good to me. Our application is currently being built against flutter 3.10.1. Based on your logs, I'm guessing that you installed flutter from snapcraft which is using the latest version. That package includes this commit which makes our code incompatible. If you'd like to test, please downgrade your flutter version.
@AmirLavasani commented on GitHub (Aug 19, 2023):
Alright, I'll create the PR.
I tested and the error was due to the flutter version. Thanks for the help 🙏