[PR #719] [MERGED] Feat replace commit lint with gitlint #12707

Closed
opened 2026-03-24 21:42:29 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/719
Author: @MikeWallaceDev
Created: 7/25/2022
Status: Merged
Merged: 7/26/2022
Merged by: @appflowy

Base: mainHead: feat_replace_commit_lint_with_gitlint


📝 Commits (6)

  • 943ce37 feat: remove commitlint and node.js dependency
  • f993e1d feat: add gitlint dependency
  • c45e451 feat: Improved commit githooks messages
  • db2a273 fix: put back commintlint config because the server will need it
  • 30db03f fix: made the regex match commitlint more closely
  • 244549b fix: bah! removing duplicate code.

📊 Changes

10 files changed (+88 additions, -64 deletions)

View changed files

📝 .githooks/commit-msg (+28 -3)
📝 .githooks/pre-commit (+18 -1)
📝 .githooks/pre-push (+24 -6)
📝 .gitignore (+3 -0)
📝 commitlint.config.js (+1 -0)
📝 frontend/Makefile.toml (+0 -1)
📝 frontend/scripts/install_dev_env/install_linux.sh (+7 -4)
📝 frontend/scripts/install_dev_env/install_macos.sh (+7 -4)
frontend/scripts/makefile/githooks.toml (+0 -39)
package.json (+0 -6)

📄 Description

I was able to remove the dependencies to : npm, node.js and commitlint
I replaced commitlint with go-gitlint which is an executable
This change does not change the github action at all. Github will still use commitlint.
I made the gitlint parameters match the commitlint parameters.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/719 **Author:** [@MikeWallaceDev](https://github.com/MikeWallaceDev) **Created:** 7/25/2022 **Status:** ✅ Merged **Merged:** 7/26/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat_replace_commit_lint_with_gitlint` --- ### 📝 Commits (6) - [`943ce37`](https://github.com/AppFlowy-IO/AppFlowy/commit/943ce37623a794bcd70ea5355d7e7ab64b20b2a9) feat: remove commitlint and node.js dependency - [`f993e1d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f993e1d076b05f0bed3bc5231eca4aede9e73019) feat: add gitlint dependency - [`c45e451`](https://github.com/AppFlowy-IO/AppFlowy/commit/c45e4515bb975fdcc18c2c706c337930dacd2296) feat: Improved commit githooks messages - [`db2a273`](https://github.com/AppFlowy-IO/AppFlowy/commit/db2a27384505e5f9f414f98f38ab70d07e0a0352) fix: put back commintlint config because the server will need it - [`30db03f`](https://github.com/AppFlowy-IO/AppFlowy/commit/30db03f3dfb4942218f9b695e01170bfc3e28feb) fix: made the regex match commitlint more closely - [`244549b`](https://github.com/AppFlowy-IO/AppFlowy/commit/244549b1672f6642d9f6cf6095a3d4d86c0830cd) fix: bah! removing duplicate code. ### 📊 Changes **10 files changed** (+88 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `.githooks/commit-msg` (+28 -3) 📝 `.githooks/pre-commit` (+18 -1) 📝 `.githooks/pre-push` (+24 -6) 📝 `.gitignore` (+3 -0) 📝 `commitlint.config.js` (+1 -0) 📝 `frontend/Makefile.toml` (+0 -1) 📝 `frontend/scripts/install_dev_env/install_linux.sh` (+7 -4) 📝 `frontend/scripts/install_dev_env/install_macos.sh` (+7 -4) ➖ `frontend/scripts/makefile/githooks.toml` (+0 -39) ➖ `package.json` (+0 -6) </details> ### 📄 Description I was able to remove the dependencies to : npm, node.js and commitlint I replaced commitlint with go-gitlint which is an executable This change does not change the github action at all. Github will still use commitlint. I made the gitlint parameters match the commitlint parameters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-24 21:42:29 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#12707
No description provided.