AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 04:46:56 +00:00

[GH-ISSUE #3063] [Bug] Callout Text Theme Issues #1347

New issue

Closed

opened 2026-03-23 20:48:08 +00:00 by mirror · 3 comments

mirror commented

2026-03-23 20:48:08 +00:00

Owner

Originally created by @AmanNegi on GitHub (Jul 26, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3063

Originally assigned to: @AmanNegi on GitHub.

Bug Description

We offer users the ability to choose a color for the callout in our application. However, this customization option often leads to issues such as unreadable text and poor visibility.

How to Reproduce

Simply add a callout item, and try to change to different colors and you will find wierd contrast theming issues.

Expected Behavior

To rectify this problem, we propose implementing a solution where a specific text color is automatically assigned based on the chosen background color.

Operating System

Ubuntu

AppFlowy Version(s)

Latest

Screenshots

Additional Context

No response

Originally created by @AmanNegi on GitHub (Jul 26, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3063 Originally assigned to: @AmanNegi on GitHub. ### Bug Description We offer users the ability to choose a color for the callout in our application. However, this customization option often leads to issues such as unreadable text and poor visibility. ### How to Reproduce Simply add a callout item, and try to change to different colors and you will find wierd contrast theming issues. ### Expected Behavior To rectify this problem, we propose implementing a solution where a specific text color is automatically assigned based on the chosen background color. ### Operating System Ubuntu ### AppFlowy Version(s) Latest ### Screenshots ![callout](https://github.com/AppFlowy-IO/AppFlowy/assets/37607224/61b7b174-b21e-4b82-ba14-69fcf8f241a0) ### Additional Context _No response_

mirror closed this issue

2026-03-23 20:48:08 +00:00

mirror commented

2026-03-23 20:48:09 +00:00

Author

Owner

@hyj1204 commented on GitHub (Jul 26, 2023):

Perhaps it's a good idea to update the background color choices for the callout to address the visiable issue with the current dark mode.

The default text color in the data format is actually null for the font color attribute. It is rendered based on the current theme. Therefore, I suggest not changing the text color and instead adjusting the background colors for the callout to better suit the dark mode.

@hyj1204 commented on GitHub (Jul 26, 2023): Perhaps it's a good idea to update the background color choices for the callout to address the visiable issue with the current dark mode. <img width="321" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/14248245/588a25d0-3da6-431d-9800-69bf82fea01f"> The default text color in the data format is actually `null` for the font color attribute. It is rendered based on the current theme. Therefore, I suggest not changing the text color and instead adjusting the background colors for the callout to better suit the dark mode.

mirror commented

2026-03-23 20:48:09 +00:00

Author

Owner

@AmanNegi commented on GitHub (Jul 27, 2023):

@hyj1204 Yeah, I guess we should go ahead with that. I will try to come up with a list of colors matching previous ones, which should go well in both themes.

@AmanNegi commented on GitHub (Jul 27, 2023): @hyj1204 Yeah, I guess we should go ahead with that. I will try to come up with a list of colors matching previous ones, which should go well in both themes.

mirror commented

2026-03-23 20:48:09 +00:00

Author

Owner

@AmanNegi commented on GitHub (Jul 29, 2023):

@hyj1204 It seems very viable to tone down the colors(opacity) for dark mode. Here's a PR I created with a Demo for same:

https://github.com/AppFlowy-IO/AppFlowy/pull/3079

@AmanNegi commented on GitHub (Jul 29, 2023): @hyj1204 It seems very viable to tone down the colors(opacity) for dark mode. Here's a PR I created with a Demo for same: https://github.com/AppFlowy-IO/AppFlowy/pull/3079

mirror referenced this issue

2026-03-23 21:38:51 +00:00

[PR #1347] [MERGED] fix: several grid ui improvements #4675

mirror referenced this issue

2026-03-23 22:15:28 +00:00

[PR #1395] [CLOSED] Feat/op compose #4709