AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 21:00:19 +00:00

[GH-ISSUE #3132] [Bug] Selection Menu has no background shadow or border in light modes #1369

New issue

Closed

opened 2026-03-23 20:48:23 +00:00 by mirror · 6 comments

mirror commented

2026-03-23 20:48:23 +00:00

Owner

Originally created by @MayurSMahajan on GitHub (Aug 7, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3132

Originally assigned to: @LucasXu0 on GitHub.

Bug Description

As title.

How to Reproduce

Open AppFlowy
Make sure you are in Light Mode (of any theme)
Type / to activate to the selection menu
Observe that the selection menu has no background as shown in the screenshot.

Expected Behavior

Open AppFlowy
Make sure you are in Light Mode (of any theme)
Type / to activate the selection menu
Selection menu has background color and shadow.

Operating System

Windows 11

AppFlowy Version(s)

v0.2.8

Screenshots

Default Theme:

Additional Context

Background color and shadow are missing in every theme's light mode.
Expected background is present in the Dark Mode of every theme.

Originally created by @MayurSMahajan on GitHub (Aug 7, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3132 Originally assigned to: @LucasXu0 on GitHub. ### Bug Description As title. ### How to Reproduce 1. Open AppFlowy 2. Make sure you are in Light Mode (of any theme) 3. Type / to activate to the selection menu 4. Observe that the selection menu has no background as shown in the screenshot. ### Expected Behavior 1. Open AppFlowy 2. Make sure you are in Light Mode (of any theme) 3. Type / to activate the selection menu 4. Selection menu has background color and shadow. ### Operating System Windows 11 ### AppFlowy Version(s) v0.2.8 ### Screenshots Default Theme: ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/e0bc3c11-f2be-49a7-8f05-ee216789fa34) ### Additional Context - Background color and shadow are missing in every theme's light mode. - Expected background is present in the Dark Mode of every theme.

mirror

2026-03-23 20:48:23 +00:00

closed this issue
added the
regression

bug
labels

mirror commented

2026-03-23 20:48:24 +00:00

Author

Owner

@dotares commented on GitHub (Aug 8, 2023):

Looks like it's been fixed @MayurSMahajan

@dotares commented on GitHub (Aug 8, 2023): Looks like it's been fixed @MayurSMahajan ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/115238980/12fb175b-6639-4c23-9b5c-734310cf29ac)

mirror commented

2026-03-23 20:48:25 +00:00

Author

Owner

@Xazin commented on GitHub (Aug 8, 2023):

Looks like it's been fixed @MayurSMahajan

I just noticed there's a different vertical padding from horizontal, my OCD cried out to me.

(You can tell by looking at the selected item, then looking up and left, there's a wider margin horizontally to the edge of the dialog).

Anyhow, I can reproduce on main on MacOS.

@Xazin commented on GitHub (Aug 8, 2023): > Looks like it's been fixed @MayurSMahajan ![image](https://user-images.githubusercontent.com/115238980/259013366-12fb175b-6639-4c23-9b5c-734310cf29ac.png) I just noticed there's a different vertical padding from horizontal, my OCD cried out to me. (You can tell by looking at the selected item, then looking up and left, there's a wider margin horizontally to the edge of the dialog). Anyhow, I can reproduce on `main` on MacOS. ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/42929161/351d3a6c-3839-44b7-ad6d-d3413a8b4f92)

mirror commented

2026-03-23 20:48:25 +00:00

Author

Owner

@dotares commented on GitHub (Aug 8, 2023):

Looks like it's been fixed @MayurSMahajan

I just noticed there's a different vertical padding from horizontal, my OCD cried out to me.

(You can tell by looking at the selected item, then looking up and left, there's a wider margin horizontally to the edge of the dialog).

Anyhow, I can reproduce on main on MacOS.

Looks like when the window size is small enough, the shadow and the background disappears, on Windows 11.

But when the window is fully allowing all of the items to exist on screen, the shadow and the background reappears.

Also tested on Ubuntu 20.04, same issue.

@dotares commented on GitHub (Aug 8, 2023): > > Looks like it's been fixed @MayurSMahajan ![image](https://user-images.githubusercontent.com/115238980/259013366-12fb175b-6639-4c23-9b5c-734310cf29ac.png) > > I just noticed there's a different vertical padding from horizontal, my OCD cried out to me. > > (You can tell by looking at the selected item, then looking up and left, there's a wider margin horizontally to the edge of the dialog). > > Anyhow, I can reproduce on `main` on MacOS. > > ![image](https://user-images.githubusercontent.com/42929161/259058567-351d3a6c-3839-44b7-ad6d-d3413a8b4f92.png) Looks like when the window size is small enough, the shadow and the background disappears, on Windows 11. ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/115238980/f9917a31-3718-4b31-8e1d-de452df25142) But when the window is fully allowing all of the items to exist on screen, the shadow and the background reappears. ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/115238980/f654aa4a-0730-4421-ab9f-9a0f64f011b1) Also tested on Ubuntu 20.04, same issue.

mirror commented

2026-03-23 20:48:25 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Aug 8, 2023):

I can confirm this, on minimized displays the shadow disappears but on the full screen we can see the shadow.
I checked the code and the background color is just white in light modes.

@MayurSMahajan commented on GitHub (Aug 8, 2023): I can confirm this, on minimized displays the shadow disappears but on the full screen we can see the shadow. I checked the code and the background color is just white in light modes.

mirror commented

2026-03-23 20:48:25 +00:00

Author

Owner

@dotares commented on GitHub (Aug 8, 2023):

Working on this 👍

@dotares commented on GitHub (Aug 8, 2023): Working on this 👍

mirror commented

2026-03-23 20:48:26 +00:00

Author

Owner

@dotares commented on GitHub (Aug 10, 2023):