[PR #2550] chore: clean up code #13704

Closed
opened 2026-03-24 21:47:19 +00:00 by mirror · 0 comments
Owner

Original Pull Request: https://github.com/AppFlowy-IO/AppFlowy/pull/2550

State: closed
Merged: Yes


  • Split off a portion of repeated logic into a separate function in apply_changeset.
  • Improve readability in some parts
  • early escape from timezone parsing if the timezone_id string is empty

Feature Preview


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.
**Original Pull Request:** https://github.com/AppFlowy-IO/AppFlowy/pull/2550 **State:** closed **Merged:** Yes --- - Split off a portion of repeated logic into a separate function in `apply_changeset`. - Improve readability in some parts - early escape from timezone parsing if the timezone_id string is empty ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing.
mirror 2026-03-24 21:47:19 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#13704
No description provided.