[PR #2915] fix: trigger option selection on tap down #13884

Closed
opened 2026-03-24 21:47:54 +00:00 by mirror · 0 comments
Owner

Original Pull Request: https://github.com/AppFlowy-IO/AppFlowy/pull/2915

State: closed
Merged: Yes


Closes #2832

This appears to be related to an issue in Flutter wherein onTapUp is not triggered correctly leading to onTap not firing. As a possible fix, I have moved this to use onTapDown.

Feature Preview


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • This PR only contains semantic changes.
  • All existing tests are passing.

https://github.com/AppFlowy-IO/AppFlowy/assets/25723331/c052ea36-ae4b-406e-9da6-76139f9ea458

**Original Pull Request:** https://github.com/AppFlowy-IO/AppFlowy/pull/2915 **State:** closed **Merged:** Yes --- Closes #2832 This appears to be related to an [issue in Flutter](https://github.com/flutter/flutter/issues/53797) wherein onTapUp is not triggered correctly leading to onTap not firing. As a possible fix, I have moved this to use onTapDown. <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to the [AppFlowy Style Guide](https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/submitting-code/style-guides) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] This PR only contains semantic changes. - [x] All existing tests are passing. https://github.com/AppFlowy-IO/AppFlowy/assets/25723331/c052ea36-ae4b-406e-9da6-76139f9ea458
mirror 2026-03-24 21:47:54 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#13884
No description provided.