AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #3313] [FR] Apply consistent style to quick command menu results #1463

New issue

Closed

opened 2026-03-23 20:49:32 +00:00 by mirror · 6 comments

mirror commented

2026-03-23 20:49:32 +00:00

Owner

Originally created by @intonarumori on GitHub (Sep 1, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3313

Originally assigned to: @khurramrizvi on GitHub.

Description

Look of the quick command menu is different when the result set is empty.
Note the sharp corners.

Impact

Consistency improves perceived app quality.

Additional Context

No response

Originally created by @intonarumori on GitHub (Sep 1, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3313 Originally assigned to: @khurramrizvi on GitHub. ### Description Look of the quick command menu is different when the result set is empty. Note the sharp corners. <img width="404" alt="Screenshot 2023-09-01 at 14 16 30" src="https://github.com/AppFlowy-IO/AppFlowy/assets/86030/5b01df83-9ae2-49ab-afcc-d745a6c87008"> <img width="212" alt="Screenshot 2023-09-01 at 14 16 35" src="https://github.com/AppFlowy-IO/AppFlowy/assets/86030/63eb2940-1f33-4f59-8390-45769c1b6a74"> ### Impact Consistency improves perceived app quality. ### Additional Context _No response_

mirror

2026-03-23 20:49:32 +00:00

closed this issue
added the
good first issue for devs

hacktoberfest

bug

good first issue for experienced devs
labels

mirror commented

2026-03-23 20:49:33 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Sep 2, 2023):

Nice catch! So essentially the issue can be solved if

the border radius on both the menus is same.

Or is there something more you want to add @intonarumori

@MayurSMahajan commented on GitHub (Sep 2, 2023): Nice catch! So essentially the issue can be solved if - the border radius on both the menus is same. Or is there something more you want to add @intonarumori

mirror commented

2026-03-23 20:49:33 +00:00

Author

Owner

@intonarumori commented on GitHub (Sep 3, 2023):

@MayurSMahajan I experimented a bit more, I think it would be nice to match the width of the result display when it has only one column, it's a minor thing, but would probably look better when typing, deleting etc. less jumping around.

One column result list:
Screenshot 2023-09-03 at 12 19 59

No results right now:
Screenshot 2023-09-03 at 12 20 04

@intonarumori commented on GitHub (Sep 3, 2023): @MayurSMahajan I experimented a bit more, I think it would be nice to match the width of the result display when it has only one column, it's a minor thing, but would probably look better when typing, deleting etc. less jumping around. One column result list: <img width="217" alt="Screenshot 2023-09-03 at 12 19 59" src="https://github.com/AppFlowy-IO/AppFlowy/assets/86030/a78034a2-8a2f-4b8f-a7fa-ce04650eaa23"> No results right now: <img width="212" alt="Screenshot 2023-09-03 at 12 20 04" src="https://github.com/AppFlowy-IO/AppFlowy/assets/86030/fdcc2d61-a6bb-4128-aeb6-4091bd49320a">

mirror commented

2026-03-23 20:49:33 +00:00

Author

Owner

@khurramrizvi commented on GitHub (Oct 5, 2023):

Please assign this to me, I would like to contribute.

@khurramrizvi commented on GitHub (Oct 5, 2023): Please assign this to me, I would like to contribute.

mirror commented

2026-03-23 20:49:34 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Oct 5, 2023):

@khurramrizvi assigned! have fun.

@MayurSMahajan commented on GitHub (Oct 5, 2023): @khurramrizvi assigned! have fun.

mirror commented

2026-03-23 20:49:34 +00:00

Author

Owner

@khurramrizvi commented on GitHub (Oct 6, 2023):

@MayurSMahajan Hey, it seems the issue was not assigned to me, could you please assign this to me.

@khurramrizvi commented on GitHub (Oct 6, 2023): @MayurSMahajan Hey, it seems the issue was not assigned to me, could you please assign this to me.

mirror commented

2026-03-23 20:49:35 +00:00

Author

Owner

@Kritarthsharma commented on GitHub (Oct 30, 2023):

Hi @MayurSMahajan, I've added one fix to appFlowy_editor repo for this issue and raised a PR. Can you please review it and assign this to me. Thanks!

https://github.com/AppFlowy-IO/appflowy-editor/pull/567

@Kritarthsharma commented on GitHub (Oct 30, 2023): Hi @MayurSMahajan, I've added one fix to appFlowy_editor repo for this issue and raised a PR. Can you please review it and assign this to me. Thanks! [https://github.com/AppFlowy-IO/appflowy-editor/pull/567](url)

mirror referenced this issue

2026-03-23 22:15:41 +00:00

[PR #1463] [MERGED] chore: use theme.of(context) text theme in FlowyText #4756