AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #3411] [Bug] The placeholder text for URL cells shouldn't be underlined #1516

New issue

Closed

opened 2026-03-23 20:50:22 +00:00 by mirror · 6 comments

mirror commented

2026-03-23 20:50:22 +00:00

Owner

Originally created by @richardshiue on GitHub (Sep 15, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3411

Originally assigned to: @ahsanahmad4654 on GitHub.

Bug Description

Please make a check for whether the URL cell data is empty before setting the underline flag to be true.

How to Reproduce

Open a grid
Create a URL field
Open the first row as grid
Observe that the placeholder "Empty" text is underlined

Expected Behavior

It shouldn't be

Operating System

macOS

AppFlowy Version(s)

0.3.1

Screenshots

No response

Additional Context

No response

Originally created by @richardshiue on GitHub (Sep 15, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3411 Originally assigned to: @ahsanahmad4654 on GitHub. ### Bug Description Please make a check for whether the URL cell data is empty before setting the underline flag to be true. ![Screenshot 2023-09-15 at 3 44 50 PM](https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/153e499e-2dce-449c-bf8d-4ef5721daadb) ### How to Reproduce 1. Open a grid 2. Create a URL field 3. Open the first row as grid 4. Observe that the placeholder "Empty" text is underlined ### Expected Behavior It shouldn't be ### Operating System macOS ### AppFlowy Version(s) 0.3.1 ### Screenshots _No response_ ### Additional Context _No response_

mirror

2026-03-23 20:50:22 +00:00

closed this issue
added the
good first issue for devs

hacktoberfest

grid

bug
labels

mirror commented

2026-03-23 20:50:23 +00:00

Author

Owner

@Abhineya commented on GitHub (Sep 19, 2023):

assign this issue to me

@Abhineya commented on GitHub (Sep 19, 2023): assign this issue to me

mirror commented

2026-03-23 20:50:23 +00:00

Author

Owner

@ahsanahmad4654 commented on GitHub (Sep 22, 2023):

Hey, @richardshiue are you able to assign this one to me to work on?

@ahsanahmad4654 commented on GitHub (Sep 22, 2023): Hey, @richardshiue are you able to assign this one to me to work on?

mirror commented

2026-03-23 20:50:23 +00:00

Author

Owner

@richardshiue commented on GitHub (Sep 30, 2023):

Hey there @ahsanahmad4654, would you like to work on this?

@richardshiue commented on GitHub (Sep 30, 2023): Hey there @ahsanahmad4654, would you like to work on this?

mirror commented

2026-03-23 20:50:23 +00:00

Author

Owner

@ahsanahmad4654 commented on GitHub (Oct 1, 2023):

yes, @richardshiue , i would love to work on it

@ahsanahmad4654 commented on GitHub (Oct 1, 2023): yes, @richardshiue , i would love to work on it

mirror commented

2026-03-23 20:50:24 +00:00

Author

Owner

@ahsanahmad4654 commented on GitHub (Oct 1, 2023):

@richardshiue Please review the PR.

@ahsanahmad4654 commented on GitHub (Oct 1, 2023): @richardshiue Please review the PR.

mirror commented

2026-03-23 20:50:24 +00:00

Author

Owner

@ahsanahmad4654 commented on GitHub (Oct 2, 2023):

I had fixed this issue and raised the PR. Please review it @richardshiue

@ahsanahmad4654 commented on GitHub (Oct 2, 2023): I had fixed this issue and raised the PR. Please review it @richardshiue

mirror referenced this issue

2026-03-23 22:15:51 +00:00

[PR #1516] [MERGED] refactor: rename structs of event dispatch lib #4790