[GH-ISSUE #3462] [Bug] restore page UI is still kinda strange #1555

Closed
opened 2026-03-23 20:50:52 +00:00 by mirror · 4 comments
Owner

Originally created by @richardshiue on GitHub (Sep 20, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3462

Originally assigned to: @RawatDevanshu on GitHub.

Bug Description

Title says all

How to Reproduce

Hold your mouse on one of the restore or delete permanently buttons after deleting the current page

Expected Behavior

a more acceptable color

Operating System

macOS

AppFlowy Version(s)

0.3.2

Screenshots

Screenshot 2023-09-20 at 12 07 02 PM

Additional Context

No response

Originally created by @richardshiue on GitHub (Sep 20, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3462 Originally assigned to: @RawatDevanshu on GitHub. ### Bug Description Title says all ### How to Reproduce Hold your mouse on one of the restore or delete permanently buttons after deleting the current page ### Expected Behavior a more acceptable color ### Operating System macOS ### AppFlowy Version(s) 0.3.2 ### Screenshots <img width="1060" alt="Screenshot 2023-09-20 at 12 07 02 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/764f484f-a61b-4b1e-b831-87e3b56d084f"> ### Additional Context _No response_
mirror 2026-03-23 20:50:52 +00:00
Author
Owner

@RawatDevanshu commented on GitHub (Sep 27, 2023):

Hello, can I work on this?

<!-- gh-comment-id:1737262556 --> @RawatDevanshu commented on GitHub (Sep 27, 2023): Hello, can I work on this?
Author
Owner

@richardshiue commented on GitHub (Sep 27, 2023):

Yes I have assigned it to you, have fun! I see that you also want to work on a few other issues. Let's go one at a time,

<!-- gh-comment-id:1737266433 --> @richardshiue commented on GitHub (Sep 27, 2023): Yes I have assigned it to you, have fun! I see that you also want to work on a few other issues. Let's go one at a time,
Author
Owner

@RawatDevanshu commented on GitHub (Sep 30, 2023):

Hello, I have changed colors, I used colorScheme.surfaceVariant in place of .error in the banner background, and buttons used .tertiary and for outline .tertairyContainer. For highlights I used .onErrorContainer in place of .error respectively this is how it looks.

https://pasteboard.co/BDMKBho5JbZI.gif --Dark
https://pasteboard.co/lkN9lQ0Zk8iH.gif --Light

do these look just fine?
it looks ugly like above when I switch to lavender or dandelion. But it could be dealt

<!-- gh-comment-id:1741834648 --> @RawatDevanshu commented on GitHub (Sep 30, 2023): Hello, I have changed colors, I used colorScheme.surfaceVariant in place of .error in the banner background, and buttons used .tertiary and for outline .tertairyContainer. For highlights I used .onErrorContainer in place of .error respectively this is how it looks. https://pasteboard.co/BDMKBho5JbZI.gif --Dark https://pasteboard.co/lkN9lQ0Zk8iH.gif --Light do these look just fine? it looks ugly like above when I switch to lavender or dandelion. But it could be dealt
Author
Owner

@richardshiue commented on GitHub (Oct 2, 2023):

Yeah looks good to me! Could you submit a PR and we can have a look?

<!-- gh-comment-id:1742361000 --> @richardshiue commented on GitHub (Oct 2, 2023): Yeah looks good to me! Could you submit a PR and we can have a look?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1555
No description provided.