[GH-ISSUE #3479] [FR] Edit the field by clicking on the drag icon #1568

Closed
opened 2026-03-23 20:51:06 +00:00 by mirror · 12 comments
Owner

Originally created by @richardshiue on GitHub (Sep 20, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3479

Originally assigned to: @ekakshjanweja on GitHub.

Description

When you click on the draggable thumb, a popup of the field editor should appear. The field editor should be the exact same one that you'd get if you were to click on the field button just to the right. Please add the necessary hover effects as well.

Screenshot 2023-09-20 at 10 34 06 PM

Impact

Row detail page users

Additional Context

No response

Originally created by @richardshiue on GitHub (Sep 20, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3479 Originally assigned to: @ekakshjanweja on GitHub. ### Description When you click on the draggable thumb, a popup of the field editor should appear. The field editor should be the exact same one that you'd get if you were to click on the field button just to the right. Please add the necessary hover effects as well. <img width="431" alt="Screenshot 2023-09-20 at 10 34 06 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/81b86151-b7ec-4f92-bfa0-187922268371"> ### Impact Row detail page users ### Additional Context _No response_
Author
Owner

@Nitin-Poojary commented on GitHub (Sep 22, 2023):

The field editor should be the exact same one that you'd get if you were to click on the field button just to the right.

Can you please elaborate on this?

<!-- gh-comment-id:1731283401 --> @Nitin-Poojary commented on GitHub (Sep 22, 2023): > The field editor should be the exact same one that you'd get if you were to click on the field button just to the right. Can you please elaborate on this?
Author
Owner

@ekakshjanweja commented on GitHub (Sep 25, 2023):

Hi, I was wondering if I could work on this issue.

<!-- gh-comment-id:1732897005 --> @ekakshjanweja commented on GitHub (Sep 25, 2023): Hi, I was wondering if I could work on this issue.
Author
Owner

@richardshiue commented on GitHub (Sep 25, 2023):

@Nitin-Poojary something like this, but different menu and this one is in the document.

Screenshot 2023-09-25 at 1 15 16 PM

@ekakshjanweja Sure! I have assigned it to you.

<!-- gh-comment-id:1732928235 --> @richardshiue commented on GitHub (Sep 25, 2023): @Nitin-Poojary something like this, but different menu and this one is in the document. <img width="510" alt="Screenshot 2023-09-25 at 1 15 16 PM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/71320345/b7f09ab3-ec82-4158-b37c-c2b6c6f6cf72"> @ekakshjanweja Sure! I have assigned it to you.
Author
Owner

@ekakshjanweja commented on GitHub (Sep 25, 2023):

@richardshiue So I was looking around the codebase do you have any hints for me on where I should look? This may be unusual to ask in open-source projects but here goes nothing. Thanks for the help though.

<!-- gh-comment-id:1734144859 --> @ekakshjanweja commented on GitHub (Sep 25, 2023): @richardshiue So I was looking around the codebase do you have any hints for me on where I should look? This may be unusual to ask in open-source projects but here goes nothing. Thanks for the help though.
Author
Owner

@richardshiue commented on GitHub (Sep 26, 2023):

@ekakshjanweja yep sure! You can look for something called a RowDetailPage

<!-- gh-comment-id:1734708189 --> @richardshiue commented on GitHub (Sep 26, 2023): @ekakshjanweja yep sure! You can look for something called a `RowDetailPage`
Author
Owner

@ekakshjanweja commented on GitHub (Sep 27, 2023):

I finally found something basically we need a popup menu thing here.
Now I will find where this menu has been implemented already and then see where things move forward from there.
Will ask for help if needed.

https://github.com/AppFlowy-IO/AppFlowy/assets/73514964/69461455-50fa-4f55-8eb0-c31e58b1bec9

<!-- gh-comment-id:1737413041 --> @ekakshjanweja commented on GitHub (Sep 27, 2023): I finally found something basically we need a popup menu thing here. Now I will find where this menu has been implemented already and then see where things move forward from there. Will ask for help if needed. https://github.com/AppFlowy-IO/AppFlowy/assets/73514964/69461455-50fa-4f55-8eb0-c31e58b1bec9
Author
Owner

@AdiAr11 commented on GitHub (Oct 2, 2023):

Hi @ekakshjanweja , are you still working on it?

<!-- gh-comment-id:1742709973 --> @AdiAr11 commented on GitHub (Oct 2, 2023): Hi @ekakshjanweja , are you still working on it?
Author
Owner

@ekakshjanweja commented on GitHub (Oct 2, 2023):

Hi @ekakshjanweja , are you still working on it?

Yes I am i have got mid semester exams this week but I I am still working on this 😊

<!-- gh-comment-id:1742716021 --> @ekakshjanweja commented on GitHub (Oct 2, 2023): > Hi @ekakshjanweja , are you still working on it? Yes I am i have got mid semester exams this week but I I am still working on this 😊
Author
Owner

@ekakshjanweja commented on GitHub (Oct 9, 2023):

@richardshiue I was able to make this does this look good?

https://github.com/AppFlowy-IO/AppFlowy/assets/73514964/faa1b9a3-915e-4bd2-97e5-746ad02d39d9

<!-- gh-comment-id:1752362472 --> @ekakshjanweja commented on GitHub (Oct 9, 2023): @richardshiue I was able to make this does this look good? https://github.com/AppFlowy-IO/AppFlowy/assets/73514964/faa1b9a3-915e-4bd2-97e5-746ad02d39d9
Author
Owner

@ekakshjanweja commented on GitHub (Oct 9, 2023):

@richardshiue I just created this PR. Just tell me if you want anything changed. Thanks for all the help and support till now.
https://github.com/AppFlowy-IO/AppFlowy/pull/3656

<!-- gh-comment-id:1753362069 --> @ekakshjanweja commented on GitHub (Oct 9, 2023): @richardshiue I just created this PR. Just tell me if you want anything changed. Thanks for all the help and support till now. https://github.com/AppFlowy-IO/AppFlowy/pull/3656
Author
Owner

@ekakshjanweja commented on GitHub (Oct 16, 2023):

@richardshiue should we close this issue?

<!-- gh-comment-id:1763728780 --> @ekakshjanweja commented on GitHub (Oct 16, 2023): @richardshiue should we close this issue?
Author
Owner

@richardshiue commented on GitHub (Oct 16, 2023):

Yes, thanks for the reminder

<!-- gh-comment-id:1763803821 --> @richardshiue commented on GitHub (Oct 16, 2023): Yes, thanks for the reminder
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1568
No description provided.