[GH-ISSUE #3524] [FR] Add a vertical scrollbar for page link menu and hide the current page #1594

Closed
opened 2026-03-23 20:51:30 +00:00 by mirror · 12 comments
Owner

Originally created by @MayurSMahajan on GitHub (Sep 25, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3524

Originally assigned to: @narayann7 on GitHub.

Description

When I entered @ for a link to a page, I was confused because the window only showed five pages. I then realized that I had to enter more letters. Then the desired page was also displayed 😃 . Would it be useful to have a vertical scrollbar in the window to show that there are more pages to choose from? And another hint: In the window also the page is shown where I insert the link. This page should not be available for selection. Keep up the good work 👍 !
by MacMeikel, Copied from Discord.

image

Tasks:

  • Add vertical scrollbar to page link menu
  • Remove the current page as an option from the menu

Impact

Less confusion while using Page Link Menu

Additional Context

No response

Originally created by @MayurSMahajan on GitHub (Sep 25, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3524 Originally assigned to: @narayann7 on GitHub. ### Description > When I entered @ for a link to a page, I was confused because the window only showed five pages. I then realized that I had to enter more letters. Then the desired page was also displayed 😃 . Would it be useful to have a vertical scrollbar in the window to show that there are more pages to choose from? And another hint: In the window also the page is shown where I insert the link. This page should not be available for selection. Keep up the good work 👍 ! by MacMeikel, Copied from Discord. ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/5642a31e-7107-463e-9358-c202af8e8deb) Tasks: - [ ] Add vertical scrollbar to page link menu - [ ] Remove the current page as an option from the menu ### Impact Less confusion while using Page Link Menu ### Additional Context _No response_
Author
Owner

@narayann7 commented on GitHub (Sep 26, 2023):

@MayurSMahajan hey, can you assign me?

<!-- gh-comment-id:1735325347 --> @narayann7 commented on GitHub (Sep 26, 2023): @MayurSMahajan hey, can you assign me?
Author
Owner

@MayurSMahajan commented on GitHub (Sep 26, 2023):

Sure, happy coding!

<!-- gh-comment-id:1735357555 --> @MayurSMahajan commented on GitHub (Sep 26, 2023): Sure, happy coding!
Author
Owner

@SharmaDhruv2511 commented on GitHub (Sep 28, 2023):

is this issue currently open or anyone working on it?? I want to contribute to it.

<!-- gh-comment-id:1739272089 --> @SharmaDhruv2511 commented on GitHub (Sep 28, 2023): is this issue currently open or anyone working on it?? I want to contribute to it.
Author
Owner

@narayann7 commented on GitHub (Sep 28, 2023):

@SharmaDhruv2511 it is assigned to me and i am currently working on it

<!-- gh-comment-id:1739277219 --> @narayann7 commented on GitHub (Sep 28, 2023): @SharmaDhruv2511 it is assigned to me and i am currently working on it
Author
Owner

@0xJaskeerat commented on GitHub (Oct 2, 2023):

@MayurSMahajan Hey buddy , can you please assign me this issue

<!-- gh-comment-id:1742855664 --> @0xJaskeerat commented on GitHub (Oct 2, 2023): @MayurSMahajan Hey buddy , can you please assign me this issue
Author
Owner

@MayurSMahajan commented on GitHub (Oct 2, 2023):

Hey @0xJaskeerat! Thanks for your interest but since this issue is already assigned to @narayann7. I recommend you to look for other open issues. Good Luck!

<!-- gh-comment-id:1742858375 --> @MayurSMahajan commented on GitHub (Oct 2, 2023): Hey @0xJaskeerat! Thanks for your interest but since this issue is already assigned to @narayann7. I recommend you to look for other open issues. Good Luck!
Author
Owner

@0xJaskeerat commented on GitHub (Oct 2, 2023):

Hey @0xJaskeerat! Thanks for your interest but since this issue is already assigned to @narayann7. I recommend you to look for other open issues. Good Luck!

Hey if @narayann7 is not able to do it , then can I take over right ?

<!-- gh-comment-id:1742877216 --> @0xJaskeerat commented on GitHub (Oct 2, 2023): > Hey @0xJaskeerat! Thanks for your interest but since this issue is already assigned to @narayann7. I recommend you to look for other open issues. Good Luck! Hey if @narayann7 is not able to do it , then can I take over right ?
Author
Owner

@narayann7 commented on GitHub (Oct 2, 2023):

@MayurSMahajan, @Xazin hey, i removed the current page option and if increase the item count, list expands horizontally, is it fine?
image

<!-- gh-comment-id:1742942391 --> @narayann7 commented on GitHub (Oct 2, 2023): @MayurSMahajan, @Xazin hey, i removed the current page option and if increase the item count, list expands horizontally, is it fine? <img width="858" alt="image" src="https://github.com/AppFlowy-IO/AppFlowy/assets/64174995/36169b29-6b15-4a7d-8801-cfe7a879a14c">
Author
Owner

@MayurSMahajan commented on GitHub (Oct 2, 2023):

can't we make it vertically scrollable?
What are your thoughts on this cc: @hyj1204 @Xazin

<!-- gh-comment-id:1743010687 --> @MayurSMahajan commented on GitHub (Oct 2, 2023): can't we make it vertically scrollable? What are your thoughts on this cc: @hyj1204 @Xazin
Author
Owner

@narayann7 commented on GitHub (Oct 2, 2023):

@MayurSMahajan actually the widget we using SelectionMenu used in multiple places

<!-- gh-comment-id:1743291355 --> @narayann7 commented on GitHub (Oct 2, 2023): @MayurSMahajan actually the widget we using `SelectionMenu` used in multiple places
Author
Owner

@Xazin commented on GitHub (Oct 2, 2023):

I believe this has completely changed in the main branch, can you check that you're on the latest version of main?

<!-- gh-comment-id:1743503404 --> @Xazin commented on GitHub (Oct 2, 2023): I believe this has completely changed in the `main` branch, can you check that you're on the latest version of `main`?
Author
Owner

@narayann7 commented on GitHub (Oct 3, 2023):

@Xazin, @MayurSMahajan yes it is changed, only thing i need to do is to remove the link for current page?

<!-- gh-comment-id:1745088276 --> @narayann7 commented on GitHub (Oct 3, 2023): @Xazin, @MayurSMahajan yes it is changed, only thing i need to do is to remove the link for current page?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1594
No description provided.