AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 21:00:19 +00:00

[GH-ISSUE #3696] [Bug] Images from URL return "invalid URL" if URL contains extra arguments. #1676

New issue

Closed

opened 2026-03-23 21:15:51 +00:00 by mirror · 6 comments

mirror commented

2026-03-23 21:15:51 +00:00

Owner

Originally created by @TDuffinNTU on GitHub (Oct 13, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3696

Bug Description

https://images.pexels.com/photos/732444/pexels-photo-732444.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=2

Take the above image URL from pexels. It'll open in a browser tab just fine, and is the result of copying the link to an image on the site. However, in Appflowy the image doesn't apply as the URL is "invalid". Removing the arguments makes the image work fine.

How to Reproduce

Copy an image from pexels, unsplash, etc. using "copy link to image" or "copy image url" in your browser.

Example: https://images.pexels.com/photos/732444/pexels-photo-732444.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=2

Attempt to set it as your document's cover photo with the image from URL feature:

Expected Behavior

Image is detected and loaded.

Operating System

Windows

AppFlowy Version(s)

0.3.5

Screenshots

As above.

Additional Context

Possibly failing because the Uri parser is expecting an image file extension such as .jpg? We had some issues with this on our own apps and found that making a get request to the URI and parsing the returned content-type in the response header was a good indicator of whether the link contained the document type we were expecting.

Originally created by @TDuffinNTU on GitHub (Oct 13, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/3696 ### Bug Description https://images.pexels.com/photos/732444/pexels-photo-732444.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=2 Take the above image URL from pexels. It'll open in a browser tab just fine, and is the result of copying the link to an image on the site. However, in Appflowy the image doesn't apply as the URL is "invalid". Removing the arguments makes the image work fine. ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/43959652/12241475-408e-4a0e-ad40-ae8b687bf361) ### How to Reproduce Copy an image from pexels, unsplash, etc. using "copy link to image" or "copy image url" in your browser. Example: https://images.pexels.com/photos/732444/pexels-photo-732444.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=2 Attempt to set it as your document's cover photo with the image from URL feature: ![image](https://github.com/AppFlowy-IO/AppFlowy/assets/43959652/98ce5985-90ae-4131-a0af-ff86017f0fcc) ### Expected Behavior Image is detected and loaded. ### Operating System Windows ### AppFlowy Version(s) 0.3.5 ### Screenshots As above. ### Additional Context Possibly failing because the Uri parser is expecting an image file extension such as .jpg? We had some issues with this on our own apps and found that making a get request to the URI and parsing the returned content-type in the response header was a good indicator of whether the link contained the document type we were expecting.

mirror closed this issue

2026-03-23 21:15:51 +00:00

mirror commented

2026-03-23 21:15:52 +00:00

Author

Owner

@DevaanshPathak commented on GitHub (Oct 20, 2023):

@MayurSMahajan I want to work on this please assign it to me.

@DevaanshPathak commented on GitHub (Oct 20, 2023): @MayurSMahajan I want to work on this please assign it to me.

mirror commented

2026-03-23 21:15:52 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Oct 20, 2023):

Assigned. Have fun !

@MayurSMahajan commented on GitHub (Oct 20, 2023): Assigned. Have fun !

mirror commented

2026-03-23 21:15:52 +00:00

Author

Owner

@DevaanshPathak commented on GitHub (Oct 28, 2023):

It is a kind of SQL injection to be exact I am working on the uri parser for it to just expect img extensions and ignore the extra attributes.

@DevaanshPathak commented on GitHub (Oct 28, 2023): It is a kind of SQL injection to be exact I am working on the uri parser for it to just expect img extensions and ignore the extra attributes.

mirror commented

2026-03-23 21:15:53 +00:00

Author

Owner

@annieappflowy commented on GitHub (Dec 21, 2023):

@DevaanshPathak , still working on this? need help?

@annieappflowy commented on GitHub (Dec 21, 2023): @DevaanshPathak , still working on this? need help?

mirror commented

2026-03-23 21:15:53 +00:00

Author

Owner

@DevaanshPathak commented on GitHub (Dec 24, 2023):

@annieappflowy I was working on it until yesterday but am unable to find a fix. Working on open source code is not as easy as it sounds.

@DevaanshPathak commented on GitHub (Dec 24, 2023): @annieappflowy I was working on it until yesterday but am unable to find a fix. Working on open source code is not as easy as it sounds.

mirror commented

2026-03-23 21:15:53 +00:00

Author

Owner

@Xazin commented on GitHub (Mar 2, 2024):

Since this issue was created, a lot has changed for the document cover, and I can't reproduce on MacOS anymore.

I'm going to close this for now, we can reopen or create a new issue if still needed.

@Xazin commented on GitHub (Mar 2, 2024): Since this issue was created, a lot has changed for the document cover, and I can't reproduce on MacOS anymore. I'm going to close this for now, we can reopen or create a new issue if still needed.

mirror referenced this issue

2026-03-23 22:16:16 +00:00

[PR #1676] [MERGED] feat: integrate OpenAI service #4888