mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 12:56:59 +00:00
[GH-ISSUE #394] [Bug] Problem when xdg-user-dirs in not installed #181
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#181
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MikeWallaceDev on GitHub (Feb 27, 2022).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/394
I'm rebuilding this issue from a PR that was not accepted. ( #156 )
Describe the bug
AppFlowy throws an Unhandled Exception error when xdg-user-dirs isn't installed.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
App just runs...
Screenshots
None
Desktop (please complete the following information):
Additional context
@appflowy I looked at the code and it is possible that the xdg_directories package (used by the path_provider package) throws an Exception if xdg-usr-dirs is not found. In fact, path_provider throws a different exception if a path isn't found. Neither of these exceptions are dealt with in AF.
I'm not sure how to proceed here.
I don't think that we should add a dependency to xdg-usr-dirs in the BUILD_ON_LINUX.md document because if xdg-usr-dirs isn't there it's probably because there is something weird going on (maybe the person is trying to install on a server version of Linux!). If xdg-usr-dirs isn't there, the user's Desktop Environment doesn't use it, I don't think we should install it.
I don't know what to do if we do trap that Exception, can we create a directory somewhere?? (It's a cross platform question, so difficult to answer)
I do think that our initialization process should catch errors so that the app quits gracefully. But I don't know where you want to place that code.
I do think that we should encapsulate path_provider so that we can easily switch it out if/WHEN something better comes along. But I don't know if you agree with that :)
@AkechiShiro commented on GitHub (Oct 23, 2022):
I've hit this issue on the latest release, I can confirm the fix is working.