AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 21:00:19 +00:00

[GH-ISSUE #4259] [Bug] Cannot exit import window by pressing escape #1899

New issue

Closed

opened 2026-03-23 21:18:04 +00:00 by mirror · 10 comments

mirror commented

2026-03-23 21:18:04 +00:00

Owner

Originally created by @PeterHero on GitHub (Dec 30, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4259

Originally assigned to: @Xazin on GitHub.

Bug Description

I like to close pop up windows by pressing escape. I would expect all windows to support this. I found that the import window does not support this. Not sure if it is a bug.

How to Reproduce

Hover over a page in the left bar
Click +
Click import
Windows opens up
Pressing escape does nothing

Expected Behavior

The window is expected to close after pressing escape.

Operating System

Linux (arch)

AppFlowy Version(s)

0.3.9

Screenshots

No response

Additional Context

No response

Originally created by @PeterHero on GitHub (Dec 30, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4259 Originally assigned to: @Xazin on GitHub. ### Bug Description I like to close pop up windows by pressing escape. I would expect all windows to support this. I found that the import window does not support this. Not sure if it is a bug. ### How to Reproduce 1. Hover over a page in the left bar 2. Click + 3. Click import 4. Windows opens up 5. Pressing escape does nothing ### Expected Behavior The window is expected to close after pressing escape. ### Operating System Linux (arch) ### AppFlowy Version(s) 0.3.9 ### Screenshots _No response_ ### Additional Context _No response_

mirror

2026-03-23 21:18:04 +00:00

closed this issue
added the
help wanted

good first issue for devs

bug
labels

mirror commented

2026-03-23 21:18:05 +00:00

Author

Owner

@Smit56R commented on GitHub (Jan 2, 2024):

Hey! I am a first-time contributor here. If this is a Flutter issue, can this be assigned to me?

@Smit56R commented on GitHub (Jan 2, 2024): Hey! I am a first-time contributor here. If this is a Flutter issue, can this be assigned to me?

mirror commented

2026-03-23 21:18:05 +00:00

Author

Owner

@annieappflowy commented on GitHub (Jan 2, 2024):

Assigned. Thanks, @Smit56R , for offering the help.

@annieappflowy commented on GitHub (Jan 2, 2024): Assigned. Thanks, @Smit56R , for offering the help.

mirror commented

2026-03-23 21:18:05 +00:00

Author

Owner

@ekakshjanweja commented on GitHub (Feb 9, 2024):

Hey @Smit56R,
Are you still working on this?

@ekakshjanweja commented on GitHub (Feb 9, 2024): Hey @Smit56R, Are you still working on this?

mirror commented

2026-03-23 21:18:05 +00:00

Author

Owner

@Smit56R commented on GitHub (Feb 10, 2024):

Hi @ekakshjanweja. My builds were failing so I have worked on the issue for a while. Sorry to not inform it sooner.

@Smit56R commented on GitHub (Feb 10, 2024): Hi @ekakshjanweja. My builds were failing so I have worked on the issue for a while. Sorry to not inform it sooner.

mirror commented

2026-03-23 21:18:05 +00:00

Author

Owner

@vishwa-0-karthik commented on GitHub (Apr 3, 2024):

Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR?

@vishwa-0-karthik commented on GitHub (Apr 3, 2024): Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR?

mirror commented

2026-03-23 21:18:06 +00:00

Author

Owner

@annieappflowy commented on GitHub (Apr 4, 2024):

Feel free to send a PR @vkuasar0

@annieappflowy commented on GitHub (Apr 4, 2024): Feel free to send a PR @vkuasar0

mirror commented

2026-03-23 21:18:06 +00:00

Author

Owner

@Xazin commented on GitHub (Apr 4, 2024):

Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR?

Hey Vkuasar, you can follow other examples in our application, we use a Listener (Most of the time a KeyboardListener), to pop the dialog when Escape is pressed (remember to only check for KeyDownEvent's).

@Xazin commented on GitHub (Apr 4, 2024): > Hey, is this issue still open? I just reproduced this issue, and I might know a way of solving it. Can I send a PR? Hey Vkuasar, you can follow other examples in our application, we use a Listener (Most of the time a KeyboardListener), to pop the dialog when Escape is pressed (remember to only check for KeyDownEvent's).

mirror commented

2026-03-23 21:18:06 +00:00

Author

Owner

@vishwa-0-karthik commented on GitHub (Apr 4, 2024):

Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description?
PS: I used KeyboardListener, and also checked for KeyDownEvent

@vishwa-0-karthik commented on GitHub (Apr 4, 2024): Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description? PS: I used KeyboardListener, and also checked for KeyDownEvent

mirror commented

2026-03-23 21:18:06 +00:00

Author

Owner

@Xazin commented on GitHub (Apr 4, 2024):

Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description? PS: I used KeyboardListener, and also checked for KeyDownEvent

It's not required to add a preview.

@Xazin commented on GitHub (Apr 4, 2024): > Hey, I'm a first time contributor, so I'm a little confused. Do I have to add a video in the pull request description? PS: I used KeyboardListener, and also checked for KeyDownEvent It's not required to add a preview.

mirror commented

2026-03-23 21:18:06 +00:00

Author

Owner

@vishwa-0-karthik commented on GitHub (Apr 4, 2024):

Yep, done sending PR

@vishwa-0-karthik commented on GitHub (Apr 4, 2024): Yep, done sending PR

mirror referenced this issue

2026-03-23 22:16:46 +00:00

[PR #1899] [MERGED] fix: tauri UI issues #5001

mirror referenced this issue

2026-03-24 21:46:23 +00:00