[GH-ISSUE #4276] [Bug] non translateable labels #1904

Closed
opened 2026-03-23 21:18:08 +00:00 by mirror · 7 comments
Owner

Originally created by @math-GH on GitHub (Jan 2, 2024).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4276

Bug Description

(Please add the "translations" label to this issue)

There are a bunch of English labels that are not coming from the .json files and/or cannot be translated into other lanuages

How to Reproduce

You can see the non translatable labels with the complete German translation file (see PR #4272)

The board feature
grafik

The settings menu of the board:
grafik

Calendar:
grafik

New block (nearly every type is affected) menu:
grafik

Grid:
grafik

Month of the calendar:
grafik

Expected Behavior

Translated labels into the target language

Operating System

Windows

AppFlowy Version(s)

0.3.9.1

Screenshots

No response

Additional Context

No response

Originally created by @math-GH on GitHub (Jan 2, 2024). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4276 ### Bug Description (Please add the "translations" label to this issue) There are a bunch of English labels that are not coming from the .json files and/or cannot be translated into other lanuages ### How to Reproduce You can see the non translatable labels with the complete German translation file (see PR #4272) The board feature ![grafik](https://github.com/AppFlowy-IO/AppFlowy/assets/1645099/1833f742-db80-44bb-b773-8575976f889e) The settings menu of the board: ![grafik](https://github.com/AppFlowy-IO/AppFlowy/assets/1645099/0881dee8-1b41-41fc-ae67-6e32f90402ef) Calendar: ![grafik](https://github.com/AppFlowy-IO/AppFlowy/assets/1645099/c4bd8443-bff8-45e1-b2ef-82d7ed0ca674) New block (nearly every type is affected) menu: ![grafik](https://github.com/AppFlowy-IO/AppFlowy/assets/1645099/e9f4e7f0-0033-41d6-bfff-e4a920c42e89) Grid: ![grafik](https://github.com/AppFlowy-IO/AppFlowy/assets/1645099/3f7b94b6-c973-4d30-9acf-1a0933be69ab) Month of the calendar: ![grafik](https://github.com/AppFlowy-IO/AppFlowy/assets/1645099/5e08eb2a-a221-4a10-b849-81d4f6eb7846) ### Expected Behavior Translated labels into the target language ### Operating System Windows ### AppFlowy Version(s) 0.3.9.1 ### Screenshots _No response_ ### Additional Context _No response_
Author
Owner

@math-GH commented on GitHub (Jan 2, 2024):

One more label that would be nice to have it translated: #2609

<!-- gh-comment-id:1874065197 --> @math-GH commented on GitHub (Jan 2, 2024): One more label that would be nice to have it translated: #2609
Author
Owner

@math-GH commented on GitHub (Jan 2, 2024):

The whole list of shortcut commands are not translateable:
grafik

<!-- gh-comment-id:1874092084 --> @math-GH commented on GitHub (Jan 2, 2024): The whole list of shortcut commands are not translateable: ![grafik](https://github.com/AppFlowy-IO/AppFlowy/assets/1645099/92c2c1e3-d5e2-4a56-83a7-c31090403ff2)
Author
Owner

@jpenna commented on GitHub (Jan 17, 2024):

Hi! I'd like to take this one

<!-- gh-comment-id:1896442872 --> @jpenna commented on GitHub (Jan 17, 2024): Hi! I'd like to take this one
Author
Owner

@jpenna commented on GitHub (Jan 17, 2024):

@LucasXu0 I see the translations for the editor's shortcuts are in appflowy_editor package using context with Localazy, but for the AppFlowy it uses inlang.

Should we just add the translation keys? Anything else should be considered for this task?

<!-- gh-comment-id:1896638266 --> @jpenna commented on GitHub (Jan 17, 2024): @LucasXu0 I see the translations for the editor's shortcuts are in [appflowy_editor package](https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/block_component/table_block_component/table_commands.dart#L17) using *context* with *Localazy*, but for the AppFlowy it uses *inlang*. Should we just add the translation keys? Anything else should be considered for this task?
Author
Owner

@jpenna commented on GitHub (Jan 19, 2024):

@LucasXu0 Could you give me more context on this PR https://github.com/AppFlowy-IO/appflowy-editor/pull/550, please? I see it added translations from the editor in the app, but wouldn't it be better as one single source of truth?

<!-- gh-comment-id:1900965339 --> @jpenna commented on GitHub (Jan 19, 2024): @LucasXu0 Could you give me more context on this PR https://github.com/AppFlowy-IO/appflowy-editor/pull/550, please? I see it added translations from the editor in the app, but wouldn't it be better as one single source of truth?
Author
Owner

@jpenna commented on GitHub (Jan 20, 2024):

Some shortcuts shouldn't be allowed to be overridden or at least should be put in an "Advanced" section. Maybe only show them to the user. For example: "Navigate around the cells at same offset in reverse" or "Move cursor to the right".

The commands _backSpaceInTableCell and _enterInTableCell should definitely be hidden, since it is overriding the default behavior. I will add a list of commands I think we should hide and commands that could be put in an Advanced section in the future (probably hide them today as well).

<!-- gh-comment-id:1902253297 --> @jpenna commented on GitHub (Jan 20, 2024): Some shortcuts shouldn't be allowed to be overridden or at least should be put in an "Advanced" section. Maybe only show them to the user. For example: "Navigate around the cells at same offset in reverse" or "Move cursor to the right". The commands `_backSpaceInTableCell` and `_enterInTableCell` should definitely be hidden, since it is overriding the default behavior. I will add a list of commands I think we should hide and commands that could be put in an Advanced section in the future (probably hide them today as well).
Author
Owner

@jpenna commented on GitHub (Jan 24, 2024):

Sent a PR for the editor: https://github.com/AppFlowy-IO/appflowy-editor/pull/680
Please review to validate the solution, so I can proceed with the app.

And another PR to translate commands descriptions: https://github.com/AppFlowy-IO/appflowy-editor/pull/687

<!-- gh-comment-id:1908123796 --> @jpenna commented on GitHub (Jan 24, 2024): Sent a PR for the editor: https://github.com/AppFlowy-IO/appflowy-editor/pull/680 Please review to validate the solution, so I can proceed with the app. And another PR to translate commands descriptions: https://github.com/AppFlowy-IO/appflowy-editor/pull/687
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1904
No description provided.