mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 21:00:19 +00:00
[GH-ISSUE #4276] [Bug] non translateable labels #1904
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#1904
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @math-GH on GitHub (Jan 2, 2024).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4276
Bug Description
(Please add the "translations" label to this issue)
There are a bunch of English labels that are not coming from the .json files and/or cannot be translated into other lanuages
How to Reproduce
You can see the non translatable labels with the complete German translation file (see PR #4272)
The board feature

The settings menu of the board:

Calendar:

New block (nearly every type is affected) menu:

Grid:

Month of the calendar:

Expected Behavior
Translated labels into the target language
Operating System
Windows
AppFlowy Version(s)
0.3.9.1
Screenshots
No response
Additional Context
No response
@math-GH commented on GitHub (Jan 2, 2024):
One more label that would be nice to have it translated: #2609
@math-GH commented on GitHub (Jan 2, 2024):
The whole list of shortcut commands are not translateable:

@jpenna commented on GitHub (Jan 17, 2024):
Hi! I'd like to take this one
@jpenna commented on GitHub (Jan 17, 2024):
@LucasXu0 I see the translations for the editor's shortcuts are in appflowy_editor package using context with Localazy, but for the AppFlowy it uses inlang.
Should we just add the translation keys? Anything else should be considered for this task?
@jpenna commented on GitHub (Jan 19, 2024):
@LucasXu0 Could you give me more context on this PR https://github.com/AppFlowy-IO/appflowy-editor/pull/550, please? I see it added translations from the editor in the app, but wouldn't it be better as one single source of truth?
@jpenna commented on GitHub (Jan 20, 2024):
Some shortcuts shouldn't be allowed to be overridden or at least should be put in an "Advanced" section. Maybe only show them to the user. For example: "Navigate around the cells at same offset in reverse" or "Move cursor to the right".
The commands
_backSpaceInTableCelland_enterInTableCellshould definitely be hidden, since it is overriding the default behavior. I will add a list of commands I think we should hide and commands that could be put in an Advanced section in the future (probably hide them today as well).@jpenna commented on GitHub (Jan 24, 2024):
Sent a PR for the editor: https://github.com/AppFlowy-IO/appflowy-editor/pull/680
Please review to validate the solution, so I can proceed with the app.
And another PR to translate commands descriptions: https://github.com/AppFlowy-IO/appflowy-editor/pull/687