[GH-ISSUE #4279] [Bug] Shift blocks backspace deletion #1906

Closed
opened 2026-03-23 21:18:10 +00:00 by mirror · 6 comments
Owner

Originally created by @PeterHero on GitHub (Jan 2, 2024).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4279

Originally assigned to: @Jayaprakash-dev on GitHub.

Bug Description

When shift is hold deleting by pressing backspace is not working.

How to Reproduce

  1. Go to some text
  2. Hold shift
  3. Press backspace

Expected Behavior

Pressing backspace should trigger deletion regardless of shift being pressed.

Operating System

Linux

AppFlowy Version(s)

0.4.0

Screenshots

No response

Additional Context

No response

Originally created by @PeterHero on GitHub (Jan 2, 2024). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4279 Originally assigned to: @Jayaprakash-dev on GitHub. ### Bug Description When shift is hold deleting by pressing backspace is not working. ### How to Reproduce 1. Go to some text 2. Hold shift 3. Press backspace ### Expected Behavior Pressing backspace should trigger deletion regardless of shift being pressed. ### Operating System Linux ### AppFlowy Version(s) 0.4.0 ### Screenshots _No response_ ### Additional Context _No response_
mirror 2026-03-23 21:18:10 +00:00
  • closed this issue
  • added the
    editor
    label
Author
Owner

@Jayaprakash-dev commented on GitHub (Jan 7, 2024):

Hey @PeterHero @LucasXu0, can I work on this?

It appears that the root issue resides in another file standard_block_components.dart within the AppFlowy-IO/appflowy-editor repository. The missing command handler for 'Shift+Backspace' in the list standardCommandShortcutEvents seems to be the problem, leading to its neglect by the Flutter app.

I would like to suggest a quick and effective solution: assigning the same Backspace handler in backspace_command.dart to another command shortcut event named 'deleteLeftCharacterCommand'. By doing this, we can ensure that the deletion functionality works seamlessly, resolving the reported bug.

<!-- gh-comment-id:1880033440 --> @Jayaprakash-dev commented on GitHub (Jan 7, 2024): Hey @PeterHero @LucasXu0, can I work on this? It appears that the root issue resides in another file [standard_block_components.dart](https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/block_component/standard_block_components.dart) within the `AppFlowy-IO/appflowy-editor` repository. The missing command handler for 'Shift+Backspace' in the list `standardCommandShortcutEvents` seems to be the problem, leading to its neglect by the Flutter app. I would like to suggest a quick and effective solution: assigning the same Backspace handler in [backspace_command.dart](https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/editor_component/service/shortcuts/command/backspace_command.dart) to another command shortcut event named 'deleteLeftCharacterCommand'. By doing this, we can ensure that the deletion functionality works seamlessly, resolving the reported bug.
Author
Owner

@LucasXu0 commented on GitHub (Jan 8, 2024):

@Jayaprakash-dev. Sure. Assigned it to you.

<!-- gh-comment-id:1880488009 --> @LucasXu0 commented on GitHub (Jan 8, 2024): @Jayaprakash-dev. Sure. Assigned it to you.
Author
Owner

@Jayaprakash-dev commented on GitHub (Jan 8, 2024):

@LucasXu0, The issue is associated with the file standard_block_components.dart in the repo AppFlowy-IO/appflowy-editor. How should I proceed to submit a pull request? Should I commit the pull request directly, highlighting this bug, or would you prefer me to create a new issue for this bug in the appflowy-editor repository?

<!-- gh-comment-id:1880640406 --> @Jayaprakash-dev commented on GitHub (Jan 8, 2024): **@LucasXu0**, The issue is associated with the file [standard_block_components.dart](https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/block_component/standard_block_components.dart) in the repo `AppFlowy-IO/appflowy-editor`. How should I proceed to submit a pull request? Should I commit the pull request directly, highlighting this bug, or would you prefer me to create a new issue for this bug in the `appflowy-editor` repository?
Author
Owner

@LucasXu0 commented on GitHub (Jan 9, 2024):

I viewed your PR in editor repo. You can use the same issue link.

<!-- gh-comment-id:1883090261 --> @LucasXu0 commented on GitHub (Jan 9, 2024): I viewed your PR in editor repo. You can use the same issue link.
Author
Owner

@annieappflowy commented on GitHub (Jan 23, 2024):

@Jayaprakash-dev , thank you for the contribution. Is the issue fixed in v0.4.3?

<!-- gh-comment-id:1905063885 --> @annieappflowy commented on GitHub (Jan 23, 2024): @Jayaprakash-dev , thank you for the contribution. Is the issue fixed in v0.4.3?
Author
Owner

@PeterHero commented on GitHub (Jan 23, 2024):

It works as expected on v0.4.3! Thank you for your contribution @Jayaprakash-dev

<!-- gh-comment-id:1905357735 --> @PeterHero commented on GitHub (Jan 23, 2024): It works as expected on v0.4.3! Thank you for your contribution @Jayaprakash-dev
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1906
No description provided.