[GH-ISSUE #4417] [Bug] Shortcuts shown in toolbar are not updated with custom keys #1976

Open
opened 2026-03-23 21:18:40 +00:00 by mirror · 1 comment
Owner

Originally created by @jpenna on GitHub (Jan 18, 2024).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4417

Bug Description

Shortcuts shown in the editor's toolbar are not updated with custom keys set in AppFlowy app.

How to Reproduce

  1. Open a document
  2. Change the shortcut of some editor command (ex: "Toggle Bold" from ctrl+b to ctrl+/)
  3. Select some text in the editor and hover over the button to see the shortcut is still the same (ex: hover over "B" and see ctrl+b instead of the new shortcut)

Expected Behavior

Should show the custom shortcut below the tooltip.

Operating System

Linux

AppFlowy Version(s)

Built from source

Screenshots

Screencast from 18-01-2024 15:16:00.webm

Additional Context

The shortcut combination is hard coded: https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/toolbar/desktop/items/format_toolbar_items.dart#L9C18-L9C18

It should be updated with the custom one.

Originally created by @jpenna on GitHub (Jan 18, 2024). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/4417 ### Bug Description Shortcuts shown in the editor's toolbar are not updated with custom keys set in AppFlowy app. ### How to Reproduce 1. Open a document 2. Change the shortcut of some editor command (ex: "Toggle Bold" from `ctrl+b` to `ctrl+/`) 3. Select some text in the editor and hover over the button to see the shortcut is still the same (ex: hover over "B" and see `ctrl+b` instead of the new shortcut) ### Expected Behavior Should show the custom shortcut below the tooltip. ### Operating System Linux ### AppFlowy Version(s) Built from source ### Screenshots [Screencast from 18-01-2024 15:16:00.webm](https://github.com/AppFlowy-IO/AppFlowy/assets/16005946/790b6287-5144-4480-b4e6-3a1763190192) ### Additional Context The shortcut combination is hard coded: https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/toolbar/desktop/items/format_toolbar_items.dart#L9C18-L9C18 It should be updated with the custom one.
Author
Owner

@jpenna commented on GitHub (Jan 18, 2024):

I'll send a fix for this one. Could you assign this to me, please?

<!-- gh-comment-id:1899072778 --> @jpenna commented on GitHub (Jan 18, 2024): I'll send a fix for this one. Could you assign this to me, please?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#1976
No description provided.