[GH-ISSUE #5392] [Bug] wrong string for workspace icon subtitle #2396

Closed
opened 2026-03-23 21:22:04 +00:00 by mirror · 4 comments
Owner

Originally created by @suntorytimed on GitHub (May 22, 2024).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/5392

Bug Description

The subtitle for the workspace icon in the settings uses the wrong string for the subtitle text

How to Reproduce

Use v0.5.8 and go into the new settings menu for the workspace design.

Expected Behavior

using the correct strings for the new settings menu, instead of the old translation strings.

Operating System

Linux

AppFlowy Version(s)

0.5.8

Screenshots

Screenshot from 2024-05-22 08-12-13

It uses settings.workspacePage.workspaceIcon.description:
Screenshot from 2024-05-22 08-54-38

instead of newSettings.workplace.workplaceIconSubtitle:
Screenshot from 2024-05-22 08-54-22

Additional Context

No response

Originally created by @suntorytimed on GitHub (May 22, 2024). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/5392 ### Bug Description The subtitle for the workspace icon in the settings uses the wrong string for the subtitle text ### How to Reproduce Use v0.5.8 and go into the new settings menu for the workspace design. ### Expected Behavior using the correct strings for the new settings menu, instead of the old translation strings. ### Operating System Linux ### AppFlowy Version(s) 0.5.8 ### Screenshots ![Screenshot from 2024-05-22 08-12-13](https://github.com/AppFlowy-IO/AppFlowy/assets/2744377/73d63d3e-6d6c-428a-a91f-ad6baf82bf43) It uses `settings.workspacePage.workspaceIcon.description`: ![Screenshot from 2024-05-22 08-54-38](https://github.com/AppFlowy-IO/AppFlowy/assets/2744377/868656b9-376f-4add-a66f-80c0ac670559) instead of `newSettings.workplace.workplaceIconSubtitle`: ![Screenshot from 2024-05-22 08-54-22](https://github.com/AppFlowy-IO/AppFlowy/assets/2744377/86c7b629-aaad-4047-85d8-355e8bbe782f) ### Additional Context _No response_
Author
Owner

@Xazin commented on GitHub (May 22, 2024):

The translation occurred just before the change, therefore the translation is not up to date. 🙏

<!-- gh-comment-id:2124015864 --> @Xazin commented on GitHub (May 22, 2024): The translation occurred just before the change, therefore the translation is not up to date. :pray:
Author
Owner

@suntorytimed commented on GitHub (May 22, 2024):

@Xazin so do I have to update the translation for settings.workspacePage.workspaceIcon.description or will the switch to the new string happen with a future update?

<!-- gh-comment-id:2124145183 --> @suntorytimed commented on GitHub (May 22, 2024): @Xazin so do I have to update the translation for `settings.workspacePage.workspaceIcon.description` or will the switch to the new string happen with a future update?
Author
Owner

@Xazin commented on GitHub (May 22, 2024):

@Xazin so do I have to update the translation for settings.workspacePage.workspaceIcon.description or will the switch to the new string happen with a future update?

It's just the translation value to the key that is wrong for Deutsch, so just updating the Deutsch value will suffice.

<!-- gh-comment-id:2124272885 --> @Xazin commented on GitHub (May 22, 2024): > @Xazin so do I have to update the translation for `settings.workspacePage.workspaceIcon.description` or will the switch to the new string happen with a future update? It's just the translation value to the key that is wrong for Deutsch, so just updating the Deutsch value will suffice.
Author
Owner

@suntorytimed commented on GitHub (May 22, 2024):

Ah, in that case I will fix the english string as well. Thanks for clarifying.

<!-- gh-comment-id:2124521514 --> @suntorytimed commented on GitHub (May 22, 2024): Ah, in that case I will fix the english string as well. Thanks for clarifying.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#2396
No description provided.