[GH-ISSUE #5493 ] [FR] More colours or colour picker for select #2445

Author

Owner

@OctoShotG commented on GitHub (Jun 17, 2024):

Being able to pick any custom colour with something such as a RGB value would be be great for customising- most of the colours now feel quite dark and don't fit the best with some themes.

@OctoShotG commented on GitHub (Jun 17, 2024): Being able to pick any custom colour with something such as a RGB value would be be great for customising- most of the colours now feel quite dark and don't fit the best with some themes.

mirror commented

Author

Owner

@nebiyuelias1 commented on GitHub (Jun 21, 2024):

So is the custom color input the way to go? I will be happy to work on this issue @apomalyn.

@nebiyuelias1 commented on GitHub (Jun 21, 2024): So is the custom color input the way to go? I will be happy to work on this issue @apomalyn.

mirror commented

Author

Owner

@MayurSMahajan commented on GitHub (Jun 26, 2024):

Hey @nebiyuelias1, assigning this to you. Just make sure that the custom colour input is consistent with custom colour inputs we have used in other places within appflowy. Have fun contributing!

@MayurSMahajan commented on GitHub (Jun 26, 2024): Hey @nebiyuelias1, assigning this to you. Just make sure that the custom colour input is consistent with custom colour inputs we have used in other places within appflowy. Have fun contributing!

mirror commented

Author

Owner

@nebiyuelias1 commented on GitHub (Jun 26, 2024):

Hey @nebiyuelias1, assigning this to you. Just make sure that the custom colour input is consistent with custom colour inputs we have used in other places within appflowy. Have fun contributing!

Oh exciting! So I saw some color picker with a dialog in the settings page. Do you think I should use that one?

@nebiyuelias1 commented on GitHub (Jun 26, 2024): > Hey @nebiyuelias1, assigning this to you. Just make sure that the custom colour input is consistent with custom colour inputs we have used in other places within appflowy. Have fun contributing! Oh exciting! So I saw some color picker with a dialog in the settings page. Do you think I should use that one?

mirror commented

Author

Owner

@MayurSMahajan commented on GitHub (Jun 28, 2024):

Something more like this. This appears when you try changing highlight or text colour

@MayurSMahajan commented on GitHub (Jun 28, 2024): Something more like this. This appears when you try changing highlight or text colour <img width="754" alt="Screenshot 2024-06-28 at 11 13 02 AM" src="https://github.com/AppFlowy-IO/AppFlowy/assets/47064215/a2d610f8-61bc-4623-b5c1-0d42a64398d2">

mirror commented

Author

Owner

@nebiyuelias1 commented on GitHub (Jul 4, 2024):

@MayurSMahajan I was able to add the custom color picker to the UI, but I was wondering how I could modify the protocol buffer to allow custom input. Right now it seems it's set to use integer values with an enum. Do you have any suggestions?

@nebiyuelias1 commented on GitHub (Jul 4, 2024): @MayurSMahajan I was able to add the custom color picker to the UI, but I was wondering how I could modify the protocol buffer to allow custom input. Right now it seems it's set to use integer values with an enum. Do you have any suggestions?

mirror commented

Author

Owner

@MayurSMahajan commented on GitHub (Jul 5, 2024):

@nebiyuelias1 Actually I am not the best person for this question, I haven't really worked on the colour pickers. I would advice you look up the existing implementation in here:
https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/toolbar/desktop/items/color/color_picker.dart

See if that helps, otherwise we'll ask someone who knows this for help.

@MayurSMahajan commented on GitHub (Jul 5, 2024): @nebiyuelias1 Actually I am not the best person for this question, I haven't really worked on the colour pickers. I would advice you look up the existing implementation in here: https://github.com/AppFlowy-IO/appflowy-editor/blob/main/lib/src/editor/toolbar/desktop/items/color/color_picker.dart See if that helps, otherwise we'll ask someone who knows this for help.

mirror commented

Author

Owner

@nebiyuelias1 commented on GitHub (Jul 5, 2024):

@MayurSMahajan Thanks for the reply. I did check that widget but it looks like the way it works is different. Because for the value I'm trying to implement it's using a proto buff with a set of options. What I'm struggling with is how to map a custom hex value with a string to a way that is going to be used by the proto buff. A nudge in the right direction would be helpful.

@nebiyuelias1 commented on GitHub (Jul 5, 2024): @MayurSMahajan Thanks for the reply. I did check that widget but it looks like the way it works is different. Because for the value I'm trying to implement it's using a proto buff with a set of options. What I'm struggling with is how to map a custom hex value with a string to a way that is going to be used by the proto buff. A nudge in the right direction would be helpful.

mirror commented

Author

Owner

@MayurSMahajan commented on GitHub (Jul 9, 2024):

Again I am not really familiar with this part of codebase, nor with protobuffs. Sorry about that!

@MayurSMahajan commented on GitHub (Jul 9, 2024): Again I am not really familiar with this part of codebase, nor with protobuffs. Sorry about that!

mirror commented

Author

Owner

@nebiyuelias1 commented on GitHub (Jul 9, 2024):

Again I am not really familiar with this part of codebase, nor with protobuffs. Sorry about that!

Ok who should I ask?

@nebiyuelias1 commented on GitHub (Jul 9, 2024): > Again I am not really familiar with this part of codebase, nor with protobuffs. Sorry about that! Ok who should I ask?

mirror commented

Author

Owner

@MayurSMahajan commented on GitHub (Jul 9, 2024):

Discord would be the right place to start, also your problem seems to be more related to Protobuffs, why do you want to implement it with Protobuffs, what advantage does it have over just reusing the existing solution? Just curious.

@MayurSMahajan commented on GitHub (Jul 9, 2024): Discord would be the right place to start, also your problem seems to be more related to Protobuffs, why do you want to implement it with Protobuffs, what advantage does it have over just reusing the existing solution? Just curious.

mirror commented

Author

Owner

@nebiyuelias1 commented on GitHub (Jul 9, 2024):

Discord would be the right place to start, also your problem seems to be more related to Protobuffs, why do you want to implement it with Protobuffs, what advantage does it have over just reusing the existing solution? Just curious.

Honestly it's the way things work at the moment and implementing the feature request requires the modification I described.

@nebiyuelias1 commented on GitHub (Jul 9, 2024): > Discord would be the right place to start, also your problem seems to be more related to Protobuffs, why do you want to implement it with Protobuffs, what advantage does it have over just reusing the existing solution? Just curious. Honestly it's the way things work at the moment and implementing the feature request requires the modification I described.

mirror commented

Author

Owner

@gustamor commented on GitHub (Aug 3, 2024):

@nebiyuelias1 How's it going?

The custom color feature for the cursor and selection in the workspace settings adds an icon to the color text box. Clicking this icon opens the color picker, which returns the corresponding color code and places it in the text box. This action does not alter any other elements; it simply updates the text box value with the selected color code and submits it in the same way as if the user had manually entered the code. I think this might work the same way.

@gustamor commented on GitHub (Aug 3, 2024): @nebiyuelias1 How's it going? The custom color feature for the cursor and selection in the workspace settings adds an icon to the color text box. Clicking this icon opens the color picker, which returns the corresponding color code and places it in the text box. This action does not alter any other elements; it simply updates the text box value with the selected color code and submits it in the same way as if the user had manually entered the code. I think this might work the same way.

mirror commented

Author

Owner

@nebiyuelias1 commented on GitHub (Aug 3, 2024):

@nebiyuelias1 How's it going?

The custom color feature for the cursor and selection in the workspace settings adds an icon to the color text box. Clicking this icon opens the color picker, which returns the corresponding color code and places it in the text box. This action does not alter any other elements; it simply updates the text box value with the selected color code and submits it in the same way as if the user had manually entered the code. I think this might work the same way.

Hi the situation is different in this context. More info about the problem could be found here on discord: https://discord.com/channels/903549834160635914/905299371485188137/1260206983122915388.
I didn't understand how the proto buff modifications should work so I haven't made much progress on this one. Would love to get some help!

@nebiyuelias1 commented on GitHub (Aug 3, 2024): > @nebiyuelias1 How's it going? > > The custom color feature for the cursor and selection in the workspace settings adds an icon to the color text box. Clicking this icon opens the color picker, which returns the corresponding color code and places it in the text box. This action does not alter any other elements; it simply updates the text box value with the selected color code and submits it in the same way as if the user had manually entered the code. I think this might work the same way. Hi the situation is different in this context. More info about the problem could be found here on discord: https://discord.com/channels/903549834160635914/905299371485188137/1260206983122915388. I didn't understand how the proto buff modifications should work so I haven't made much progress on this one. Would love to get some help!

mirror commented