[GH-ISSUE #689] [FR] Icon color for light/dark mode #290

New issue

Closed

opened 2026-03-23 20:35:00 +00:00 by mirror · 4 comments

mirror commented

2026-03-23 20:35:00 +00:00

Owner

Originally created by @appflowy on GitHub (Jul 23, 2022).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/689

Originally assigned to: @IMPranshu, @appflowy on GitHub.

The icon seems weird on light mode, but it works on dart mode. The icon color should be pure dark in light mode and light gray in dark mode.

The color should not be const, it should read from the theme color.

Not only the ViewDisclosureAction but also AppDisclosureAction has the same problem.

Originally created by @appflowy on GitHub (Jul 23, 2022). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/689 Originally assigned to: @IMPranshu, @appflowy on GitHub. The icon seems weird on light mode, but it works on dart mode. The icon color should be pure dark in light mode and light gray in dark mode. <img width="556" alt="image" src="https://user-images.githubusercontent.com/86001920/180592552-624865b4-8a40-40b6-932e-d62a86ce255c.png"> The color should not be const, it should read from the theme color. ![image](https://user-images.githubusercontent.com/86001920/180592602-f29eac75-d25a-4cf2-ac25-242d23ff8bca.png) Not only the ViewDisclosureAction but also AppDisclosureAction has the same problem.

mirror

2026-03-23 20:35:00 +00:00

closed this issue
added the
good first issue for devs
label

mirror commented

2026-03-23 20:35:01 +00:00

Author

Owner

@MikeWallaceDev commented on GitHub (Jul 23, 2022):

Wouldn't it be better to have this in the theme instead? All icons need to be adjusted according to the current theme.

@MikeWallaceDev commented on GitHub (Jul 23, 2022): Wouldn't it be better to have this in the theme instead? All icons need to be adjusted according to the current theme.

mirror commented

2026-03-23 20:35:01 +00:00

Author

Owner

@IMPranshu commented on GitHub (Aug 22, 2022):

I want to take up this issue. Please assign it to me.

@IMPranshu commented on GitHub (Aug 22, 2022): I want to take up this issue. Please assign it to me.

mirror commented

2026-03-23 20:35:01 +00:00

Author

Owner

@appflowy commented on GitHub (Aug 22, 2022):

I want to take up this issue. Please assign it to me.

Alright! You could DM me if you have any questions.

@appflowy commented on GitHub (Aug 22, 2022): > I want to take up this issue. Please assign it to me. Alright! You could DM me if you have any questions.

mirror commented

2026-03-23 20:35:01 +00:00

Author

Owner

@richardshiue commented on GitHub (Oct 23, 2022):

@annieappflowy I believe this has been implemented, should be good to close

@richardshiue commented on GitHub (Oct 23, 2022): @annieappflowy I believe this has been implemented, should be good to close

mirror referenced this issue

2026-03-23 21:36:04 +00:00

[PR #293] [CLOSED] Changes language names to their respective languages #4048