AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #7586] [Bug] "turn into" using shortcuts behave differently #3363

New issue

Closed

opened 2026-03-23 21:29:34 +00:00 by mirror · 4 comments

mirror commented

2026-03-23 21:29:34 +00:00

Owner

Originally created by @WagnerGFX on GitHub (Mar 22, 2025).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/7586

Originally assigned to: @asjqkkkk on GitHub.

Bug Description

Using the shortcuts for "Toggle Heading" makes any child text blocks disappear.

I'm not sure if these shortcuts were expected to toggle between Heading and text or to transform into a Toggle Heading. So I'm assuming it should behave the same as using "turn into Heading"

How to Reproduce

Create a normal text block.
Create a second text block and use tab to make it into a child of the first one.
Convert the first text block into a heading.
Option A: Use the left handler and turn it into H1, H2 or H3
Option B: Use the right click menu to turn it into H1, H2 or H3
Option C: Use the shortcut for Toggle Heading 1, 2 or 3

Using the shortcut will hide the second text block, while the others will just lower its indentation.

Expected Behavior

Using the left handle menu, the right click menu and shortcuts should all behave the exactly same.

The shortcut option is the offender for hiding the block's child content.
I'm just not sure if the fix is for the child text to stay visible, or if the shortcut was supposed to turn into a Toggle Heading.

In any case, I also suggest changing the shortcut names to "Toggle into ..." or something similar to prevent confusion.

Operating System

Windows 10

AppFlowy Version(s)

0.8.7

Screenshots

No response

Additional Context

No response

Originally created by @WagnerGFX on GitHub (Mar 22, 2025). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/7586 Originally assigned to: @asjqkkkk on GitHub. ### Bug Description Using the shortcuts for "Toggle Heading" makes any child text blocks disappear. I'm not sure if these shortcuts were expected to toggle between Heading and text or to transform into a Toggle Heading. So I'm assuming it should behave the same as using "turn into Heading" ### How to Reproduce 1) Create a normal text block. 2) Create a second text block and use tab to make it into a child of the first one. 3) Convert the first text block into a heading. Option A: Use the left handler and turn it into H1, H2 or H3 Option B: Use the right click menu to turn it into H1, H2 or H3 Option C: Use the shortcut for Toggle Heading 1, 2 or 3 Using the shortcut will hide the second text block, while the others will just lower its indentation. ### Expected Behavior Using the left handle menu, the right click menu and shortcuts should all behave the exactly same. The shortcut option is the offender for hiding the block's child content. I'm just not sure if the fix is for the child text to stay visible, or if the shortcut was supposed to turn into a Toggle Heading. In any case, I also suggest changing the shortcut names to "Toggle into ..." or something similar to prevent confusion. ### Operating System Windows 10 ### AppFlowy Version(s) 0.8.7 ### Screenshots _No response_ ### Additional Context _No response_

mirror

2026-03-23 21:29:34 +00:00

closed this issue
added the
editor
label

mirror commented

2026-03-23 21:29:35 +00:00

Author

Owner

@WagnerGFX commented on GitHub (Mar 25, 2025):

The naming is secondary, the main issue I reported was about the shortcut making the child blocks disappear, while using "turn into" didn't.

That PR seems to only change the name. Was the behavior fixed in another PR?

@WagnerGFX commented on GitHub (Mar 25, 2025): The naming is secondary, the main issue I reported was about the shortcut making the child blocks disappear, while using "turn into" didn't. That PR seems to only change the name. Was the behavior fixed in another PR?

mirror commented

2026-03-23 21:29:35 +00:00

Author

Owner

@asjqkkkk commented on GitHub (Mar 26, 2025):

HI @WagnerGFX , do you mean this issue : https://github.com/AppFlowy-IO/AppFlowy/issues/7585 ?
it will be fixed by https://github.com/AppFlowy-IO/AppFlowy/pull/7598

@asjqkkkk commented on GitHub (Mar 26, 2025): HI @WagnerGFX , do you mean this issue : https://github.com/AppFlowy-IO/AppFlowy/issues/7585 ? it will be fixed by https://github.com/AppFlowy-IO/AppFlowy/pull/7598

mirror commented

2026-03-23 21:29:35 +00:00

Author

Owner

@WagnerGFX commented on GitHub (Mar 26, 2025):

HI @WagnerGFX , do you mean this issue : #7585 ? it will be fixed by #7598

Not exactly. I did open a few issues with the "theme" of data loss. But they each happen in different situations.

That one is about turning a code block into a Toggle Heading and reverting.
This one is about using the keyboard shortcuts.

The case for this specific issue is that using one of the "Toggle Heading" shortcuts makes any child blocks disappear.
But the "Toggle" in those shortcuts just means the block will be changed into that or back into normal text, so those are shortcuts to simple Headings.

And this issue only happens for the shortcut, since using the left handler or the context menu all behave normally.

But I have no idea how the code works internally 😅, so that fix could be what solves all those cases.
When the new version gets released, I'll test everything to see if there are any problems left.

Thank you for the feedback 👍

@WagnerGFX commented on GitHub (Mar 26, 2025): > HI [@WagnerGFX](https://github.com/WagnerGFX) , do you mean this issue : [#7585](https://github.com/AppFlowy-IO/AppFlowy/issues/7585) ? it will be fixed by [#7598](https://github.com/AppFlowy-IO/AppFlowy/pull/7598) Not exactly. I did open a few issues with the "theme" of data loss. But they each happen in different situations. - That one is about turning a code block into a Toggle Heading and reverting. - This one is about using the keyboard shortcuts. The case for this specific issue is that using one of the "Toggle Heading" shortcuts makes any child blocks disappear. But the "Toggle" in those shortcuts just means the block will be changed into that or back into normal text, so those are shortcuts to simple Headings. And this issue only happens for the shortcut, since using the left handler or the context menu all behave normally. But I have no idea how the code works internally 😅, so that fix could be what solves all those cases. When the new version gets released, I'll test everything to see if there are any problems left. Thank you for the feedback 👍

mirror commented

2026-03-23 21:29:35 +00:00

Author

Owner

@WagnerGFX commented on GitHub (Apr 3, 2025):

I tested on v0.8.8 and the issue still remains. Here is a video to see how it happens:

https://github.com/user-attachments/assets/0e2e60fe-c282-47fa-8ff1-a98516b051c2

Also, related to renaming the shortcuts, it's also still the same as before.
Although renaming shortcuts is not the point of this issue, I thought it would be best to inform about it:

@WagnerGFX commented on GitHub (Apr 3, 2025): I tested on v0.8.8 and the issue still remains. Here is a video to see how it happens: https://github.com/user-attachments/assets/0e2e60fe-c282-47fa-8ff1-a98516b051c2 Also, related to renaming the shortcuts, it's also still the same as before. Although renaming shortcuts is not the point of this issue, I thought it would be best to inform about it: ![Image](https://github.com/user-attachments/assets/1837015e-9bc1-43f4-801f-90538302f9fe)