[PR #279] [MERGED] Language switcher #4040

Closed
opened 2026-03-23 21:36:02 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/279
Author: @Hari-07
Created: 1/28/2022
Status: Merged
Merged: 1/29/2022
Merged by: @appflowy

Base: mainHead: language_switcher


📝 Commits (8)

  • 6ea43cd Created AppLanguage class
  • 578bf96 Added language options to Appearance Model
  • 95247bc Refactored Language file
  • 8e14f8b Added language to appearance model
  • 214946c Created UI for Langauge Switching
  • 835a64c Added language to be observed to application widget
  • d7b936a fixed language switching issue
  • 595cfed added missing translation

📊 Changes

16 files changed (+246 additions, -81 deletions)

View changed files

📝 frontend/app_flowy/assets/translations/en.json (+6 -3)
📝 frontend/app_flowy/assets/translations/fr-CA.json (+5 -2)
📝 frontend/app_flowy/assets/translations/it-IT.json (+5 -2)
📝 frontend/app_flowy/assets/translations/zh-CN.json (+19 -5)
📝 frontend/app_flowy/lib/startup/tasks/application_widget.dart (+21 -12)
📝 frontend/app_flowy/lib/workspace/application/appearance.dart (+15 -4)
📝 frontend/app_flowy/lib/workspace/presentation/settings/settings_dialog.dart (+38 -32)
📝 frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart (+0 -3)
📝 frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_language_view.dart (+40 -1)
📝 frontend/app_flowy/lib/workspace/presentation/stack_page/doc/doc_stack_page.dart (+17 -8)
📝 frontend/app_flowy/lib/workspace/presentation/stack_page/doc/widget/toolbar/color_picker.dart (+3 -3)
📝 frontend/app_flowy/lib/workspace/presentation/stack_page/doc/widget/toolbar/header_button.dart (+3 -2)
📝 frontend/app_flowy/lib/workspace/presentation/widgets/menu/widget/menu_trash.dart (+17 -3)
📝 frontend/app_flowy/lib/workspace/presentation/widgets/menu/widget/menu_user.dart (+3 -1)
📝 frontend/app_flowy/macos/Runner/Info.plist (+7 -0)
frontend/app_flowy/packages/flowy_infra/lib/language.dart (+47 -0)

📄 Description

NOT READY TO MERGE

I've set it up in a similar way to theme, however the app is not rebuilding when language is changed. raising PR to get help


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/279 **Author:** [@Hari-07](https://github.com/Hari-07) **Created:** 1/28/2022 **Status:** ✅ Merged **Merged:** 1/29/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `language_switcher` --- ### 📝 Commits (8) - [`6ea43cd`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ea43cd5e5f412e896cb9233fb2056e09c5ecdf8) Created AppLanguage class - [`578bf96`](https://github.com/AppFlowy-IO/AppFlowy/commit/578bf963f7678f5cced03d10c8266be36a6636a4) Added language options to Appearance Model - [`95247bc`](https://github.com/AppFlowy-IO/AppFlowy/commit/95247bc5fb032d0657ed7e806a83f9f8230528d6) Refactored Language file - [`8e14f8b`](https://github.com/AppFlowy-IO/AppFlowy/commit/8e14f8b9f1d69e24bb7e3ad7a8c5b2241b4fa808) Added language to appearance model - [`214946c`](https://github.com/AppFlowy-IO/AppFlowy/commit/214946cbbcc7b6fbc6d791c135e49fda2583b56c) Created UI for Langauge Switching - [`835a64c`](https://github.com/AppFlowy-IO/AppFlowy/commit/835a64ca75065840282c08666e547267021a099e) Added language to be observed to application widget - [`d7b936a`](https://github.com/AppFlowy-IO/AppFlowy/commit/d7b936a0170d4c9aa73c3fcd5933825819481943) fixed language switching issue - [`595cfed`](https://github.com/AppFlowy-IO/AppFlowy/commit/595cfed8923324391335ed03506fb19c5a9aef53) added missing translation ### 📊 Changes **16 files changed** (+246 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/assets/translations/en.json` (+6 -3) 📝 `frontend/app_flowy/assets/translations/fr-CA.json` (+5 -2) 📝 `frontend/app_flowy/assets/translations/it-IT.json` (+5 -2) 📝 `frontend/app_flowy/assets/translations/zh-CN.json` (+19 -5) 📝 `frontend/app_flowy/lib/startup/tasks/application_widget.dart` (+21 -12) 📝 `frontend/app_flowy/lib/workspace/application/appearance.dart` (+15 -4) 📝 `frontend/app_flowy/lib/workspace/presentation/settings/settings_dialog.dart` (+38 -32) 📝 `frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_appearance_view.dart` (+0 -3) 📝 `frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_language_view.dart` (+40 -1) 📝 `frontend/app_flowy/lib/workspace/presentation/stack_page/doc/doc_stack_page.dart` (+17 -8) 📝 `frontend/app_flowy/lib/workspace/presentation/stack_page/doc/widget/toolbar/color_picker.dart` (+3 -3) 📝 `frontend/app_flowy/lib/workspace/presentation/stack_page/doc/widget/toolbar/header_button.dart` (+3 -2) 📝 `frontend/app_flowy/lib/workspace/presentation/widgets/menu/widget/menu_trash.dart` (+17 -3) 📝 `frontend/app_flowy/lib/workspace/presentation/widgets/menu/widget/menu_user.dart` (+3 -1) 📝 `frontend/app_flowy/macos/Runner/Info.plist` (+7 -0) ➕ `frontend/app_flowy/packages/flowy_infra/lib/language.dart` (+47 -0) </details> ### 📄 Description **NOT READY TO MERGE** I've set it up in a similar way to theme, however the app is not rebuilding when language is changed. raising PR to get help --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 21:36:02 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#4040
No description provided.