[PR #306] [MERGED] Refactored Language settings to remove AppLanguage enum #4054

New issue

Closed

opened 2026-03-23 21:36:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:36:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/306
Author: @MikeWallaceDev
Created: 2/5/2022
Status: ✅ Merged
Merged: 2/5/2022
Merged by: @appflowy

Base: main ← Head: refactor_languange_remove_enum

📝 Commits (1)

5519dcd refactor: language settings to remove applanguage enum

📊 Changes

13 files changed (+465 additions, -186 deletions)

View changed files

📝 frontend/app_flowy/lib/startup/tasks/application_widget.dart (+4 -4)
📝 frontend/app_flowy/lib/workspace/application/appearance.dart (+11 -13)
📝 frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_language_view.dart (+8 -8)
📝 frontend/app_flowy/lib/workspace/presentation/stack_page/doc/doc_stack_page.dart (+2 -2)
📝 frontend/app_flowy/lib/workspace/presentation/widgets/menu/widget/menu_trash.dart (+2 -3)
📝 frontend/app_flowy/packages/flowy_infra/lib/language.dart (+19 -52)
📝 frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-user-data-model/user_setting.pb.dart (+71 -8)
📝 frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-user-data-model/user_setting.pbjson.dart (+13 -2)
📝 frontend/rust-lib/flowy-user/src/handlers/user_handler.rs (+1 -6)
📝 shared-lib/flowy-derive/src/derive_cache/derive_cache.rs (+42 -41)
📝 shared-lib/flowy-user-data-model/src/entities/user_setting.rs (+20 -3)
📝 shared-lib/flowy-user-data-model/src/protobuf/model/user_setting.rs (+267 -43)
📝 shared-lib/flowy-user-data-model/src/protobuf/proto/user_setting.proto (+5 -1)

📄 Description

The application now uses Locale directly.
Removed the AppLanguage enum as well as the
languageFromString()
localeFromLanguageName()
stringFromLanguage()

The list of languages in the language picker is now automatically generated from the list of languages in EasyLocalization.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/306 **Author:** [@MikeWallaceDev](https://github.com/MikeWallaceDev) **Created:** 2/5/2022 **Status:** ✅ Merged **Merged:** 2/5/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor_languange_remove_enum` --- ### 📝 Commits (1) - [`5519dcd`](https://github.com/AppFlowy-IO/AppFlowy/commit/5519dcd525c124900a90a03f7e789784e9960561) refactor: language settings to remove applanguage enum ### 📊 Changes **13 files changed** (+465 additions, -186 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/startup/tasks/application_widget.dart` (+4 -4) 📝 `frontend/app_flowy/lib/workspace/application/appearance.dart` (+11 -13) 📝 `frontend/app_flowy/lib/workspace/presentation/settings/widgets/settings_language_view.dart` (+8 -8) 📝 `frontend/app_flowy/lib/workspace/presentation/stack_page/doc/doc_stack_page.dart` (+2 -2) 📝 `frontend/app_flowy/lib/workspace/presentation/widgets/menu/widget/menu_trash.dart` (+2 -3) 📝 `frontend/app_flowy/packages/flowy_infra/lib/language.dart` (+19 -52) 📝 `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-user-data-model/user_setting.pb.dart` (+71 -8) 📝 `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-user-data-model/user_setting.pbjson.dart` (+13 -2) 📝 `frontend/rust-lib/flowy-user/src/handlers/user_handler.rs` (+1 -6) 📝 `shared-lib/flowy-derive/src/derive_cache/derive_cache.rs` (+42 -41) 📝 `shared-lib/flowy-user-data-model/src/entities/user_setting.rs` (+20 -3) 📝 `shared-lib/flowy-user-data-model/src/protobuf/model/user_setting.rs` (+267 -43) 📝 `shared-lib/flowy-user-data-model/src/protobuf/proto/user_setting.proto` (+5 -1) </details> ### 📄 Description The application now uses Locale directly. Removed the AppLanguage enum as well as the languageFromString() localeFromLanguageName() stringFromLanguage() The list of languages in the language picker is now automatically generated from the list of languages in EasyLocalization. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>