[PR #516] [MERGED] Fix: Grid UI bugs #4167

New issue

Closed

opened 2026-03-23 21:36:36 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:36:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/516
Author: @appflowy
Created: 5/30/2022
Status: ✅ Merged
Merged: 5/30/2022
Merged by: @appflowy

Base: main ← Head: fix/grid_ui

📝 Commits (4)

5da8144 chore: show url cell editor when tap on edit button
546b1d2 fix: #509 enable select on tag
8445446 fix: #508 auto format number
76da449 chore: reset content when number is not valid

📊 Changes

25 files changed (+885 additions, -728 deletions)

View changed files

📝 frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/data_loader.dart (+12 -6)
📝 frontend/app_flowy/lib/workspace/application/grid/cell/number_cell_bloc.dart (+21 -14)
📝 frontend/app_flowy/lib/workspace/application/grid/field/type_option/number_bloc.dart (+1 -0)
📝 frontend/app_flowy/lib/workspace/application/grid/field/type_option/number_format_bloc.dart (+1 -1)
📝 frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/number_cell.dart (+26 -28)
📝 frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/select_option_cell/extension.dart (+14 -13)
📝 frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/select_option_cell/select_option_editor.dart (+5 -1)
📝 frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/url_cell/url_cell.dart (+4 -1)
📝 frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/header/type_option/number.dart (+1 -1)
➕ frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pb.dart (+11 -0)
➕ frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pbenum.dart (+94 -0)
➕ frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pbjson.dart (+55 -0)
➕ frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pbserver.dart (+9 -0)
📝 frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/number_type_option.pb.dart (+5 -7)
📝 frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/number_type_option.pbenum.dart (+0 -87)
📝 frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/number_type_option.pbjson.dart (+0 -45)
📝 frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/protobuf.dart (+1 -0)
➕ frontend/rust-lib/flowy-grid/src/protobuf/model/format.rs (+207 -0)
📝 frontend/rust-lib/flowy-grid/src/protobuf/model/mod.rs (+3 -0)
📝 frontend/rust-lib/flowy-grid/src/protobuf/model/number_type_option.rs (+14 -180)

...and 5 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/516 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 5/30/2022 **Status:** ✅ Merged **Merged:** 5/30/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/grid_ui` --- ### 📝 Commits (4) - [`5da8144`](https://github.com/AppFlowy-IO/AppFlowy/commit/5da8144456ae60e3711f394f0497ec7a919e5cad) chore: show url cell editor when tap on edit button - [`546b1d2`](https://github.com/AppFlowy-IO/AppFlowy/commit/546b1d22f4370721883b81002f31ecdee2f735ff) fix: #509 enable select on tag - [`8445446`](https://github.com/AppFlowy-IO/AppFlowy/commit/84454469b425265c6563d016281c7073f3453496) fix: #508 auto format number - [`76da449`](https://github.com/AppFlowy-IO/AppFlowy/commit/76da44999c3a8220de05cb2ba64b66ca3dcfbded) chore: reset content when number is not valid ### 📊 Changes **25 files changed** (+885 additions, -728 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/data_loader.dart` (+12 -6) 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/number_cell_bloc.dart` (+21 -14) 📝 `frontend/app_flowy/lib/workspace/application/grid/field/type_option/number_bloc.dart` (+1 -0) 📝 `frontend/app_flowy/lib/workspace/application/grid/field/type_option/number_format_bloc.dart` (+1 -1) 📝 `frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/number_cell.dart` (+26 -28) 📝 `frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/select_option_cell/extension.dart` (+14 -13) 📝 `frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/select_option_cell/select_option_editor.dart` (+5 -1) 📝 `frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/cell/url_cell/url_cell.dart` (+4 -1) 📝 `frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/header/type_option/number.dart` (+1 -1) ➕ `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pb.dart` (+11 -0) ➕ `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pbenum.dart` (+94 -0) ➕ `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pbjson.dart` (+55 -0) ➕ `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/format.pbserver.dart` (+9 -0) 📝 `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/number_type_option.pb.dart` (+5 -7) 📝 `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/number_type_option.pbenum.dart` (+0 -87) 📝 `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/number_type_option.pbjson.dart` (+0 -45) 📝 `frontend/app_flowy/packages/flowy_sdk/lib/protobuf/flowy-grid/protobuf.dart` (+1 -0) ➕ `frontend/rust-lib/flowy-grid/src/protobuf/model/format.rs` (+207 -0) 📝 `frontend/rust-lib/flowy-grid/src/protobuf/model/mod.rs` (+3 -0) 📝 `frontend/rust-lib/flowy-grid/src/protobuf/model/number_type_option.rs` (+14 -180) _...and 5 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>