[PR #600] [MERGED] Feat/row filter test #4225

New issue

Closed

opened 2026-03-23 21:36:52 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:36:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/600
Author: @appflowy
Created: 7/10/2022
Status: ✅ Merged
Merged: 7/10/2022
Merged by: @appflowy

Base: main ← Head: feat/row_filter_test

📝 Commits (6)

6a01a44 refactor: rm filter login from eneities mod
4f30f8e refactor: separate filter operation from filter_entities mod
ec1113b chore: add date filter tests
24f2bf3 chore: add filter feature flag & enable filter tests
8fa7a20 chore: make grid setting from revision
5bfbda5 fix: decode cell revision into AnyCellData

📊 Changes

46 files changed (+985 additions, -503 deletions)

View changed files

📝 frontend/rust-lib/flowy-grid/Cargo.toml (+2 -1)
📝 frontend/rust-lib/flowy-grid/src/entities/filter_entities/checkbox_filter.rs (+0 -28)
📝 frontend/rust-lib/flowy-grid/src/entities/filter_entities/date_filter.rs (+91 -5)
📝 frontend/rust-lib/flowy-grid/src/entities/filter_entities/number_filter.rs (+1 -78)
📝 frontend/rust-lib/flowy-grid/src/entities/filter_entities/select_option_filter.rs (+1 -64)
📝 frontend/rust-lib/flowy-grid/src/entities/filter_entities/text_filter.rs (+0 -86)
📝 frontend/rust-lib/flowy-grid/src/entities/filter_entities/util.rs (+13 -6)
📝 frontend/rust-lib/flowy-grid/src/entities/group_entities.rs (+4 -3)
📝 frontend/rust-lib/flowy-grid/src/entities/setting_entities.rs (+29 -33)
📝 frontend/rust-lib/flowy-grid/src/entities/sort_entities.rs (+4 -3)
📝 frontend/rust-lib/flowy-grid/src/event_handler.rs (+8 -1)
📝 frontend/rust-lib/flowy-grid/src/services/cell/any_cell_data.rs (+4 -15)
📝 frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs (+4 -1)
📝 frontend/rust-lib/flowy-grid/src/services/field/select_option.rs (+2 -2)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option.rs (+2 -14)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option.rs (+30 -17)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/multi_select_type_option.rs (+3 -14)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option.rs (+3 -17)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/single_select_type_option.rs (+2 -14)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/text_type_option.rs (+3 -15)

...and 26 more files

📄 Description

add feature flag: filter to enable the unit test
fix AnyCellData decode errors
add more tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/600 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 7/10/2022 **Status:** ✅ Merged **Merged:** 7/10/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/row_filter_test` --- ### 📝 Commits (6) - [`6a01a44`](https://github.com/AppFlowy-IO/AppFlowy/commit/6a01a44cc26d0877a31a00931e8110877720b895) refactor: rm filter login from eneities mod - [`4f30f8e`](https://github.com/AppFlowy-IO/AppFlowy/commit/4f30f8e2cd52247e76fa55f574f186f1ef2c8467) refactor: separate filter operation from filter_entities mod - [`ec1113b`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec1113b13492da076c1a61665f531cc8b5ea53a9) chore: add date filter tests - [`24f2bf3`](https://github.com/AppFlowy-IO/AppFlowy/commit/24f2bf398e1eba1d3a05c687d99d2cd1e7f1fe16) chore: add filter feature flag & enable filter tests - [`8fa7a20`](https://github.com/AppFlowy-IO/AppFlowy/commit/8fa7a203263f5ba9c33befa7793412a55d1c6138) chore: make grid setting from revision - [`5bfbda5`](https://github.com/AppFlowy-IO/AppFlowy/commit/5bfbda5606e2139df03192a930978282a6509f78) fix: decode cell revision into AnyCellData ### 📊 Changes **46 files changed** (+985 additions, -503 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-grid/Cargo.toml` (+2 -1) 📝 `frontend/rust-lib/flowy-grid/src/entities/filter_entities/checkbox_filter.rs` (+0 -28) 📝 `frontend/rust-lib/flowy-grid/src/entities/filter_entities/date_filter.rs` (+91 -5) 📝 `frontend/rust-lib/flowy-grid/src/entities/filter_entities/number_filter.rs` (+1 -78) 📝 `frontend/rust-lib/flowy-grid/src/entities/filter_entities/select_option_filter.rs` (+1 -64) 📝 `frontend/rust-lib/flowy-grid/src/entities/filter_entities/text_filter.rs` (+0 -86) 📝 `frontend/rust-lib/flowy-grid/src/entities/filter_entities/util.rs` (+13 -6) 📝 `frontend/rust-lib/flowy-grid/src/entities/group_entities.rs` (+4 -3) 📝 `frontend/rust-lib/flowy-grid/src/entities/setting_entities.rs` (+29 -33) 📝 `frontend/rust-lib/flowy-grid/src/entities/sort_entities.rs` (+4 -3) 📝 `frontend/rust-lib/flowy-grid/src/event_handler.rs` (+8 -1) 📝 `frontend/rust-lib/flowy-grid/src/services/cell/any_cell_data.rs` (+4 -15) 📝 `frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs` (+4 -1) 📝 `frontend/rust-lib/flowy-grid/src/services/field/select_option.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option.rs` (+2 -14) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option.rs` (+30 -17) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/multi_select_type_option.rs` (+3 -14) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/number_type_option/number_type_option.rs` (+3 -17) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/single_select_type_option.rs` (+2 -14) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/text_type_option.rs` (+3 -15) _...and 26 more files_ </details> ### 📄 Description 1. add feature flag: filter to enable the unit test 2. fix AnyCellData decode errors 3. add more tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>