[PR #618] [MERGED] Feat/insert cell test #4242

New issue

Closed

opened 2026-03-23 21:36:56 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:36:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/618
Author: @appflowy
Created: 7/17/2022
Status: ✅ Merged
Merged: 7/17/2022
Merged by: @appflowy

Base: main ← Head: feat/insert_cell_test

📝 Commits (8)

284755e refactor: row builder
1e3640f chore: config cell displayable data
f10e324 refactor: type options directory
602aab4 chore: unit test for cell content
d02acba chore: add more test
ab80e9b chore: add 5 rows in test grid
cca577f Merge branch 'main' into feat/insert_cell_test
5ea3213 chore: fix tests

📊 Changes

60 files changed (+2231 additions, -1695 deletions)

View changed files

📝 frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/cell_service.dart (+2 -2)
📝 frontend/app_flowy/lib/workspace/application/grid/cell/date_cal_bloc.dart (+1 -0)
📝 frontend/app_flowy/lib/workspace/application/grid/cell/date_cell_bloc.dart (+1 -1)
📝 frontend/app_flowy/lib/workspace/application/grid/cell/url_cell_bloc.dart (+1 -1)
📝 frontend/app_flowy/lib/workspace/application/grid/cell/url_cell_editor_bloc.dart (+1 -1)
📝 frontend/app_flowy/lib/workspace/application/grid/field/type_option/date_bloc.dart (+1 -0)
📝 frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/header/type_option/date.dart (+1 -1)
📝 frontend/rust-lib/flowy-grid/Flowy.toml (+0 -1)
📝 frontend/rust-lib/flowy-grid/src/entities/filter_entities/select_option_filter.rs (+1 -1)
📝 frontend/rust-lib/flowy-grid/src/event_handler.rs (+12 -7)
📝 frontend/rust-lib/flowy-grid/src/services/cell/any_cell_data.rs (+41 -13)
📝 frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs (+47 -29)
📝 frontend/rust-lib/flowy-grid/src/services/field/mod.rs (+0 -1)
➖ frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option.rs (+0 -133)
➕ frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_tests.rs (+30 -0)
➕ frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option.rs (+76 -0)
➕ frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option_entities.rs (+69 -0)
➕ frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/mod.rs (+7 -0)
➖ frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option.rs (+0 -661)
➕ frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_tests.rs (+272 -0)

...and 40 more files

📄 Description

Add unit test for cells
Add a handy tool to insert cell data into a row in the unit test
Refactor CellOperation
Add CellDisplayable trait to get the cell display data in the backend

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/618 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 7/17/2022 **Status:** ✅ Merged **Merged:** 7/17/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/insert_cell_test` --- ### 📝 Commits (8) - [`284755e`](https://github.com/AppFlowy-IO/AppFlowy/commit/284755eccf4f65b95d6b1a511831f0b6609d4b52) refactor: row builder - [`1e3640f`](https://github.com/AppFlowy-IO/AppFlowy/commit/1e3640f8acb88601a9aad9a0cbb578a0a34558f1) chore: config cell displayable data - [`f10e324`](https://github.com/AppFlowy-IO/AppFlowy/commit/f10e324b735a1d0cabdddae8c1694502072b00b0) refactor: type options directory - [`602aab4`](https://github.com/AppFlowy-IO/AppFlowy/commit/602aab45e269a2dce1713adb91427ff116993263) chore: unit test for cell content - [`d02acba`](https://github.com/AppFlowy-IO/AppFlowy/commit/d02acbae6eb0292188ed83149183e52dd5c29a20) chore: add more test - [`ab80e9b`](https://github.com/AppFlowy-IO/AppFlowy/commit/ab80e9b0ed8ddb51cfc26f42a682e3be1e9eba09) chore: add 5 rows in test grid - [`cca577f`](https://github.com/AppFlowy-IO/AppFlowy/commit/cca577f9673e7bd78ad980b772519df471399514) Merge branch 'main' into feat/insert_cell_test - [`5ea3213`](https://github.com/AppFlowy-IO/AppFlowy/commit/5ea3213c4e12123999ef14c96f5087eb6f9c667e) chore: fix tests ### 📊 Changes **60 files changed** (+2231 additions, -1695 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/cell_service.dart` (+2 -2) 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/date_cal_bloc.dart` (+1 -0) 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/date_cell_bloc.dart` (+1 -1) 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/url_cell_bloc.dart` (+1 -1) 📝 `frontend/app_flowy/lib/workspace/application/grid/cell/url_cell_editor_bloc.dart` (+1 -1) 📝 `frontend/app_flowy/lib/workspace/application/grid/field/type_option/date_bloc.dart` (+1 -0) 📝 `frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/widgets/header/type_option/date.dart` (+1 -1) 📝 `frontend/rust-lib/flowy-grid/Flowy.toml` (+0 -1) 📝 `frontend/rust-lib/flowy-grid/src/entities/filter_entities/select_option_filter.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-grid/src/event_handler.rs` (+12 -7) 📝 `frontend/rust-lib/flowy-grid/src/services/cell/any_cell_data.rs` (+41 -13) 📝 `frontend/rust-lib/flowy-grid/src/services/cell/cell_operation.rs` (+47 -29) 📝 `frontend/rust-lib/flowy-grid/src/services/field/mod.rs` (+0 -1) ➖ `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option.rs` (+0 -133) ➕ `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_tests.rs` (+30 -0) ➕ `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option.rs` (+76 -0) ➕ `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/checkbox_type_option_entities.rs` (+69 -0) ➕ `frontend/rust-lib/flowy-grid/src/services/field/type_options/checkbox_type_option/mod.rs` (+7 -0) ➖ `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option.rs` (+0 -661) ➕ `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_tests.rs` (+272 -0) _...and 40 more files_ </details> ### 📄 Description 1. Add unit test for cells 2. Add a handy tool to insert cell data into a row in the unit test 3. Refactor CellOperation 4. Add CellDisplayable trait to get the cell display data in the backend --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>