[PR #620] [MERGED] Fix githooks and remove Husky #4243

New issue

Closed

opened 2026-03-23 21:36:56 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:36:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/620
Author: @MikeWallaceDev
Created: 7/18/2022
Status: ✅ Merged
Merged: 7/19/2022
Merged by: @appflowy

Base: main ← Head: fix_githooks

📝 Commits (3)

6fcc37e fix: Made githook scripts executable
ff0c6a9 feat: Added commit-msg hook
5035075 fix: removed references to Husky

📊 Changes

5 files changed (+36 additions, -8 deletions)

View changed files

➕ .githooks/commit-msg (+26 -0)
📝 .githooks/pre-commit (+3 -1)
📝 .githooks/pre-push (+5 -0)
➖ .husky/commit-msg (+0 -4)
📝 package.json (+2 -3)

📄 Description

Our current implementation of githooks and Husky did not work. They did nothing.
My research showed that Husky is a JS script tool, and didn't really fit for our needs. So I removed it.
Native githooks will work fine, but require one line of code to be executed, I will document this in the Environment Setup documentation.

I enabled all of the hooks that @appflowy had setup, they all work now. However, I think that the pre-push hook might be too much and might need to be removed.

CommitLint also now works, I will add the documentation for that too.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/620 **Author:** [@MikeWallaceDev](https://github.com/MikeWallaceDev) **Created:** 7/18/2022 **Status:** ✅ Merged **Merged:** 7/19/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix_githooks` --- ### 📝 Commits (3) - [`6fcc37e`](https://github.com/AppFlowy-IO/AppFlowy/commit/6fcc37e15ce80a73cda68ee3a1bfdff2ce6e7c38) fix: Made githook scripts executable - [`ff0c6a9`](https://github.com/AppFlowy-IO/AppFlowy/commit/ff0c6a9d98be7d59dc4589ba3ff0bcf1238025bd) feat: Added commit-msg hook - [`5035075`](https://github.com/AppFlowy-IO/AppFlowy/commit/5035075e143b84e48924180bb0be076f4e34e9f2) fix: removed references to Husky ### 📊 Changes **5 files changed** (+36 additions, -8 deletions) <details> <summary>View changed files</summary> ➕ `.githooks/commit-msg` (+26 -0) 📝 `.githooks/pre-commit` (+3 -1) 📝 `.githooks/pre-push` (+5 -0) ➖ `.husky/commit-msg` (+0 -4) 📝 `package.json` (+2 -3) </details> ### 📄 Description Our current implementation of githooks and Husky did not work. They did nothing. My research showed that Husky is a JS script tool, and didn't really fit for our needs. So I removed it. Native githooks will work fine, but require one line of code to be executed, I will document this in the Environment Setup documentation. I enabled all of the hooks that @appflowy had setup, they all work now. However, I think that the pre-push hook might be too much and might need to be removed. CommitLint also now works, I will add the documentation for that too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>