[PR #722] [MERGED] chore: add selection_service documentation and resymbol shortcut service. #4293

New issue

Closed

opened 2026-03-23 21:37:10 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:37:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/722
Author: @LucasXu0
Created: 7/26/2022
Status: ✅ Merged
Merged: 7/27/2022
Merged by: @appflowy

Base: feat/flowy_editor ← Head: feat/flowy_editor

📝 Commits (5)

1907284 chore: add selection_service documentation and resymbol shortcut service.
9416715 chore: remove unused import
114ae2b feat: compute cursor and selection by [Selection] or [Offset]
cde2127 feat: compute cursor and selection by [Selection] or [Offset]
c048c8f fix: compute wrong upward selection

📊 Changes

20 files changed (+434 additions, -282 deletions)

View changed files

📝 frontend/app_flowy/packages/flowy_editor/example/lib/main.dart (+1 -1)
📝 frontend/app_flowy/packages/flowy_editor/example/lib/plugin/image_node_widget.dart (+20 -16)
📝 frontend/app_flowy/packages/flowy_editor/example/lib/plugin/selected_text_node_widget.dart (+32 -54)
📝 frontend/app_flowy/packages/flowy_editor/example/lib/plugin/text_node_widget.dart (+1 -2)
📝 frontend/app_flowy/packages/flowy_editor/lib/document/path.dart (+2 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/document/position.dart (+10 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/document/selection.dart (+30 -6)
➕ frontend/app_flowy/packages/flowy_editor/lib/extensions/node_extensions.dart (+23 -0)
➕ frontend/app_flowy/packages/flowy_editor/lib/extensions/path_extensions.dart (+25 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/render/selection/selectable.dart (+11 -9)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/editor_service.dart (+11 -9)
➖ frontend/app_flowy/packages/flowy_editor/lib/service/flowy_key_event_handlers/arrow_keys_handler.dart (+0 -37)
➕ frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/arrow_keys_handler.dart (+14 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/delete_nodes_handler.dart (+0 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/delete_single_text_node_handler.dart (+2 -2)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/shortcut_handler.dart (+7 -7)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart (+243 -137)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/service.dart (+1 -1)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/shortcut_service.dart (+0 -0)
📝 frontend/app_flowy/packages/flowy_editor/test/flowy_editor_test.dart (+1 -1)

📄 Description

Support update selection or cursor by [Offset] or [Selection].

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/722 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 7/26/2022 **Status:** ✅ Merged **Merged:** 7/27/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `feat/flowy_editor` ← **Head:** `feat/flowy_editor` --- ### 📝 Commits (5) - [`1907284`](https://github.com/AppFlowy-IO/AppFlowy/commit/190728453476b64a6ffc3dd89c147b9dd240d5af) chore: add selection_service documentation and resymbol shortcut service. - [`9416715`](https://github.com/AppFlowy-IO/AppFlowy/commit/941671568e40f0cf87f10e3432ca45e3674f5f8a) chore: remove unused import - [`114ae2b`](https://github.com/AppFlowy-IO/AppFlowy/commit/114ae2b45dd7b7b4cf42bd8ac11df1e188f5cfa1) feat: compute cursor and selection by [Selection] or [Offset] - [`cde2127`](https://github.com/AppFlowy-IO/AppFlowy/commit/cde2127dec91c473eb42bfd9e172fc7817c18e05) feat: compute cursor and selection by [Selection] or [Offset] - [`c048c8f`](https://github.com/AppFlowy-IO/AppFlowy/commit/c048c8f623451ea7fbbb4499b90846104826420c) fix: compute wrong upward selection ### 📊 Changes **20 files changed** (+434 additions, -282 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/flowy_editor/example/lib/main.dart` (+1 -1) 📝 `frontend/app_flowy/packages/flowy_editor/example/lib/plugin/image_node_widget.dart` (+20 -16) 📝 `frontend/app_flowy/packages/flowy_editor/example/lib/plugin/selected_text_node_widget.dart` (+32 -54) 📝 `frontend/app_flowy/packages/flowy_editor/example/lib/plugin/text_node_widget.dart` (+1 -2) 📝 `frontend/app_flowy/packages/flowy_editor/lib/document/path.dart` (+2 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/document/position.dart` (+10 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/document/selection.dart` (+30 -6) ➕ `frontend/app_flowy/packages/flowy_editor/lib/extensions/node_extensions.dart` (+23 -0) ➕ `frontend/app_flowy/packages/flowy_editor/lib/extensions/path_extensions.dart` (+25 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/render/selection/selectable.dart` (+11 -9) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/editor_service.dart` (+11 -9) ➖ `frontend/app_flowy/packages/flowy_editor/lib/service/flowy_key_event_handlers/arrow_keys_handler.dart` (+0 -37) ➕ `frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/arrow_keys_handler.dart` (+14 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/delete_nodes_handler.dart` (+0 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/delete_single_text_node_handler.dart` (+2 -2) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/shortcut_handler.dart` (+7 -7) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart` (+243 -137) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/service.dart` (+1 -1) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/shortcut_service.dart` (+0 -0) 📝 `frontend/app_flowy/packages/flowy_editor/test/flowy_editor_test.dart` (+1 -1) </details> ### 📄 Description Support update selection or cursor by [Offset] or [Selection]. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>