[PR #788] [MERGED] fix: could not delete character when using IME #4342

New issue

Closed

opened 2026-03-23 21:37:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:37:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/788
Author: @LucasXu0
Created: 8/8/2022
Status: ✅ Merged
Merged: 8/8/2022
Merged by: @appflowy

Base: main ← Head: fix/ime_error

📝 Commits (8)

849e19e fix: popuplist will not show when the selection is not collapsed
7855e54 feat: convert text to bulleted list style when inputing '* ' or '- '
19fc154 feat: implement markdown input, like, #, *, -, -[]
dc018bc fix: could not delete character when using IME
2f84d7e fix: fix crash when selecting the last node
1ece5cf feat: binary search selection supports searching child nodes
6e71ec2 feat: delete slash when using the popuplist and pressing enter key
27ea5a1 feat: disable scroll when showing popuplist

📊 Changes

10 files changed (+278 additions, -63 deletions)

View changed files

📝 frontend/app_flowy/packages/flowy_editor/lib/document/node_iterator.dart (+1 -1)
📝 frontend/app_flowy/packages/flowy_editor/lib/render/rich_text/checkbox_text.dart (+11 -5)
📝 frontend/app_flowy/packages/flowy_editor/lib/render/rich_text/flowy_rich_text.dart (+1 -1)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/editor_service.dart (+2 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/input_service.dart (+35 -13)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/delete_text_handler.dart (+13 -5)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/slash_handler.dart (+47 -20)
➕ frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/whitespace_handler.dart (+131 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/scroll_service.dart (+17 -7)
📝 frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart (+20 -11)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/788 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 8/8/2022 **Status:** ✅ Merged **Merged:** 8/8/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/ime_error` --- ### 📝 Commits (8) - [`849e19e`](https://github.com/AppFlowy-IO/AppFlowy/commit/849e19e1ef8b14c4af911c04e7c9640597d8483e) fix: popuplist will not show when the selection is not collapsed - [`7855e54`](https://github.com/AppFlowy-IO/AppFlowy/commit/7855e5403ceeee9a434c4ff11079fbc38dceb092) feat: convert text to bulleted list style when inputing '* ' or '- ' - [`19fc154`](https://github.com/AppFlowy-IO/AppFlowy/commit/19fc1546810b0d22593914229284a6915b27e46a) feat: implement markdown input, like, #, *, -, -[] - [`dc018bc`](https://github.com/AppFlowy-IO/AppFlowy/commit/dc018bc7e494e0e5a38d22c838e89c375c2f7c38) fix: could not delete character when using IME - [`2f84d7e`](https://github.com/AppFlowy-IO/AppFlowy/commit/2f84d7e54e7bbc3e0216224d340efcad742e1fac) fix: fix crash when selecting the last node - [`1ece5cf`](https://github.com/AppFlowy-IO/AppFlowy/commit/1ece5cfd9e3cdb7f6497c33c68b59e1b4a28f6ff) feat: binary search selection supports searching child nodes - [`6e71ec2`](https://github.com/AppFlowy-IO/AppFlowy/commit/6e71ec23a111e71bc7fd6f696fcf806215c3cf90) feat: delete slash when using the popuplist and pressing enter key - [`27ea5a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/27ea5a11a9dd4ed7db4b7c5e5bf6b90d8c1fedee) feat: disable scroll when showing popuplist ### 📊 Changes **10 files changed** (+278 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/flowy_editor/lib/document/node_iterator.dart` (+1 -1) 📝 `frontend/app_flowy/packages/flowy_editor/lib/render/rich_text/checkbox_text.dart` (+11 -5) 📝 `frontend/app_flowy/packages/flowy_editor/lib/render/rich_text/flowy_rich_text.dart` (+1 -1) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/editor_service.dart` (+2 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/input_service.dart` (+35 -13) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/delete_text_handler.dart` (+13 -5) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/slash_handler.dart` (+47 -20) ➕ `frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/whitespace_handler.dart` (+131 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/scroll_service.dart` (+17 -7) 📝 `frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart` (+20 -11) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>