[PR #807] [MERGED] Fix: emoji position and unicode issues #4358

New issue

Closed

opened 2026-03-23 21:37:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:37:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/807
Author: @vincentdchan
Created: 8/10/2022
Status: ✅ Merged
Merged: 8/10/2022
Merged by: @vincentdchan

Base: main ← Head: refactor/text-delta

📝 Commits (7)

737e374 refactor: text-delta
eb519f4 feat: add cache to text_delta
45556ae refactor: flutter style optional chaining
bee1a04 feat: compute string indexes
c554720 fix: emoji position
b5ecd7d test: next runes
223c8ca fix: crashes when deleting emoji

📊 Changes

10 files changed (+351 additions, -202 deletions)

View changed files

📝 frontend/app_flowy/packages/flowy_editor/lib/src/document/node.dart (+1 -3)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/document/text_delta.dart (+96 -54)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/extensions/text_node_extensions.dart (+1 -1)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/infra/html_converter.dart (+3 -3)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/operation/transaction_builder.dart (+24 -14)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/render/rich_text/flowy_rich_text.dart (+1 -1)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/arrow_keys_handler.dart (+11 -3)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/copy_paste_handler.dart (+27 -16)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/delete_text_handler.dart (+3 -3)
📝 frontend/app_flowy/packages/flowy_editor/test/delta_test.dart (+184 -104)

📄 Description

Refactor text delta to match flutter style
Fix emoji position problems
Fix crashes when deleting emoji

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/807 **Author:** [@vincentdchan](https://github.com/vincentdchan) **Created:** 8/10/2022 **Status:** ✅ Merged **Merged:** 8/10/2022 **Merged by:** [@vincentdchan](https://github.com/vincentdchan) **Base:** `main` ← **Head:** `refactor/text-delta` --- ### 📝 Commits (7) - [`737e374`](https://github.com/AppFlowy-IO/AppFlowy/commit/737e374a5491c9f83cdd1de278e42224afda8c5d) refactor: text-delta - [`eb519f4`](https://github.com/AppFlowy-IO/AppFlowy/commit/eb519f4e11884ffcf1e2a28b56104d73b4a64698) feat: add cache to text_delta - [`45556ae`](https://github.com/AppFlowy-IO/AppFlowy/commit/45556ae015a703b16afb0e9ae536611cd9511b85) refactor: flutter style optional chaining - [`bee1a04`](https://github.com/AppFlowy-IO/AppFlowy/commit/bee1a0432936c228a15866e64b3696f40b99371b) feat: compute string indexes - [`c554720`](https://github.com/AppFlowy-IO/AppFlowy/commit/c554720dffe207ba77a19b31377f930de214db5e) fix: emoji position - [`b5ecd7d`](https://github.com/AppFlowy-IO/AppFlowy/commit/b5ecd7dedcd167e7c1506edbeab0cb15503c5d84) test: next runes - [`223c8ca`](https://github.com/AppFlowy-IO/AppFlowy/commit/223c8cafd475c45f0bf3c7ed010b8e5dde32943d) fix: crashes when deleting emoji ### 📊 Changes **10 files changed** (+351 additions, -202 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/document/node.dart` (+1 -3) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/document/text_delta.dart` (+96 -54) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/extensions/text_node_extensions.dart` (+1 -1) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/infra/html_converter.dart` (+3 -3) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/operation/transaction_builder.dart` (+24 -14) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/render/rich_text/flowy_rich_text.dart` (+1 -1) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/arrow_keys_handler.dart` (+11 -3) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/copy_paste_handler.dart` (+27 -16) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/delete_text_handler.dart` (+3 -3) 📝 `frontend/app_flowy/packages/flowy_editor/test/delta_test.dart` (+184 -104) </details> ### 📄 Description - [x] Refactor text delta to match flutter style - [x] Fix emoji position problems ![2022-08-10 17 33 20](https://user-images.githubusercontent.com/2352832/183868215-c339be72-6e70-4318-9d46-0ac73eda3e80.gif) - [x] Fix crashes when deleting emoji ![2022-08-10 18 07 13](https://user-images.githubusercontent.com/2352832/183875845-074b1063-e907-44ef-9bb8-c692e206492e.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>