[PR #857] [MERGED] implement white_space_handler & update_text_style_by_command_X test #4391

New issue

Closed

opened 2026-03-23 21:37:36 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:37:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/857
Author: @LucasXu0
Created: 8/16/2022
Status: ✅ Merged
Merged: 8/17/2022
Merged by: @appflowy

Base: main ← Head: test/internal_key_event_handlers

📝 Commits (3)

88ae437 test: update text style by command + x
a7681f8 test: implement white_space_handler test
ad26f9c fix: checkbox + underline doesn’t work when the checkbox is checked

📊 Changes

9 files changed (+371 additions, -14 deletions)

View changed files

📝 frontend/app_flowy/packages/flowy_editor/lib/src/extensions/text_node_extensions.dart (+24 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/render/rich_text/checkbox_text.dart (+6 -2)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/whitespace_handler.dart (+7 -0)
📝 frontend/app_flowy/packages/flowy_editor/lib/src/service/service.dart (+8 -4)
📝 frontend/app_flowy/packages/flowy_editor/test/infra/test_editor.dart (+27 -4)
📝 frontend/app_flowy/packages/flowy_editor/test/infra/test_raw_key_event.dart (+3 -0)
➕ frontend/app_flowy/packages/flowy_editor/test/render/rich_text/checkbox_text_test.dart (+73 -0)
📝 frontend/app_flowy/packages/flowy_editor/test/service/internal_key_event_handlers/update_text_style_by_command_x_handler_test.dart (+45 -4)
➕ frontend/app_flowy/packages/flowy_editor/test/service/internal_key_event_handlers/white_space_handler_test.dart (+178 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/857 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 8/16/2022 **Status:** ✅ Merged **Merged:** 8/17/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `test/internal_key_event_handlers` --- ### 📝 Commits (3) - [`88ae437`](https://github.com/AppFlowy-IO/AppFlowy/commit/88ae437379a0f62dd5b15d8f06be5aeae2c629af) test: update text style by command + x - [`a7681f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/a7681f86e51291996ca456bb906e1e8f681c6d0f) test: implement white_space_handler test - [`ad26f9c`](https://github.com/AppFlowy-IO/AppFlowy/commit/ad26f9c86d2e0edd8fc2ee5f69929b0baf580869) fix: checkbox + underline doesn’t work when the checkbox is checked ### 📊 Changes **9 files changed** (+371 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/extensions/text_node_extensions.dart` (+24 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/render/rich_text/checkbox_text.dart` (+6 -2) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/whitespace_handler.dart` (+7 -0) 📝 `frontend/app_flowy/packages/flowy_editor/lib/src/service/service.dart` (+8 -4) 📝 `frontend/app_flowy/packages/flowy_editor/test/infra/test_editor.dart` (+27 -4) 📝 `frontend/app_flowy/packages/flowy_editor/test/infra/test_raw_key_event.dart` (+3 -0) ➕ `frontend/app_flowy/packages/flowy_editor/test/render/rich_text/checkbox_text_test.dart` (+73 -0) 📝 `frontend/app_flowy/packages/flowy_editor/test/service/internal_key_event_handlers/update_text_style_by_command_x_handler_test.dart` (+45 -4) ➕ `frontend/app_flowy/packages/flowy_editor/test/service/internal_key_event_handlers/white_space_handler_test.dart` (+178 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>