[PR #892] [MERGED] [FR] Implement link feature in AppFlowyEditor #886 #4414

New issue

Closed

opened 2026-03-23 21:37:42 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:37:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/892
Author: @LucasXu0
Created: 8/23/2022
Status: ✅ Merged
Merged: 8/27/2022
Merged by: @appflowy

Base: main ← Head: feat/link

📝 Commits (10+)

f943aea chore: improve cursor display style
1f90f30 feat: implement link menu
886c1f0 feat: implement command + K to trigger link menu
1cd9a77 fix: could not open link without scheme
6517ade fix: show remove link and copy link entry when there is not linkd text
70ea808 feat: single tap to edit link and double tap to open the link
44b4ef4 feat: filter the toolbar item should not be displayed
60a7557 fix: link text is only displayed if all selected text satisfy linked style
1262457 feat: add link menu test
104b4cc test: test the toolbar_service, toolbar_*.dart

📊 Changes

27 files changed (+959 additions, -319 deletions)

View changed files

➕ frontend/app_flowy/packages/appflowy_editor/assets/images/clear.svg (+5 -0)
➕ frontend/app_flowy/packages/appflowy_editor/assets/images/delete.svg (+6 -0)
➕ frontend/app_flowy/packages/appflowy_editor/assets/images/link.svg (+4 -0)
📝 frontend/app_flowy/packages/appflowy_editor/assets/images/toolbar/link.svg (+2 -2)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/text_node_extensions.dart (+48 -9)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/infra/log.dart (+5 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/render/link_menu/link_menu.dart (+151 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/bulleted_list_text.dart (+1 -4)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/checkbox_text.dart (+1 -5)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/flowy_rich_text.dart (+86 -42)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/number_list_text.dart (+1 -3)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/quoted_text.dart (+1 -3)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/rich_text_style.dart (+4 -14)
➖ frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection/toolbar_widget.dart (+0 -217)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart (+231 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item_widget.dart (+35 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_widget.dart (+79 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/input_service.dart (+12 -9)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/update_text_style_by_command_x_handler.dart (+6 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/service.dart (+3 -3)

...and 7 more files

📄 Description

https://github.com/AppFlowy-IO/AppFlowy/issues/886

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/892 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 8/23/2022 **Status:** ✅ Merged **Merged:** 8/27/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/link` --- ### 📝 Commits (10+) - [`f943aea`](https://github.com/AppFlowy-IO/AppFlowy/commit/f943aeacd7dd97162c7b6365ed744e3eef5b6c34) chore: improve cursor display style - [`1f90f30`](https://github.com/AppFlowy-IO/AppFlowy/commit/1f90f3027430f6f4f5e3a07ebef69ff419362d76) feat: implement link menu - [`886c1f0`](https://github.com/AppFlowy-IO/AppFlowy/commit/886c1f00e541d6c1b11b646845d161ee98543d69) feat: implement command + K to trigger link menu - [`1cd9a77`](https://github.com/AppFlowy-IO/AppFlowy/commit/1cd9a77e007538d1056cf864bb8225bef0dbd022) fix: could not open link without scheme - [`6517ade`](https://github.com/AppFlowy-IO/AppFlowy/commit/6517adece7a92bba53d774ad532dd11c82be4cba) fix: show remove link and copy link entry when there is not linkd text - [`70ea808`](https://github.com/AppFlowy-IO/AppFlowy/commit/70ea80878adea6c15e94c973d7155a1edd0cbf7a) feat: single tap to edit link and double tap to open the link - [`44b4ef4`](https://github.com/AppFlowy-IO/AppFlowy/commit/44b4ef4ad77a147535cc41a2c56230359dd4a774) feat: filter the toolbar item should not be displayed - [`60a7557`](https://github.com/AppFlowy-IO/AppFlowy/commit/60a7557520064929692914b66bf5ee818ced6822) fix: link text is only displayed if all selected text satisfy linked style - [`1262457`](https://github.com/AppFlowy-IO/AppFlowy/commit/1262457755865166142c0009f9b92d6251dd99d0) feat: add link menu test - [`104b4cc`](https://github.com/AppFlowy-IO/AppFlowy/commit/104b4cca9def05cd5d8f99a791055997ce217d70) test: test the toolbar_service, toolbar_*.dart ### 📊 Changes **27 files changed** (+959 additions, -319 deletions) <details> <summary>View changed files</summary> ➕ `frontend/app_flowy/packages/appflowy_editor/assets/images/clear.svg` (+5 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/assets/images/delete.svg` (+6 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/assets/images/link.svg` (+4 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/assets/images/toolbar/link.svg` (+2 -2) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/text_node_extensions.dart` (+48 -9) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/infra/log.dart` (+5 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/render/link_menu/link_menu.dart` (+151 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/bulleted_list_text.dart` (+1 -4) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/checkbox_text.dart` (+1 -5) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/flowy_rich_text.dart` (+86 -42) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/number_list_text.dart` (+1 -3) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/quoted_text.dart` (+1 -3) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/rich_text_style.dart` (+4 -14) ➖ `frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection/toolbar_widget.dart` (+0 -217) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart` (+231 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item_widget.dart` (+35 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_widget.dart` (+79 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/input_service.dart` (+12 -9) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/update_text_style_by_command_x_handler.dart` (+6 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/service.dart` (+3 -3) _...and 7 more files_ </details> ### 📄 Description https://github.com/AppFlowy-IO/AppFlowy/issues/886 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>