[PR #939] [MERGED] feat: "/" supports inserting Quote #936 #4444

Closed
opened 2026-03-23 21:37:50 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/939
Author: @LucasXu0
Created: 8/30/2022
Status: Merged
Merged: 8/30/2022
Merged by: @appflowy

Base: mainHead: feat/936


📝 Commits (4)

  • 3eaa31c feat: #931 highlight the status of the currently selected style in toolbar
  • 0f33496 test: add more test cases to toolbar_service
  • 8afa48c fix: # doesn't work #937
  • 071ff06 feat: / supports inserting Quote #936

📊 Changes

18 files changed (+418 additions, -79 deletions)

View changed files

📝 frontend/app_flowy/packages/appflowy_editor/assets/images/quote.svg (+1 -1)
frontend/app_flowy/packages/appflowy_editor/assets/images/selection_menu/quote.svg (+4 -0)
frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/editor_state_extensions.dart (+8 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/text_node_extensions.dart (+56 -34)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/heading_text.dart (+0 -1)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/rich_text_style.dart (+6 -1)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart (+8 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart (+127 -20)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item_widget.dart (+4 -1)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_widget.dart (+1 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart (+4 -2)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/backspace_handler.dart (+3 -1)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/toolbar_service.dart (+5 -0)
📝 frontend/app_flowy/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart (+5 -5)
📝 frontend/app_flowy/packages/appflowy_editor/test/render/toolbar/toolbar_item_widget_test.dart (+17 -1)
📝 frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/backspace_handler_test.dart (+32 -0)
📝 frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/update_text_style_by_command_x_handler_test.dart (+5 -11)
📝 frontend/app_flowy/packages/appflowy_editor/test/service/toolbar_service_test.dart (+132 -1)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/939 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 8/30/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/936` --- ### 📝 Commits (4) - [`3eaa31c`](https://github.com/AppFlowy-IO/AppFlowy/commit/3eaa31c68c65bd99b4be67259226bb93d1cb26bb) feat: #931 highlight the status of the currently selected style in toolbar - [`0f33496`](https://github.com/AppFlowy-IO/AppFlowy/commit/0f334962ceea9a77d2b5d06909a977fc548c44ca) test: add more test cases to toolbar_service - [`8afa48c`](https://github.com/AppFlowy-IO/AppFlowy/commit/8afa48ca1620edae27683df6b2a5f8d319f2d16d) fix: # doesn't work #937 - [`071ff06`](https://github.com/AppFlowy-IO/AppFlowy/commit/071ff06d47bc2b3ce18cb2d6d94e97a0c6c7a167) feat: / supports inserting Quote #936 ### 📊 Changes **18 files changed** (+418 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/appflowy_editor/assets/images/quote.svg` (+1 -1) ➕ `frontend/app_flowy/packages/appflowy_editor/assets/images/selection_menu/quote.svg` (+4 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/editor_state_extensions.dart` (+8 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/text_node_extensions.dart` (+56 -34) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/heading_text.dart` (+0 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/rich_text_style.dart` (+6 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart` (+8 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart` (+127 -20) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item_widget.dart` (+4 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_widget.dart` (+1 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart` (+4 -2) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/backspace_handler.dart` (+3 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/toolbar_service.dart` (+5 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart` (+5 -5) 📝 `frontend/app_flowy/packages/appflowy_editor/test/render/toolbar/toolbar_item_widget_test.dart` (+17 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/backspace_handler_test.dart` (+32 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/update_text_style_by_command_x_handler_test.dart` (+5 -11) 📝 `frontend/app_flowy/packages/appflowy_editor/test/service/toolbar_service_test.dart` (+132 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 21:37:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#4444
No description provided.