[PR #1014] [MERGED] Refactor/document tree #4495

New issue

Closed

opened 2026-03-23 21:38:04 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1014
Author: @appflowy
Created: 9/9/2022
Status: ✅ Merged
Merged: 9/9/2022
Merged by: @appflowy

Base: main ← Head: refactor/document_tree

📝 Commits (10+)

800e02d refactor: remove Box in DocumentOperation
294b1be refactor: remove Box in DocumentOperation
8f51343 refactor: generic insert_nodes method
89a5ee4 fix: potential crash while calling apply_insert if the path is empty
d386698 fix: skip root to get the right path
e711bfc chore: udpate test
9974539 chore: private the Arena
ac23f81 chore: private the root node
a2918d2 refactor: refactor transaction builder in rust style
8f114e8 chore: replace fold with count

📊 Changes

11 files changed (+542 additions, -269 deletions)

View changed files

📝 shared-lib/lib-ot/src/core/document/attributes.rs (+24 -3)
📝 shared-lib/lib-ot/src/core/document/document.rs (+98 -40)
📝 shared-lib/lib-ot/src/core/document/document_operation.rs (+26 -32)
📝 shared-lib/lib-ot/src/core/document/node.rs (+10 -6)
📝 shared-lib/lib-ot/src/core/document/position.rs (+47 -16)
📝 shared-lib/lib-ot/src/core/document/transaction.rs (+73 -25)
📝 shared-lib/lib-ot/src/errors.rs (+1 -0)
📝 shared-lib/lib-ot/tests/main.rs (+1 -147)
➕ shared-lib/lib-ot/tests/node/mod.rs (+2 -0)
➕ shared-lib/lib-ot/tests/node/script.rs (+76 -0)
➕ shared-lib/lib-ot/tests/node/test.rs (+184 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1014 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 9/9/2022 **Status:** ✅ Merged **Merged:** 9/9/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor/document_tree` --- ### 📝 Commits (10+) - [`800e02d`](https://github.com/AppFlowy-IO/AppFlowy/commit/800e02d85e1621e0737685e778a44305f4790a62) refactor: remove Box in DocumentOperation - [`294b1be`](https://github.com/AppFlowy-IO/AppFlowy/commit/294b1bea13a595bc468122f0e633d6ed872973aa) refactor: remove Box in DocumentOperation - [`8f51343`](https://github.com/AppFlowy-IO/AppFlowy/commit/8f5134305e98a41a2bbb21360815c8339a76bdc9) refactor: generic insert_nodes method - [`89a5ee4`](https://github.com/AppFlowy-IO/AppFlowy/commit/89a5ee4a8a9359bd82a154c16057c9f40ffec122) fix: potential crash while calling apply_insert if the path is empty - [`d386698`](https://github.com/AppFlowy-IO/AppFlowy/commit/d386698e978ff5f4ac99b4dc1df630d13b42a5e9) fix: skip root to get the right path - [`e711bfc`](https://github.com/AppFlowy-IO/AppFlowy/commit/e711bfce1d776618f44f9842a3ed6d213eabe17f) chore: udpate test - [`9974539`](https://github.com/AppFlowy-IO/AppFlowy/commit/9974539946a236550242dbd51b3ebb97d081f87f) chore: private the Arena - [`ac23f81`](https://github.com/AppFlowy-IO/AppFlowy/commit/ac23f81e24bbebd1eed386f250ddbd95a8cb59f7) chore: private the root node - [`a2918d2`](https://github.com/AppFlowy-IO/AppFlowy/commit/a2918d251f26720d0ce2c5d83b0fb9e124c26f78) refactor: refactor transaction builder in rust style - [`8f114e8`](https://github.com/AppFlowy-IO/AppFlowy/commit/8f114e843c093ee257d0793b62e0bfc0d042a4e7) chore: replace fold with count ### 📊 Changes **11 files changed** (+542 additions, -269 deletions) <details> <summary>View changed files</summary> 📝 `shared-lib/lib-ot/src/core/document/attributes.rs` (+24 -3) 📝 `shared-lib/lib-ot/src/core/document/document.rs` (+98 -40) 📝 `shared-lib/lib-ot/src/core/document/document_operation.rs` (+26 -32) 📝 `shared-lib/lib-ot/src/core/document/node.rs` (+10 -6) 📝 `shared-lib/lib-ot/src/core/document/position.rs` (+47 -16) 📝 `shared-lib/lib-ot/src/core/document/transaction.rs` (+73 -25) 📝 `shared-lib/lib-ot/src/errors.rs` (+1 -0) 📝 `shared-lib/lib-ot/tests/main.rs` (+1 -147) ➕ `shared-lib/lib-ot/tests/node/mod.rs` (+2 -0) ➕ `shared-lib/lib-ot/tests/node/script.rs` (+76 -0) ➕ `shared-lib/lib-ot/tests/node/test.rs` (+184 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>