[PR #1045] [MERGED] Feat: wrap appflowy style popover #4512

New issue

Closed

opened 2026-03-23 21:38:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1045
Author: @vincentdchan
Created: 9/14/2022
Status: ✅ Merged
Merged: 9/15/2022
Merged by: @appflowy

Base: main ← Head: feat/wrap-appflowy-style-popover

📝 Commits (7)

cc0d408 fix: popover container
286781f refactor: PopoverContainerState -> PopoverContainer
7bde75e feat: wrap appflowy style popover
41b8551 fix: lint issues
5294d77 Merge branch 'main' into feat/wrap-appflowy-style-popover
499ee29 chore: remove unused ref
520d5c2 chore: replace popover with appflowy popover

📊 Changes

26 files changed (+291 additions, -308 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_setting.dart (+26 -26)
📝 frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_toolbar.dart (+20 -3)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart (+3 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart (+8 -13)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart (+12 -14)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart (+16 -18)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/cell_editor.dart (+6 -10)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart (+5 -2)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart (+10 -12)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_list.dart (+2 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_option_editor.dart (+3 -6)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/grid_header.dart (+7 -9)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart (+20 -23)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/multi_select.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/number.dart (+10 -12)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart (+18 -20)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/single_select.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/row/row_detail.dart (+29 -18)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_group.dart (+15 -23)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_property.dart (+7 -9)

...and 6 more files

📄 Description

Improvement of : #903

Warp Popover into AppflowyStylePopover for the app.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1045 **Author:** [@vincentdchan](https://github.com/vincentdchan) **Created:** 9/14/2022 **Status:** ✅ Merged **Merged:** 9/15/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `feat/wrap-appflowy-style-popover` --- ### 📝 Commits (7) - [`cc0d408`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc0d4087754c03d04f161cbdeb50199f3470e879) fix: popover container - [`286781f`](https://github.com/AppFlowy-IO/AppFlowy/commit/286781f5cc811fc0189192dd67c5b425b647a46e) refactor: PopoverContainerState -> PopoverContainer - [`7bde75e`](https://github.com/AppFlowy-IO/AppFlowy/commit/7bde75ee2fb2b3cc8a2dfa97209594ce4957981e) feat: wrap appflowy style popover - [`41b8551`](https://github.com/AppFlowy-IO/AppFlowy/commit/41b85510bff2d4dcd8d8426721ba83e6b8e13c56) fix: lint issues - [`5294d77`](https://github.com/AppFlowy-IO/AppFlowy/commit/5294d7700ee5ec100a233d1c67a7443e2b730534) Merge branch 'main' into feat/wrap-appflowy-style-popover - [`499ee29`](https://github.com/AppFlowy-IO/AppFlowy/commit/499ee29c3d3a5e0fca0bc934a5c15f4cb1b59fa4) chore: remove unused ref - [`520d5c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/520d5c2cb0096cfadbd29daf6ff9975b97db0245) chore: replace popover with appflowy popover ### 📊 Changes **26 files changed** (+291 additions, -308 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_setting.dart` (+26 -26) 📝 `frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_toolbar.dart` (+20 -3) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart` (+3 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart` (+8 -13) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart` (+12 -14) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart` (+16 -18) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/cell_editor.dart` (+6 -10) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart` (+5 -2) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart` (+10 -12) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_list.dart` (+2 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_type_option_editor.dart` (+3 -6) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/grid_header.dart` (+7 -9) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/date.dart` (+20 -23) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/multi_select.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/number.dart` (+10 -12) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart` (+18 -20) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/single_select.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/row/row_detail.dart` (+29 -18) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_group.dart` (+15 -23) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/toolbar/grid_property.dart` (+7 -9) _...and 6 more files_ </details> ### 📄 Description Improvement of : #903 Warp Popover into AppflowyStylePopover for the app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>