[PR #1080] [MERGED] fix: some improvements for when including time in a date cell #4519

New issue

Closed

opened 2026-03-23 21:38:10 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1080
Author: @richardshiue
Created: 9/17/2022
Status: ✅ Merged
Merged: 9/21/2022
Merged by: @annieappflowy

Base: main ← Head: fix-include-time

📝 Commits (4)

2e60459 chore: rewrite UI strings for time format hints
a413746 fix: immediately show or hide time when includeTime changes
c3033bd fix: few UI/usability issues with the time input field
05975e5 test: fix includeTime-related tests

📊 Changes

11 files changed (+24 additions, -21 deletions)

View changed files

📝 frontend/app_flowy/assets/translations/en.json (+2 -2)
📝 frontend/app_flowy/assets/translations/es-VE.json (+2 -2)
📝 frontend/app_flowy/assets/translations/fr-FR.json (+2 -2)
📝 frontend/app_flowy/assets/translations/id-ID.json (+2 -2)
📝 frontend/app_flowy/assets/translations/ru-RU.json (+2 -2)
📝 frontend/app_flowy/assets/translations/zh-CN.json (+2 -2)
📝 frontend/app_flowy/assets/translations/zh-TW.json (+2 -2)
📝 frontend/app_flowy/lib/plugins/grid/application/cell/date_cal_bloc.dart (+4 -4)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart (+1 -0)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_tests.rs (+3 -1)
📝 frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_type_option.rs (+2 -2)

📄 Description

I think one o'clock is better than noon for time format hinting
the cell's time should show/hide immediately according to the switch
I added autofocus to the text field when the switch is toggled
prevent the date from disappearing when the time input is invalid. (see below)
prevent the time field from showing a whitespace at the front after submitting (see below). The cell's date and time spacing is actually reduced by one space as well, but it can be re-added separately.

https://user-images.githubusercontent.com/71320345/190865573-0af932d2-135b-47ea-9139-f450d9bbaecc.mp4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1080 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/17/2022 **Status:** ✅ Merged **Merged:** 9/21/2022 **Merged by:** [@annieappflowy](https://github.com/annieappflowy) **Base:** `main` ← **Head:** `fix-include-time` --- ### 📝 Commits (4) - [`2e60459`](https://github.com/AppFlowy-IO/AppFlowy/commit/2e60459878bd1b06aebb7d618e5e75048b6b8ddb) chore: rewrite UI strings for time format hints - [`a413746`](https://github.com/AppFlowy-IO/AppFlowy/commit/a413746c05dbcbb6534d98f0231cd8524a8af983) fix: immediately show or hide time when includeTime changes - [`c3033bd`](https://github.com/AppFlowy-IO/AppFlowy/commit/c3033bd6e84fa0ef8bd1d90e2b314749fc133875) fix: few UI/usability issues with the time input field - [`05975e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/05975e55f04d8f70412e98133b496ce2800f66cc) test: fix includeTime-related tests ### 📊 Changes **11 files changed** (+24 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/assets/translations/en.json` (+2 -2) 📝 `frontend/app_flowy/assets/translations/es-VE.json` (+2 -2) 📝 `frontend/app_flowy/assets/translations/fr-FR.json` (+2 -2) 📝 `frontend/app_flowy/assets/translations/id-ID.json` (+2 -2) 📝 `frontend/app_flowy/assets/translations/ru-RU.json` (+2 -2) 📝 `frontend/app_flowy/assets/translations/zh-CN.json` (+2 -2) 📝 `frontend/app_flowy/assets/translations/zh-TW.json` (+2 -2) 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/date_cal_bloc.dart` (+4 -4) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart` (+1 -0) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_tests.rs` (+3 -1) 📝 `frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_type_option.rs` (+2 -2) </details> ### 📄 Description - I think one o'clock is better than noon for time format hinting - the cell's time should show/hide immediately according to the switch - I added autofocus to the text field when the switch is toggled - prevent the date from disappearing when the time input is invalid. (see below) - prevent the time field from showing a whitespace at the front after submitting (see below). The cell's date and time spacing is actually reduced by one space as well, but it can be re-added separately. https://user-images.githubusercontent.com/71320345/190865573-0af932d2-135b-47ea-9139-f450d9bbaecc.mp4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>