[PR #1133] [MERGED] fix: remove keyword when click selection menu item #4549

New issue

Closed

opened 2026-03-23 21:38:18 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1133
Author: @flappyBug
Created: 9/22/2022
Status: ✅ Merged
Merged: 10/1/2022
Merged by: @LucasXu0

Base: main ← Head: fix/click-selection-menu-item-delete-text

📝 Commits (2)

5782dec fix: remove keyword when click selection menu item
d1d5b37 Merge remote-tracking branch 'origin/main' into fix/click-selection-menu-item-delete-text

📊 Changes

5 files changed (+90 additions, -51 deletions)

View changed files

📝 frontend/app_flowy/packages/appflowy_editor/example/macos/Podfile.lock (+1 -1)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_item_widget.dart (+1 -1)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart (+8 -8)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart (+37 -13)
📝 frontend/app_flowy/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart (+43 -28)

📄 Description

When clicking a selection menu item instead of press enter key, the keyword (e.g. /bul) was not removed. This pr fixes that and adds tests for it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1133 **Author:** [@flappyBug](https://github.com/flappyBug) **Created:** 9/22/2022 **Status:** ✅ Merged **Merged:** 10/1/2022 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/click-selection-menu-item-delete-text` --- ### 📝 Commits (2) - [`5782dec`](https://github.com/AppFlowy-IO/AppFlowy/commit/5782dec45cf2dfb4628fe6f153c52109c9ce5a5b) fix: remove keyword when click selection menu item - [`d1d5b37`](https://github.com/AppFlowy-IO/AppFlowy/commit/d1d5b37c14bfdde05c898987f72514a5bd45d4e5) Merge remote-tracking branch 'origin/main' into fix/click-selection-menu-item-delete-text ### 📊 Changes **5 files changed** (+90 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/appflowy_editor/example/macos/Podfile.lock` (+1 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_item_widget.dart` (+1 -1) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_service.dart` (+8 -8) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/selection_menu/selection_menu_widget.dart` (+37 -13) 📝 `frontend/app_flowy/packages/appflowy_editor/test/render/selection_menu/selection_menu_widget_test.dart` (+43 -28) </details> ### 📄 Description When clicking a selection menu item instead of press `enter` key, the keyword (e.g. `/bul`) was not removed. This pr fixes that and adds tests for it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>