[PR #1147] [MERGED] feat: make Rust installation prompt default to No #4559

New issue

Closed

opened 2026-03-23 21:38:20 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1147
Author: @huyz
Created: 9/24/2022
Status: ✅ Merged
Merged: 9/25/2022
Merged by: @appflowy

Base: main ← Head: main

📝 Commits (1)

69ae3cb feat: make Rust installation prompt default to N

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 frontend/scripts/install_dev_env/install_macos.sh (+3 -3)

📄 Description

It's natural for me to hit ENTER at a prompt when I assume that the default response is to do the less-dangerous thing (which in this case, I would assume to be tied to the N response). But if I do that, the script gets lots of errors.
So I'm adding a default of N to the prompt for installing Rust.

Also, adding an || exit 1 to the cd so that IDE/shellcheck warnings go away.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1147 **Author:** [@huyz](https://github.com/huyz) **Created:** 9/24/2022 **Status:** ✅ Merged **Merged:** 9/25/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`69ae3cb`](https://github.com/AppFlowy-IO/AppFlowy/commit/69ae3cba04c0630ca01b5c3747c778d4f1d1ebdf) feat: make Rust installation prompt default to N ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/scripts/install_dev_env/install_macos.sh` (+3 -3) </details> ### 📄 Description It's natural for me to hit ENTER at a prompt when I assume that the default response is to do the less-dangerous thing (which in this case, I would assume to be tied to the `N` response). But if I do that, the script gets lots of errors. So I'm adding a default of `N` to the prompt for installing Rust. Also, adding an `|| exit 1` to the `cd` so that IDE/shellcheck warnings go away. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>