[PR #1188] [MERGED] feat: add commands and update checkbox logic #4579

New issue

Closed

opened 2026-03-23 21:38:25 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1188
Author: @LucasXu0
Created: 9/28/2022
Status: ✅ Merged
Merged: 9/30/2022
Merged by: @LucasXu0

Base: main ← Head: commands

📝 Commits (6)

6230d0a feat: add commands and update checkbox logic
ab0131c feat: disable apply operation when setting editable = false
99cb243 fix: could not insert link on the Web
6ec93d4 feat: set link menu as auto focus
0a49a18 fix: could not insert space sometimes on the web
8d39dac chore: disable IME support for the Web platform

📊 Changes

16 files changed (+355 additions, -21 deletions)

View changed files

➕ frontend/app_flowy/packages/appflowy_editor/lib/src/commands/edit_text.dart (+34 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/commands/format_built_in_text.dart (+83 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/commands/format_text.dart (+67 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/commands/text_command_infra.dart (+43 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/document/selection.dart (+4 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/editor_state.dart (+5 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/link_menu/link_menu.dart (+1 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/checkbox_text.dart (+8 -11)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/flowy_rich_text.dart (+13 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart (+4 -5)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart (+8 -4)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/editor_service.dart (+2 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/input_service.dart (+5 -1)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/space_on_web_handler.dart (+21 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart (+12 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/space_on_web_handler_test.dart (+45 -0)

📄 Description

Can't enter space on the Web.
When using the insert link feature, autofocus to the input field.
Can't insert a link on the Web.
Checkbox is not working properly on the Web.
Can't insert text sometimes on the Web.
Unable to select the first text or emoji after the image on the Web.
Tab + Shift = Moving the current node to the same level of its parent node.
Deploy the Flutter tests for the Web in CI.
~~Remove the following rules for the link.~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1188 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/28/2022 **Status:** ✅ Merged **Merged:** 9/30/2022 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `commands` --- ### 📝 Commits (6) - [`6230d0a`](https://github.com/AppFlowy-IO/AppFlowy/commit/6230d0ad9fbc74781ce4660435b52354eb4c162c) feat: add commands and update checkbox logic - [`ab0131c`](https://github.com/AppFlowy-IO/AppFlowy/commit/ab0131c19ccfab1709553fcd0d8c766b4c0065ef) feat: disable apply operation when setting editable = false - [`99cb243`](https://github.com/AppFlowy-IO/AppFlowy/commit/99cb2430f724b6188d2a357ed28d0b36c5149d8a) fix: could not insert link on the Web - [`6ec93d4`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ec93d49c2b0b90f16b1b1bddcbc6ade71f20e82) feat: set link menu as auto focus - [`0a49a18`](https://github.com/AppFlowy-IO/AppFlowy/commit/0a49a182808d25f2749d14b27911af7a66d464ff) fix: could not insert space sometimes on the web - [`8d39dac`](https://github.com/AppFlowy-IO/AppFlowy/commit/8d39dac1450fea85c819e7bdecac6370ad6beed1) chore: disable IME support for the Web platform ### 📊 Changes **16 files changed** (+355 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/commands/edit_text.dart` (+34 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/commands/format_built_in_text.dart` (+83 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/commands/format_text.dart` (+67 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/commands/text_command_infra.dart` (+43 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/document/selection.dart` (+4 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/editor_state.dart` (+5 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/link_menu/link_menu.dart` (+1 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/checkbox_text.dart` (+8 -11) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/rich_text/flowy_rich_text.dart` (+13 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart` (+4 -5) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/default_text_operations/format_rich_text_style.dart` (+8 -4) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/editor_service.dart` (+2 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/input_service.dart` (+5 -1) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/space_on_web_handler.dart` (+21 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart` (+12 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/space_on_web_handler_test.dart` (+45 -0) </details> ### 📄 Description - [x] Can't enter space on the Web. - [x] When using the insert link feature, autofocus to the input field. - [x] Can't insert a link on the Web. - [x] Checkbox is not working properly on the Web. - [x] Can't insert text sometimes on the Web. - [x] Unable to select the first text or emoji after the image on the Web. - [ ] `Tab + Shift = ` Moving the current node to the same level of its parent node. - [ ] Deploy the Flutter tests for the Web in CI. - [ ] ~~Remove the following rules for the link.~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>