[PR #1202] [MERGED] fix: make sidebar resizing follow cursor more closely #4592

Closed
opened 2026-03-23 21:38:29 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1202
Author: @richardshiue
Created: 10/1/2022
Status: Merged
Merged: 10/6/2022
Merged by: @appflowy

Base: mainHead: improv-resize-menu


📝 Commits (2)

  • 48639a4 fix: make sidebar resizing follow cursor more closely
  • c90297e fix: don't animate sidebar size changes when dragging

📊 Changes

3 files changed (+55 additions, -13 deletions)

View changed files

📝 frontend/app_flowy/lib/workspace/application/home/home_bloc.dart (+39 -5)
📝 frontend/app_flowy/lib/workspace/presentation/home/home_layout.dart (+1 -2)
📝 frontend/app_flowy/lib/workspace/presentation/home/home_screen.dart (+15 -6)

📄 Description

When the cursor goes out of bounds (beyond the maximum or minimum sidebar width), moving the cursor in the other direction will immediately start resizing the sidebar, even though the cursor isn't close to the edge at all. This patch makes sure that the resizing only occurs when the cursor moves past the edge. I also moved the invisible drag box to the front (5 pixels on the left used to be blocked in debug mode)

Before:

https://user-images.githubusercontent.com/71320345/193412530-d252ef46-9eda-4b8b-b005-03f2e3287334.mp4

After:

https://user-images.githubusercontent.com/71320345/193412557-34d2cd37-9978-4ce5-88fe-ac2951072f12.mp4


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1202 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/1/2022 **Status:** ✅ Merged **Merged:** 10/6/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `improv-resize-menu` --- ### 📝 Commits (2) - [`48639a4`](https://github.com/AppFlowy-IO/AppFlowy/commit/48639a46ceab4494face488bd76cb673fad1d23b) fix: make sidebar resizing follow cursor more closely - [`c90297e`](https://github.com/AppFlowy-IO/AppFlowy/commit/c90297ebb917b038173e5bb25ae5c3521b3a7e3c) fix: don't animate sidebar size changes when dragging ### 📊 Changes **3 files changed** (+55 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/workspace/application/home/home_bloc.dart` (+39 -5) 📝 `frontend/app_flowy/lib/workspace/presentation/home/home_layout.dart` (+1 -2) 📝 `frontend/app_flowy/lib/workspace/presentation/home/home_screen.dart` (+15 -6) </details> ### 📄 Description When the cursor goes out of bounds (beyond the maximum or minimum sidebar width), moving the cursor in the other direction will immediately start resizing the sidebar, even though the cursor isn't close to the edge at all. This patch makes sure that the resizing only occurs when the cursor moves past the edge. I also moved the invisible drag box to the front (5 pixels on the left used to be blocked in debug mode) Before: https://user-images.githubusercontent.com/71320345/193412530-d252ef46-9eda-4b8b-b005-03f2e3287334.mp4 After: https://user-images.githubusercontent.com/71320345/193412557-34d2cd37-9978-4ce5-88fe-ac2951072f12.mp4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 21:38:29 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#4592
No description provided.