[PR #1210] [MERGED] feat: introduce a default font #4597

New issue

Closed

opened 2026-03-23 21:38:31 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1210
Author: @richardshiue
Created: 10/2/2022
Status: ✅ Merged
Merged: 10/25/2022
Merged by: @appflowy

Base: main ← Head: fix-app-fonts

📝 Commits (3)

c883082 style: code auto-format
ecb5270 feat: introduce default poppins font
c01832d chore: port more const textstyles to shared styles

📊 Changes

39 files changed (+351 additions, -249 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/board/presentation/card/board_text_cell.dart (+4 -5)
📝 frontend/app_flowy/lib/plugins/board/presentation/card/board_url_cell.dart (+6 -4)
📝 frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_setting.dart (+2 -2)
📝 frontend/app_flowy/lib/plugins/doc/document.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_accessory.dart (+3 -0)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart (+5 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart (+23 -9)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/number_cell.dart (+4 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart (+3 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/text_cell.dart (+4 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/cell_editor.dart (+4 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart (+6 -4)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart (+3 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart (+4 -1)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart (+4 -1)
📝 frontend/app_flowy/lib/user/presentation/sign_in_screen.dart (+36 -15)
📝 frontend/app_flowy/lib/user/presentation/sign_up_screen.dart (+42 -15)
📝 frontend/app_flowy/lib/user/presentation/skip_log_in_screen.dart (+4 -2)
📝 frontend/app_flowy/lib/user/presentation/widgets/background.dart (+4 -10)
📝 frontend/app_flowy/lib/workspace/presentation/home/menu/app/create_button.dart (+2 -1)

...and 19 more files

📄 Description

This patch stems from #159.

On Linux, installing Noto Color Emoji doesn't fix the emoji character problem completely because it isn't configured as a font fallback. However, setting it as the font fallback creates another problem: the application now falls back to it completely because Mulish isn't on the system, rather than falling back to Flutter's default of Roboto for regular text and Noto Color Emoji for emoji characters. In the screenshot below, the emoji characters are displayed correctly, but the rest of the UI is also in Noto Color Emoji.

Aside from porting most const TextStyle's to a common class, I've also changed the font size to be the scalable fontsize in flowy_infra/lib/size.dart.

These are some other stuff that could be improved upon:

Irregular font sizes not in flowy_infra/lib/size.dart such as 13 used in text fields, and 24 in renaming/creating pages.
Tooltip text
Settings dialog text
Naming conventions (general, TextStyles, not exactly sure)
Letter spacing as per mockups

fixes #1095

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1210 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/2/2022 **Status:** ✅ Merged **Merged:** 10/25/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix-app-fonts` --- ### 📝 Commits (3) - [`c883082`](https://github.com/AppFlowy-IO/AppFlowy/commit/c883082a6d99b1deeaaa6170f3ce4dad29a61b4e) style: code auto-format - [`ecb5270`](https://github.com/AppFlowy-IO/AppFlowy/commit/ecb52701c62c7cd397ea1d2473416f96d842efb9) feat: introduce default poppins font - [`c01832d`](https://github.com/AppFlowy-IO/AppFlowy/commit/c01832db6ab8680038ebbf841105db99523fc5f7) chore: port more const textstyles to shared styles ### 📊 Changes **39 files changed** (+351 additions, -249 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/board_text_cell.dart` (+4 -5) 📝 `frontend/app_flowy/lib/plugins/board/presentation/card/board_url_cell.dart` (+6 -4) 📝 `frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_setting.dart` (+2 -2) 📝 `frontend/app_flowy/lib/plugins/doc/document.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_accessory.dart` (+3 -0) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart` (+5 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart` (+23 -9) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/number_cell.dart` (+4 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart` (+3 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/text_cell.dart` (+4 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/cell_editor.dart` (+4 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart` (+6 -4) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart` (+3 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_editor.dart` (+4 -1) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart` (+4 -1) 📝 `frontend/app_flowy/lib/user/presentation/sign_in_screen.dart` (+36 -15) 📝 `frontend/app_flowy/lib/user/presentation/sign_up_screen.dart` (+42 -15) 📝 `frontend/app_flowy/lib/user/presentation/skip_log_in_screen.dart` (+4 -2) 📝 `frontend/app_flowy/lib/user/presentation/widgets/background.dart` (+4 -10) 📝 `frontend/app_flowy/lib/workspace/presentation/home/menu/app/create_button.dart` (+2 -1) _...and 19 more files_ </details> ### 📄 Description This patch stems from #159. On Linux, installing Noto Color Emoji doesn't fix the emoji character problem completely because it isn't configured as a font fallback. However, setting it as the font fallback creates another problem: the application now falls back to it completely because Mulish isn't on the system, rather than falling back to Flutter's default of Roboto for regular text and Noto Color Emoji for emoji characters. In the screenshot below, the emoji characters are displayed correctly, but the rest of the UI is also in Noto Color Emoji. ![Screenshot_20221003_135804](https://user-images.githubusercontent.com/71320345/193510200-ce890783-5aa1-43ee-b19d-c7b27df5eee1.png) Aside from porting most `const TextStyle`'s to a common class, I've also changed the font size to be the scalable fontsize in `flowy_infra/lib/size.dart`. ![Screenshot_20221003_140036](https://user-images.githubusercontent.com/71320345/193510421-036b7ede-d70a-47f0-8ee2-bdc2f4b2e56b.png) These are some other stuff that could be improved upon: - [x] Irregular font sizes not in `flowy_infra/lib/size.dart` such as 13 used in text fields, and 24 in renaming/creating pages. - [x] Tooltip text - [x] Settings dialog text - [x] Naming conventions (general, TextStyles, not exactly sure) - [x] Letter spacing as per mockups fixes #1095 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>