[PR #1229] [MERGED] [Test]: Improve Code Coverage for extensions files #4606

New issue

Closed

opened 2026-03-23 21:38:33 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1229
Author: @enzoftware
Created: 10/5/2022
Status: ✅ Merged
Merged: 10/8/2022
Merged by: @LucasXu0

Base: main ← Head: main

📝 Commits (10+)

6ea3ea1 chore: remove unused imports
bf9f6ac chore: small code improvements
dd15a49 test: add unit tests for attributes extensions
7914949 test: color tests
50ebaa3 test: object tests
c0aa90b test: text style tests
4acce44 test: add node extension test
b4aceec test: add mockito
fe52473 test: add url launcher test
eaf3966 chore: url launcher test

📊 Changes

14 files changed (+445 additions, -11 deletions)

View changed files

📝 frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/attributes_extension.dart (+8 -6)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/text_node_extensions.dart (+4 -3)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/intl/messages_all.dart (+4 -0)
➕ frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/intl/messages_ml_IN.dart (+45 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/l10n.dart (+1 -0)
📝 frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart (+4 -2)
📝 frontend/app_flowy/packages/appflowy_editor/pubspec.yaml (+1 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/extensions/attributes_extension_test.dart (+201 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/extensions/color_extension_test.dart (+40 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/extensions/node_extension_test.dart (+57 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/extensions/object_extension_test.dart (+20 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/extensions/text_node_extensions_test.dart (+7 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/extensions/text_style_extension_test.dart (+43 -0)
➕ frontend/app_flowy/packages/appflowy_editor/test/extensions/url_launcher_extension_test.dart (+10 -0)

📄 Description

Changelog

Remove unused imports
Small code improvements
Unit test for most extensions
Remove the dynamic method

Screenshot

Related to #1221

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1229 **Author:** [@enzoftware](https://github.com/enzoftware) **Created:** 10/5/2022 **Status:** ✅ Merged **Merged:** 10/8/2022 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`6ea3ea1`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ea3ea189e473337e86c454abd6c4d016ca1b38b) chore: remove unused imports - [`bf9f6ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/bf9f6ac13f75a80a061fd93f2d5d4f465cd41b61) chore: small code improvements - [`dd15a49`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd15a49d765b0725cd15330777f21604429c201b) test: add unit tests for attributes extensions - [`7914949`](https://github.com/AppFlowy-IO/AppFlowy/commit/791494961315e302fe39d2bdddf9c3e9492ec0c3) test: color tests - [`50ebaa3`](https://github.com/AppFlowy-IO/AppFlowy/commit/50ebaa3ab8fef7a696230fa6849761e34fc9169f) test: object tests - [`c0aa90b`](https://github.com/AppFlowy-IO/AppFlowy/commit/c0aa90b0b3058a023cecf22aa5638f3fc9b88c53) test: text style tests - [`4acce44`](https://github.com/AppFlowy-IO/AppFlowy/commit/4acce447f24f808a8c4502a10fb078e3193e27bd) test: add node extension test - [`b4aceec`](https://github.com/AppFlowy-IO/AppFlowy/commit/b4aceec346a4bb544cf1a6e792bcd79df4481311) test: add mockito - [`fe52473`](https://github.com/AppFlowy-IO/AppFlowy/commit/fe524736ec51c8b29ea28180288968b3978643f4) test: add url launcher test - [`eaf3966`](https://github.com/AppFlowy-IO/AppFlowy/commit/eaf396630cb71649af81fdba4b8c30443c8adda8) chore: url launcher test ### 📊 Changes **14 files changed** (+445 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/attributes_extension.dart` (+8 -6) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/extensions/text_node_extensions.dart` (+4 -3) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/intl/messages_all.dart` (+4 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/intl/messages_ml_IN.dart` (+45 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/l10n.dart` (+1 -0) 📝 `frontend/app_flowy/packages/appflowy_editor/lib/src/render/toolbar/toolbar_item.dart` (+4 -2) 📝 `frontend/app_flowy/packages/appflowy_editor/pubspec.yaml` (+1 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/extensions/attributes_extension_test.dart` (+201 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/extensions/color_extension_test.dart` (+40 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/extensions/node_extension_test.dart` (+57 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/extensions/object_extension_test.dart` (+20 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/extensions/text_node_extensions_test.dart` (+7 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/extensions/text_style_extension_test.dart` (+43 -0) ➕ `frontend/app_flowy/packages/appflowy_editor/test/extensions/url_launcher_extension_test.dart` (+10 -0) </details> ### 📄 Description ## Changelog - Remove unused imports - Small code improvements - Unit test for most extensions - Remove the `dynamic` method --- ## Screenshot ![image](https://user-images.githubusercontent.com/22333076/194217251-d141bfe8-9b49-4971-b874-5fb9ff87b37b.png) --- Related to #1221 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>