AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #1169] [FR]: Code coverage for Rust #462

New issue

Closed

opened 2026-03-23 20:36:50 +00:00 by mirror · 4 comments

mirror commented

2026-03-23 20:36:50 +00:00

Owner

Originally created by @appflowy on GitHub (Sep 26, 2022).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1169

Originally assigned to: @SwapnilKumbhar on GitHub.

Enable code coverage for Rust code.

Run in CI, PRs, and centrally for a team
Run locally for fast feedback for an individual.

Reference:

How to do code coverage in Rust

Originally created by @appflowy on GitHub (Sep 26, 2022). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1169 Originally assigned to: @SwapnilKumbhar on GitHub. Enable code coverage for Rust code. * Run in CI, PRs, and centrally for a team * Run locally for fast feedback for an individual. Reference: * [How to do code coverage in Rust](https://blog.rng0.io/how-to-do-code-coverage-in-rust)

mirror

2026-03-23 20:36:50 +00:00

closed this issue
added the
hacktoberfest

help wanted
labels

mirror commented

2026-03-23 20:36:50 +00:00

Author

Owner

@SwapnilKumbhar commented on GitHub (Sep 27, 2022):

I'd love to help with this! Just had a few questions -

Run in CI, PRs, and centrally for a team

What does "centrally for a team" mean here?

Run locally for fast feedback for an individual.

Like an xtask?

@SwapnilKumbhar commented on GitHub (Sep 27, 2022): I'd love to help with this! Just had a few questions - > Run in CI, PRs, and centrally for a team What does "centrally for a team" mean here? > Run locally for fast feedback for an individual. Like an `xtask`?

mirror commented

2026-03-23 20:36:51 +00:00

Author

Owner

@appflowy commented on GitHub (Sep 27, 2022):

What does "centrally for a team" mean here?

Yep, we can run the coverage on the local machine.

Like an xtask?

Yes, just like the xtask. Is it possible to use cargo make instead of xtask? Because AppFlowy use cargo make as the task runner.

@appflowy commented on GitHub (Sep 27, 2022): > What does "centrally for a team" mean here? Yep, we can run the coverage on the local machine. > Like an `xtask`? Yes, just like the `xtask`. Is it possible to use [cargo make ](https://github.com/sagiegurari/cargo-make) instead of `xtask`? Because AppFlowy use [cargo make ](https://github.com/sagiegurari/cargo-make) as the task runner.

mirror commented

2026-03-23 20:36:51 +00:00

Author

Owner

@SwapnilKumbhar commented on GitHub (Sep 27, 2022):

Understood. I'll try to use cargo make on priority, glancing at the project makes me confident that it would be possible. I'll post here if it seems difficult with cargo make.

@SwapnilKumbhar commented on GitHub (Sep 27, 2022): Understood. I'll try to use `cargo make` on priority, glancing at the project makes me confident that it would be possible. I'll post here if it seems difficult with `cargo make`.

mirror commented

2026-03-23 20:36:51 +00:00

Author

Owner

@SwapnilKumbhar commented on GitHub (Oct 3, 2022):

After understanding a few initial details about the task, I have a few questions -

Currently, the rust-lib and shared-lib are both targeting rustc version 1.58. However, coverage instrumentation is introduced in 1.60. So to use it, I have to either upgrade rustc in rust-toolchain.toml or use a nightly version with coverage as an experimental function. Both of these changes affect seem significant. What should I do here?
Since we want coverage reports in the CI, Github actions has a few marketplace plugins that help display lcov style reports in the PR or CI results. Do you have a specific plugin in mind that I should use for this?

@SwapnilKumbhar commented on GitHub (Oct 3, 2022): After understanding a few initial details about the task, I have a few questions - 1. Currently, the `rust-lib` and `shared-lib` are both targeting `rustc` version `1.58`. However, coverage instrumentation is introduced in `1.60`. So to use it, I have to either upgrade `rustc` in rust-toolchain.toml or use a nightly version with coverage as an experimental function. Both of these changes affect seem significant. What should I do here? 2. Since we want coverage reports in the CI, Github actions has a few marketplace plugins that help display `lcov` style reports in the PR or CI results. Do you have a specific plugin in mind that I should use for this?

mirror referenced this issue

2026-03-23 21:36:47 +00:00

[PR #578] [MERGED] feature: Translate new words to French #4209