[PR #1260] [MERGED] Refactor/switch to field #4628

New issue

Closed

opened 2026-03-23 21:38:39 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1260
Author: @appflowy
Created: 10/10/2022
Status: ✅ Merged
Merged: 10/10/2022
Merged by: @appflowy

Base: main ← Head: refactor/switch_to_field

📝 Commits (3)

a2d2765 refactor: remove insertField function in dart
1f94d9d chore: fix test
b8895ce chore: remove unuse code

📊 Changes

20 files changed (+230 additions, -339 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/application/field/field_service.dart (+0 -19)
📝 frontend/app_flowy/lib/plugins/grid/application/field/type_option/type_option_context.dart (+1 -1)
📝 frontend/app_flowy/lib/plugins/grid/application/field/type_option/type_option_data_controller.dart (+16 -39)
📝 frontend/rust-lib/flowy-grid/src/entities/field_entities.rs (+6 -44)
📝 frontend/rust-lib/flowy-grid/src/event_handler.rs (+55 -52)
📝 frontend/rust-lib/flowy-grid/src/event_map.rs (+1 -7)
📝 frontend/rust-lib/flowy-grid/src/services/field/field_builder.rs (+4 -47)
📝 frontend/rust-lib/flowy-grid/src/services/field/mod.rs (+2 -0)
➕ frontend/rust-lib/flowy-grid/src/services/field/type_option_builder.rs (+48 -0)
📝 frontend/rust-lib/flowy-grid/src/services/grid_editor.rs (+29 -48)
📝 frontend/rust-lib/flowy-grid/src/services/grid_view_editor.rs (+2 -9)
📝 frontend/rust-lib/flowy-grid/src/services/grid_view_manager.rs (+1 -2)
📝 frontend/rust-lib/flowy-grid/src/services/group/configuration.rs (+1 -1)
📝 frontend/rust-lib/flowy-grid/src/services/group/controller.rs (+2 -5)
📝 frontend/rust-lib/flowy-grid/tests/grid/field_test/script.rs (+16 -11)
📝 frontend/rust-lib/flowy-grid/tests/grid/field_test/test.rs (+30 -18)
📝 frontend/rust-lib/flowy-grid/tests/grid/field_test/util.rs (+14 -32)
📝 shared-lib/flowy-grid-data-model/src/revision/grid_rev.rs (+0 -1)
📝 shared-lib/flowy-sync/src/client_folder/folder_pad.rs (+1 -1)
📝 shared-lib/lib-ot/src/text_delta/delta.rs (+1 -2)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1260 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 10/10/2022 **Status:** ✅ Merged **Merged:** 10/10/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `refactor/switch_to_field` --- ### 📝 Commits (3) - [`a2d2765`](https://github.com/AppFlowy-IO/AppFlowy/commit/a2d27657dc59550117a52f7149e833b8e3245652) refactor: remove insertField function in dart - [`1f94d9d`](https://github.com/AppFlowy-IO/AppFlowy/commit/1f94d9d496b151758125b09bac14a831db30a9d6) chore: fix test - [`b8895ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/b8895ce787039709394916ca6cc8d0164d09d695) chore: remove unuse code ### 📊 Changes **20 files changed** (+230 additions, -339 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/application/field/field_service.dart` (+0 -19) 📝 `frontend/app_flowy/lib/plugins/grid/application/field/type_option/type_option_context.dart` (+1 -1) 📝 `frontend/app_flowy/lib/plugins/grid/application/field/type_option/type_option_data_controller.dart` (+16 -39) 📝 `frontend/rust-lib/flowy-grid/src/entities/field_entities.rs` (+6 -44) 📝 `frontend/rust-lib/flowy-grid/src/event_handler.rs` (+55 -52) 📝 `frontend/rust-lib/flowy-grid/src/event_map.rs` (+1 -7) 📝 `frontend/rust-lib/flowy-grid/src/services/field/field_builder.rs` (+4 -47) 📝 `frontend/rust-lib/flowy-grid/src/services/field/mod.rs` (+2 -0) ➕ `frontend/rust-lib/flowy-grid/src/services/field/type_option_builder.rs` (+48 -0) 📝 `frontend/rust-lib/flowy-grid/src/services/grid_editor.rs` (+29 -48) 📝 `frontend/rust-lib/flowy-grid/src/services/grid_view_editor.rs` (+2 -9) 📝 `frontend/rust-lib/flowy-grid/src/services/grid_view_manager.rs` (+1 -2) 📝 `frontend/rust-lib/flowy-grid/src/services/group/configuration.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-grid/src/services/group/controller.rs` (+2 -5) 📝 `frontend/rust-lib/flowy-grid/tests/grid/field_test/script.rs` (+16 -11) 📝 `frontend/rust-lib/flowy-grid/tests/grid/field_test/test.rs` (+30 -18) 📝 `frontend/rust-lib/flowy-grid/tests/grid/field_test/util.rs` (+14 -32) 📝 `shared-lib/flowy-grid-data-model/src/revision/grid_rev.rs` (+0 -1) 📝 `shared-lib/flowy-sync/src/client_folder/folder_pad.rs` (+1 -1) 📝 `shared-lib/lib-ot/src/text_delta/delta.rs` (+1 -2) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>