[PR #1264] [MERGED] feat: alter some select option editor bloc events and add tests #4632

New issue

Closed

opened 2026-03-23 21:38:40 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 21:38:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/1264
Author: @richardshiue
Created: 10/11/2022
Status: ✅ Merged
Merged: 10/22/2022
Merged by: @appflowy

Base: main ← Head: separator-select-pt2

📝 Commits (9)

6dee64b chore: separate select and unselect events
4715fb9 style: improve readability
da20000 chore: don't send empty payloads if we can help it
25ff801 test: add select option text field test
70b652d test: complete bloc test for select option
b569021 test: delete all options between each test
f44fb26 fix: keep insert order
3d9d895 test: combine select and unselect tests
8172c2e chore: remove duplicate wait

📊 Changes

6 files changed (+324 additions, -43 deletions)

View changed files

📝 frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart (+35 -24)
📝 frontend/app_flowy/lib/plugins/grid/application/cell/select_option_service.dart (+3 -4)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart (+9 -3)
📝 frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart (+9 -10)
📝 frontend/app_flowy/test/bloc_test/grid_test/select_option_bloc_test.dart (+178 -2)
➕ frontend/app_flowy/test/widget_test/select_option_text_field_test.dart (+90 -0)

📄 Description

Test plan:

add tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/1264 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/11/2022 **Status:** ✅ Merged **Merged:** 10/22/2022 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `separator-select-pt2` --- ### 📝 Commits (9) - [`6dee64b`](https://github.com/AppFlowy-IO/AppFlowy/commit/6dee64bc8ea24f51507fdaa80086e07e59a08d7a) chore: separate select and unselect events - [`4715fb9`](https://github.com/AppFlowy-IO/AppFlowy/commit/4715fb9ab329bd95640917d06d0e39fcee138341) style: improve readability - [`da20000`](https://github.com/AppFlowy-IO/AppFlowy/commit/da2000069353cd6b09c3c8168d87ac963f4fd2b0) chore: don't send empty payloads if we can help it - [`25ff801`](https://github.com/AppFlowy-IO/AppFlowy/commit/25ff801ad44e4e50202209db66cea04f390e4af8) test: add select option text field test - [`70b652d`](https://github.com/AppFlowy-IO/AppFlowy/commit/70b652dae7b040466ed6aada219c720b42e4a09c) test: complete bloc test for select option - [`b569021`](https://github.com/AppFlowy-IO/AppFlowy/commit/b5690210196ea9dae35ea61ed42bb58e3dfc6fa5) test: delete all options between each test - [`f44fb26`](https://github.com/AppFlowy-IO/AppFlowy/commit/f44fb268e5c43e54c1a6b39d62a917f651502c39) fix: keep insert order - [`3d9d895`](https://github.com/AppFlowy-IO/AppFlowy/commit/3d9d895df53a0574fe9a741c98ae339ff917cd23) test: combine select and unselect tests - [`8172c2e`](https://github.com/AppFlowy-IO/AppFlowy/commit/8172c2e4f0c2fd6adc8a1c3e87e17fdebb94ba4b) chore: remove duplicate wait ### 📊 Changes **6 files changed** (+324 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/select_option_editor_bloc.dart` (+35 -24) 📝 `frontend/app_flowy/lib/plugins/grid/application/cell/select_option_service.dart` (+3 -4) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart` (+9 -3) 📝 `frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/text_field.dart` (+9 -10) 📝 `frontend/app_flowy/test/bloc_test/grid_test/select_option_bloc_test.dart` (+178 -2) ➕ `frontend/app_flowy/test/widget_test/select_option_text_field_test.dart` (+90 -0) </details> ### 📄 Description Test plan: - [x] add tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>